From: Javier Martinez Canillas <javierm@redhat.com>
To: Peter Robinson <pbrobinson@gmail.com>,
Doug Berger <opendmb@gmail.com>,
Florian Fainelli <f.fainelli@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
bcm-kernel-feedback-list@broadcom.com, netdev@vger.kernel.org
Subject: Re: [PATCH] net: bcmgenet: Return not supported if we don't have a WoL IRQ
Date: Tue, 22 Feb 2022 11:03:38 +0100 [thread overview]
Message-ID: <3d2becea-77c3-b89d-8a3c-b1c04b999b02@redhat.com> (raw)
In-Reply-To: <20220222095348.2926536-1-pbrobinson@gmail.com>
Hello Peter,
On 2/22/22 10:53, Peter Robinson wrote:
> The ethtool WoL enable function wasn't checking if the device
> has the optional WoL IRQ and hence on platforms such as the
> Raspberry Pi 4 which had working ethernet prior to the last
> fix regressed with the last fix, so also check if we have a
> WoL IRQ there and return ENOTSUPP if not.
>
> Fixes: 9deb48b53e7f ("bcmgenet: add WOL IRQ check")
> Fixes: 8562056f267d ("net: bcmgenet: request Wake-on-LAN interrupt")
> Signed-off-by: Peter Robinson <pbrobinson@gmail.com>
> Suggested-by: Javier Martinez Canillas <javierm@redhat.com>
> ---
The patch looks good to me.
Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>
Best regards,
--
Javier Martinez Canillas
Linux Engineering
Red Hat
next prev parent reply other threads:[~2022-02-22 10:03 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-22 9:53 [PATCH] net: bcmgenet: Return not supported if we don't have a WoL IRQ Peter Robinson
2022-02-22 10:03 ` Javier Martinez Canillas [this message]
2022-02-22 16:42 ` Florian Fainelli
2022-02-22 20:07 ` Peter Robinson
2022-02-22 20:15 ` Florian Fainelli
2022-02-23 11:40 ` Peter Robinson
2022-02-23 17:35 ` Florian Fainelli
2022-02-23 17:41 ` Peter Robinson
2022-02-23 17:45 ` Peter Robinson
2022-02-23 17:54 ` Florian Fainelli
2022-02-23 22:48 ` Jakub Kicinski
2022-02-23 22:58 ` Florian Fainelli
2022-02-23 23:15 ` Jakub Kicinski
2022-03-02 18:02 ` Jakub Kicinski
2022-03-02 18:20 ` Florian Fainelli
2022-03-03 20:00 ` Jeremy Linton
2022-03-03 20:04 ` Javier Martinez Canillas
2022-03-04 17:33 ` Jeremy Linton
2022-03-04 20:12 ` Florian Fainelli
2022-03-07 18:27 ` Jeremy Linton
2022-03-07 18:44 ` Florian Fainelli
2022-03-07 19:23 ` Jeremy Linton
2022-02-24 9:34 ` Peter Robinson
2022-03-02 5:00 ` Jeremy Linton
2022-03-02 9:34 ` Peter Robinson
2022-02-22 23:42 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3d2becea-77c3-b89d-8a3c-b1c04b999b02@redhat.com \
--to=javierm@redhat.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=opendmb@gmail.com \
--cc=pbrobinson@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.