From: Pekka Paalanen <ppaalanen@gmail.com>
To: Thomas Zimmermann <tzimmermann@suse.de>
Cc: daniel@ffwll.ch, deller@gmx.de, javierm@redhat.com,
geert@linux-m68k.org, sam@ravnborg.org, kraxel@redhat.com,
linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v2 4/5] fbdev: Improve performance of cfb_imageblit()
Date: Tue, 22 Feb 2022 15:01:11 +0200 [thread overview]
Message-ID: <20220222150111.506d2cee@eldfell> (raw)
In-Reply-To: <20220221195410.9172-5-tzimmermann@suse.de>
[-- Attachment #1: Type: text/plain, Size: 999 bytes --]
On Mon, 21 Feb 2022 20:54:09 +0100
Thomas Zimmermann <tzimmermann@suse.de> wrote:
> Improve the performance of sys_imageblit() by manually unrolling
sys?
> the inner blitting loop and moving some invariants out. The compiler
> failed to do this automatically. This change keeps cfb_imageblit()
> in sync with sys_imagebit().
This is correct here.
>
> A microbenchmark measures the average number of CPU cycles
> for sys_imageblit() after a stabilizing period of a few minutes
sys?
> (i7-4790, FullHD, simpledrm, kernel with debugging).
>
> sys_imageblit(), new: 15724 cycles
sys?
> cfb_imageblit(): old: 30566 cycles
>
> In the optimized case, cfb_imageblit() is now ~2x faster than before.
>
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
> ---
> drivers/video/fbdev/core/cfbimgblt.c | 51 +++++++++++++++++++++++-----
> 1 file changed, 42 insertions(+), 9 deletions(-)
Just noticed some confusion in the commit message.
Thanks,
pq
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Pekka Paalanen <ppaalanen@gmail.com>
To: Thomas Zimmermann <tzimmermann@suse.de>
Cc: linux-fbdev@vger.kernel.org, deller@gmx.de, javierm@redhat.com,
dri-devel@lists.freedesktop.org, geert@linux-m68k.org,
kraxel@redhat.com, sam@ravnborg.org
Subject: Re: [PATCH v2 4/5] fbdev: Improve performance of cfb_imageblit()
Date: Tue, 22 Feb 2022 15:01:11 +0200 [thread overview]
Message-ID: <20220222150111.506d2cee@eldfell> (raw)
In-Reply-To: <20220221195410.9172-5-tzimmermann@suse.de>
[-- Attachment #1: Type: text/plain, Size: 999 bytes --]
On Mon, 21 Feb 2022 20:54:09 +0100
Thomas Zimmermann <tzimmermann@suse.de> wrote:
> Improve the performance of sys_imageblit() by manually unrolling
sys?
> the inner blitting loop and moving some invariants out. The compiler
> failed to do this automatically. This change keeps cfb_imageblit()
> in sync with sys_imagebit().
This is correct here.
>
> A microbenchmark measures the average number of CPU cycles
> for sys_imageblit() after a stabilizing period of a few minutes
sys?
> (i7-4790, FullHD, simpledrm, kernel with debugging).
>
> sys_imageblit(), new: 15724 cycles
sys?
> cfb_imageblit(): old: 30566 cycles
>
> In the optimized case, cfb_imageblit() is now ~2x faster than before.
>
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
> ---
> drivers/video/fbdev/core/cfbimgblt.c | 51 +++++++++++++++++++++++-----
> 1 file changed, 42 insertions(+), 9 deletions(-)
Just noticed some confusion in the commit message.
Thanks,
pq
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2022-02-22 13:01 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-21 19:54 [PATCH v2 0/5] fbdev: Improve performance of fbdev console Thomas Zimmermann
2022-02-21 19:54 ` Thomas Zimmermann
2022-02-21 19:54 ` [PATCH v2 1/5] fbdev: Improve performance of sys_fillrect() Thomas Zimmermann
2022-02-21 19:54 ` Thomas Zimmermann
2022-02-21 19:54 ` [PATCH v2 2/5] fbdev: Improve performance of sys_imageblit() Thomas Zimmermann
2022-02-21 19:54 ` Thomas Zimmermann
2022-02-21 19:54 ` [PATCH v2 3/5] fbdev: Remove trailing whitespaces from cfbimgblt.c Thomas Zimmermann
2022-02-21 19:54 ` Thomas Zimmermann
2022-02-21 19:54 ` [PATCH v2 4/5] fbdev: Improve performance of cfb_imageblit() Thomas Zimmermann
2022-02-21 19:54 ` Thomas Zimmermann
2022-02-22 13:01 ` Pekka Paalanen [this message]
2022-02-22 13:01 ` Pekka Paalanen
2022-02-22 18:48 ` Thomas Zimmermann
2022-02-21 19:54 ` [PATCH v2 5/5] drm: Add TODO item for optimizing format helpers Thomas Zimmermann
2022-02-21 19:54 ` Thomas Zimmermann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220222150111.506d2cee@eldfell \
--to=ppaalanen@gmail.com \
--cc=daniel@ffwll.ch \
--cc=deller@gmx.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=geert@linux-m68k.org \
--cc=javierm@redhat.com \
--cc=kraxel@redhat.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=sam@ravnborg.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.