From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Peter Korsgaard <peter@korsgaard.com>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH] Makefile: unexport 'DEVICE_TREE' environment variable
Date: Wed, 23 Feb 2022 15:05:45 +0100 [thread overview]
Message-ID: <20220223140545.GA179822@scaer> (raw)
In-Reply-To: <20220223124109.2370215-1-peter@korsgaard.com>
Peter, All,
On 2022-02-23 13:41 +0100, Peter Korsgaard spake thusly:
> U-Boot looks for the environment variable DEVICE_TREE and uses its value if
> set instead of the CONFIG_DEFAULT_DEVICE_TREE configuration option since
> v2021.01, more specifically commit c0f1ebe9c1b9745e (binman: Allow selecting
> default FIT configuration) - So unexport it like we do for other
> "troublesome" environment variables to ensure consistent behaviour.
>
> Reported-by: Neal Frager <nealf@xilinx.com>
> Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
Applied to master, thanks.
Regards,
Yann E. MORIN.
> ---
> Makefile | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Makefile b/Makefile
> index d92438166f..0ed93e600d 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -426,6 +426,7 @@ unexport O
> unexport GCC_COLORS
> unexport PLATFORM
> unexport OS
> +unexport DEVICE_TREE
>
> GNU_HOST_NAME := $(shell support/gnuconfig/config.guess)
>
> --
> 2.30.2
>
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2022-02-23 14:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-23 12:41 [Buildroot] [PATCH] Makefile: unexport 'DEVICE_TREE' environment variable Peter Korsgaard
2022-02-23 14:05 ` Yann E. MORIN [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220223140545.GA179822@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@buildroot.org \
--cc=peter@korsgaard.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.