[Buildroot] [PATCH] Makefile: unexport 'DEVICE_TREE' environment variable

[Buildroot] [PATCH] Makefile: unexport 'DEVICE_TREE' environment variable

[Peter Korsgaard]

U-Boot looks for the environment variable DEVICE_TREE and uses its value if
set instead of the CONFIG_DEFAULT_DEVICE_TREE configuration option since
v2021.01, more specifically commit c0f1ebe9c1b9745e (binman: Allow selecting
default FIT configuration) - So unexport it like we do for other
"troublesome" environment variables to ensure consistent behaviour.

Reported-by: Neal Frager <nealf@xilinx.com>
Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
---
 Makefile | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Makefile b/Makefile
index d92438166f..0ed93e600d 100644
--- a/Makefile
+++ b/Makefile
@@ -426,6 +426,7 @@ unexport O
 unexport GCC_COLORS
 unexport PLATFORM
 unexport OS
+unexport DEVICE_TREE
 
 GNU_HOST_NAME := $(shell support/gnuconfig/config.guess)
 
-- 
2.30.2

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH] Makefile: unexport 'DEVICE_TREE' environment variable

[Yann E. MORIN]

Peter, All,

On 2022-02-23 13:41 +0100, Peter Korsgaard spake thusly:
> U-Boot looks for the environment variable DEVICE_TREE and uses its value if
> set instead of the CONFIG_DEFAULT_DEVICE_TREE configuration option since
> v2021.01, more specifically commit c0f1ebe9c1b9745e (binman: Allow selecting
> default FIT configuration) - So unexport it like we do for other
> "troublesome" environment variables to ensure consistent behaviour.
> 
> Reported-by: Neal Frager <nealf@xilinx.com>
> Signed-off-by: Peter Korsgaard <peter@korsgaard.com>

Applied to master, thanks.

Regards,
Yann E. MORIN.

> ---
>  Makefile | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Makefile b/Makefile
> index d92438166f..0ed93e600d 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -426,6 +426,7 @@ unexport O
>  unexport GCC_COLORS
>  unexport PLATFORM
>  unexport OS
> +unexport DEVICE_TREE
>  
>  GNU_HOST_NAME := $(shell support/gnuconfig/config.guess)
>  
> -- 
> 2.30.2
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot