From: Segher Boessenkool <segher@kernel.crashing.org>
To: Anders Roxell <anders.roxell@linaro.org>
Cc: stable@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
linux-kernel@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH 3/3] powerpc: lib: sstep: fix build errors
Date: Wed, 23 Feb 2022 09:27:19 -0600 [thread overview]
Message-ID: <20220223152719.GF614@gate.crashing.org> (raw)
In-Reply-To: <20220223135820.2252470-3-anders.roxell@linaro.org>
On Wed, Feb 23, 2022 at 02:58:20PM +0100, Anders Roxell wrote:
> Building tinyconfig with gcc (Debian 11.2.0-16) and assembler (Debian
> 2.37.90.20220207) the following build error shows up:
>
> {standard input}: Assembler messages:
> {standard input}:10576: Error: unrecognized opcode: `stbcx.'
> {standard input}:10680: Error: unrecognized opcode: `lharx'
> {standard input}:10694: Error: unrecognized opcode: `lbarx'
>
> Rework to add assembler directives [1] around the instruction. The
> problem with this might be that we can trick a power6 into
> single-stepping through an stbcx. for instance, and it will execute that
> in kernel mode.
>
> [1] https://sourceware.org/binutils/docs/as/PowerPC_002dPseudo.html#PowerPC_002dPseudo
Wow, no wonder you think you need quotes after reading that. I'll try
to get that fixed.
Reviewed-by: Segher Boessenkool <segher@kernel.crashing.org>
Segher
WARNING: multiple messages have this Message-ID (diff)
From: Segher Boessenkool <segher@kernel.crashing.org>
To: Anders Roxell <anders.roxell@linaro.org>
Cc: mpe@ellerman.id.au, Arnd Bergmann <arnd@arndb.de>,
linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH 3/3] powerpc: lib: sstep: fix build errors
Date: Wed, 23 Feb 2022 09:27:19 -0600 [thread overview]
Message-ID: <20220223152719.GF614@gate.crashing.org> (raw)
In-Reply-To: <20220223135820.2252470-3-anders.roxell@linaro.org>
On Wed, Feb 23, 2022 at 02:58:20PM +0100, Anders Roxell wrote:
> Building tinyconfig with gcc (Debian 11.2.0-16) and assembler (Debian
> 2.37.90.20220207) the following build error shows up:
>
> {standard input}: Assembler messages:
> {standard input}:10576: Error: unrecognized opcode: `stbcx.'
> {standard input}:10680: Error: unrecognized opcode: `lharx'
> {standard input}:10694: Error: unrecognized opcode: `lbarx'
>
> Rework to add assembler directives [1] around the instruction. The
> problem with this might be that we can trick a power6 into
> single-stepping through an stbcx. for instance, and it will execute that
> in kernel mode.
>
> [1] https://sourceware.org/binutils/docs/as/PowerPC_002dPseudo.html#PowerPC_002dPseudo
Wow, no wonder you think you need quotes after reading that. I'll try
to get that fixed.
Reviewed-by: Segher Boessenkool <segher@kernel.crashing.org>
Segher
next prev parent reply other threads:[~2022-02-23 15:30 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-23 13:58 [PATCH 1/3] powerpc: lib: sstep: fix 'sthcx' instruction Anders Roxell
2022-02-23 13:58 ` Anders Roxell
2022-02-23 13:58 ` [PATCH 2/3] powerpc: fix build errors Anders Roxell
2022-02-23 13:58 ` Anders Roxell
2022-02-23 15:21 ` Segher Boessenkool
2022-02-23 15:21 ` Segher Boessenkool
2022-02-24 2:54 ` Nicholas Piggin
2022-02-24 2:54 ` Nicholas Piggin
2022-02-24 5:05 ` Nicholas Piggin
2022-02-24 5:05 ` Nicholas Piggin
2022-02-24 8:55 ` Arnd Bergmann
2022-02-24 8:55 ` Arnd Bergmann
2022-02-24 10:11 ` Nicholas Piggin
2022-02-24 10:11 ` Nicholas Piggin
2022-02-24 10:20 ` Arnd Bergmann
2022-02-24 10:20 ` Arnd Bergmann
2022-02-24 11:13 ` Nicholas Piggin
2022-02-24 11:13 ` Nicholas Piggin
2022-02-24 17:29 ` Segher Boessenkool
2022-02-24 17:29 ` Segher Boessenkool
2022-02-25 0:23 ` Nicholas Piggin
2022-02-25 0:23 ` Nicholas Piggin
2022-02-25 22:28 ` Segher Boessenkool
2022-02-25 22:28 ` Segher Boessenkool
2022-02-26 0:07 ` Nicholas Piggin
2022-02-26 0:07 ` Nicholas Piggin
2022-02-24 17:12 ` Segher Boessenkool
2022-02-24 17:12 ` Segher Boessenkool
2022-02-25 0:32 ` Nicholas Piggin
2022-02-25 0:32 ` Nicholas Piggin
2022-02-25 8:33 ` Arnd Bergmann
2022-02-25 8:33 ` Arnd Bergmann
2022-02-25 10:51 ` Nicholas Piggin
2022-02-25 10:51 ` Nicholas Piggin
2022-02-25 22:33 ` Segher Boessenkool
2022-02-25 22:33 ` Segher Boessenkool
2022-02-24 12:39 ` Michael Ellerman
2022-02-24 12:39 ` Michael Ellerman
2022-02-24 16:12 ` Anders Roxell
2022-02-24 16:12 ` Anders Roxell
2022-02-24 17:37 ` Segher Boessenkool
2022-02-24 17:37 ` Segher Boessenkool
2022-02-23 13:58 ` [PATCH 3/3] powerpc: lib: sstep: " Anders Roxell
2022-02-23 13:58 ` Anders Roxell
2022-02-23 15:27 ` Segher Boessenkool [this message]
2022-02-23 15:27 ` Segher Boessenkool
2022-02-24 2:40 ` [PATCH 1/3] powerpc: lib: sstep: fix 'sthcx' instruction Nicholas Piggin
2022-02-24 2:40 ` Nicholas Piggin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220223152719.GF614@gate.crashing.org \
--to=segher@kernel.crashing.org \
--cc=anders.roxell@linaro.org \
--cc=arnd@arndb.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.