From: Jason Gunthorpe via iommu <iommu@lists.linux-foundation.org>
To: Robin Murphy <robin.murphy@arm.com>
Cc: Stuart Yoder <stuyoder@gmail.com>,
rafael@kernel.org, David Airlie <airlied@linux.ie>,
linux-pci@vger.kernel.org,
Thierry Reding <thierry.reding@gmail.com>,
Diana Craciun <diana.craciun@oss.nxp.com>,
Dmitry Osipenko <digetx@gmail.com>, Will Deacon <will@kernel.org>,
Ashok Raj <ashok.raj@intel.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
Christoph Hellwig <hch@infradead.org>,
Kevin Tian <kevin.tian@intel.com>,
Chaitanya Kulkarni <kch@nvidia.com>,
Alex Williamson <alex.williamson@redhat.com>,
kvm@vger.kernel.org, Bjorn Helgaas <bhelgaas@google.com>,
Dan Williams <dan.j.williams@intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Cornelia Huck <cohuck@redhat.com>,
linux-kernel@vger.kernel.org, Li Yang <leoyang.li@nxp.com>,
iommu@lists.linux-foundation.org,
Jacob jun Pan <jacob.jun.pan@intel.com>,
Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH v6 01/11] iommu: Add dma ownership management interfaces
Date: Wed, 23 Feb 2022 14:32:48 -0400 [thread overview]
Message-ID: <20220223183248.GC390403@nvidia.com> (raw)
In-Reply-To: <2114e6e6-68cc-4552-8781-0a824de2c0de@arm.com>
On Wed, Feb 23, 2022 at 06:20:36PM +0000, Robin Murphy wrote:
> On 2022-02-23 18:02, Jason Gunthorpe via iommu wrote:
> > On Wed, Feb 23, 2022 at 06:00:06PM +0000, Robin Murphy wrote:
> >
> > > ...and equivalently just set owner_cnt directly to 0 here. I don't see a
> > > realistic use-case for any driver to claim the same group more than once,
> > > and allowing it in the API just feels like opening up various potential
> > > corners for things to get out of sync.
> >
> > I am Ok if we toss it out to get this merged, as there is no in-kernel
> > user right now.
> >
> > Something will have to come back for iommufd, but we can look at what
> > is best suited then.
>
> If iommufd plans to be too dumb to keep track of whether it already owns a
> given group or not, I can't see it dealing with attaching that group to a
> single domain no more than once, either ;)
Indeed, this is why I'd like to use the device API :)
Jason
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
WARNING: multiple messages have this Message-ID (diff)
From: Jason Gunthorpe <jgg@nvidia.com>
To: Robin Murphy <robin.murphy@arm.com>
Cc: Stuart Yoder <stuyoder@gmail.com>,
rafael@kernel.org, David Airlie <airlied@linux.ie>,
linux-pci@vger.kernel.org,
Thierry Reding <thierry.reding@gmail.com>,
Diana Craciun <diana.craciun@oss.nxp.com>,
Dmitry Osipenko <digetx@gmail.com>, Will Deacon <will@kernel.org>,
Ashok Raj <ashok.raj@intel.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
Christoph Hellwig <hch@infradead.org>,
Kevin Tian <kevin.tian@intel.com>,
Chaitanya Kulkarni <kch@nvidia.com>,
Alex Williamson <alex.williamson@redhat.com>,
kvm@vger.kernel.org, Bjorn Helgaas <bhelgaas@google.com>,
Dan Williams <dan.j.williams@intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Cornelia Huck <cohuck@redhat.com>,
linux-kernel@vger.kernel.org, Li Yang <leoyang.li@nxp.com>,
iommu@lists.linux-foundation.org,
Jacob jun Pan <jacob.jun.pan@intel.com>,
Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH v6 01/11] iommu: Add dma ownership management interfaces
Date: Wed, 23 Feb 2022 14:32:48 -0400 [thread overview]
Message-ID: <20220223183248.GC390403@nvidia.com> (raw)
In-Reply-To: <2114e6e6-68cc-4552-8781-0a824de2c0de@arm.com>
On Wed, Feb 23, 2022 at 06:20:36PM +0000, Robin Murphy wrote:
> On 2022-02-23 18:02, Jason Gunthorpe via iommu wrote:
> > On Wed, Feb 23, 2022 at 06:00:06PM +0000, Robin Murphy wrote:
> >
> > > ...and equivalently just set owner_cnt directly to 0 here. I don't see a
> > > realistic use-case for any driver to claim the same group more than once,
> > > and allowing it in the API just feels like opening up various potential
> > > corners for things to get out of sync.
> >
> > I am Ok if we toss it out to get this merged, as there is no in-kernel
> > user right now.
> >
> > Something will have to come back for iommufd, but we can look at what
> > is best suited then.
>
> If iommufd plans to be too dumb to keep track of whether it already owns a
> given group or not, I can't see it dealing with attaching that group to a
> single domain no more than once, either ;)
Indeed, this is why I'd like to use the device API :)
Jason
next prev parent reply other threads:[~2022-02-23 18:32 UTC|newest]
Thread overview: 90+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-18 0:55 [PATCH v6 00/11] Fix BUG_ON in vfio_iommu_group_notifier() Lu Baolu
2022-02-18 0:55 ` Lu Baolu
2022-02-18 0:55 ` [PATCH v6 01/11] iommu: Add dma ownership management interfaces Lu Baolu
2022-02-18 0:55 ` Lu Baolu
2022-02-19 7:31 ` Christoph Hellwig
2022-02-19 7:31 ` Christoph Hellwig
2022-02-21 4:02 ` Lu Baolu
2022-02-21 4:02 ` Lu Baolu
2022-02-23 18:00 ` Robin Murphy
2022-02-23 18:00 ` Robin Murphy
2022-02-23 18:02 ` Jason Gunthorpe via iommu
2022-02-23 18:02 ` Jason Gunthorpe
2022-02-23 18:20 ` Robin Murphy
2022-02-23 18:20 ` Robin Murphy
2022-02-23 18:32 ` Jason Gunthorpe via iommu [this message]
2022-02-23 18:32 ` Jason Gunthorpe
2022-02-24 5:16 ` Lu Baolu
2022-02-24 5:16 ` Lu Baolu
2022-02-24 5:29 ` Lu Baolu
2022-02-24 5:29 ` Lu Baolu
2022-02-24 8:58 ` Robin Murphy
2022-02-24 8:58 ` Robin Murphy
2022-02-24 5:21 ` Lu Baolu
2022-02-24 5:21 ` Lu Baolu
2022-02-18 0:55 ` [PATCH v6 02/11] driver core: Add dma_cleanup callback in bus_type Lu Baolu
2022-02-18 0:55 ` Lu Baolu
2022-02-19 7:32 ` Christoph Hellwig
2022-02-19 7:32 ` Christoph Hellwig
2022-02-21 20:43 ` Robin Murphy
2022-02-21 20:43 ` Robin Murphy
2022-02-21 23:48 ` Jason Gunthorpe via iommu
2022-02-21 23:48 ` Jason Gunthorpe
2022-02-22 4:48 ` Lu Baolu
2022-02-22 4:48 ` Lu Baolu
2022-02-22 10:58 ` Robin Murphy
2022-02-22 10:58 ` Robin Murphy
2022-02-22 15:16 ` Jason Gunthorpe via iommu
2022-02-22 15:16 ` Jason Gunthorpe
2022-02-22 21:18 ` Robin Murphy
2022-02-22 21:18 ` Robin Murphy
2022-02-22 23:53 ` Jason Gunthorpe via iommu
2022-02-22 23:53 ` Jason Gunthorpe
2022-02-23 5:01 ` Lu Baolu
2022-02-23 5:01 ` Lu Baolu
2022-02-23 13:04 ` Robin Murphy
2022-02-23 13:04 ` Robin Murphy
2022-02-23 13:46 ` Jason Gunthorpe via iommu
2022-02-23 13:46 ` Jason Gunthorpe
2022-02-23 14:06 ` Greg Kroah-Hartman
2022-02-23 14:06 ` Greg Kroah-Hartman
2022-02-23 14:09 ` Jason Gunthorpe via iommu
2022-02-23 14:09 ` Jason Gunthorpe
2022-02-23 14:30 ` Jason Gunthorpe via iommu
2022-02-23 14:30 ` Jason Gunthorpe
2022-02-23 16:03 ` Greg Kroah-Hartman
2022-02-23 16:03 ` Greg Kroah-Hartman
2022-02-23 17:05 ` Robin Murphy
2022-02-23 17:05 ` Robin Murphy
2022-02-23 17:47 ` Greg Kroah-Hartman
2022-02-23 17:47 ` Greg Kroah-Hartman
2022-02-18 0:55 ` [PATCH v6 03/11] amba: Stop sharing platform_dma_configure() Lu Baolu
2022-02-18 0:55 ` Lu Baolu
2022-02-18 0:55 ` [PATCH v6 04/11] bus: platform, amba, fsl-mc, PCI: Add device DMA ownership management Lu Baolu
2022-02-18 0:55 ` [PATCH v6 04/11] bus: platform,amba,fsl-mc,PCI: " Lu Baolu
2022-02-18 7:55 ` Greg Kroah-Hartman
2022-02-18 7:55 ` Greg Kroah-Hartman
2022-02-18 0:55 ` [PATCH v6 05/11] PCI: pci_stub: Set driver_managed_dma Lu Baolu
2022-02-18 0:55 ` Lu Baolu
2022-02-18 0:55 ` [PATCH v6 06/11] PCI: portdrv: " Lu Baolu
2022-02-18 0:55 ` Lu Baolu
2022-02-18 0:55 ` [PATCH v6 07/11] vfio: Set DMA ownership for VFIO devices Lu Baolu
2022-02-18 0:55 ` Lu Baolu
2022-02-18 0:55 ` [PATCH v6 08/11] vfio: Remove use of vfio_group_viable() Lu Baolu
2022-02-18 0:55 ` Lu Baolu
2022-02-18 0:55 ` [PATCH v6 09/11] vfio: Delete the unbound_list Lu Baolu
2022-02-18 0:55 ` Lu Baolu
2022-02-18 0:55 ` [PATCH v6 10/11] vfio: Remove iommu group notifier Lu Baolu
2022-02-18 0:55 ` Lu Baolu
2022-02-23 21:53 ` Alex Williamson
2022-02-23 21:53 ` Alex Williamson
2022-02-24 2:49 ` Lu Baolu
2022-02-24 2:49 ` Lu Baolu
2022-02-18 0:55 ` [PATCH v6 11/11] iommu: Remove iommu group changes notifier Lu Baolu
2022-02-18 0:55 ` Lu Baolu
2022-02-18 15:51 ` [PATCH v6 00/11] Fix BUG_ON in vfio_iommu_group_notifier() Jason Gunthorpe via iommu
2022-02-18 15:51 ` Jason Gunthorpe
2022-02-21 3:38 ` Lu Baolu
2022-02-21 3:38 ` Lu Baolu
2022-02-28 0:58 ` Lu Baolu
2022-02-28 0:58 ` Lu Baolu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220223183248.GC390403@nvidia.com \
--to=iommu@lists.linux-foundation.org \
--cc=airlied@linux.ie \
--cc=alex.williamson@redhat.com \
--cc=ashok.raj@intel.com \
--cc=bhelgaas@google.com \
--cc=cohuck@redhat.com \
--cc=dan.j.williams@intel.com \
--cc=daniel@ffwll.ch \
--cc=diana.craciun@oss.nxp.com \
--cc=digetx@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=hch@infradead.org \
--cc=jacob.jun.pan@intel.com \
--cc=jgg@nvidia.com \
--cc=jonathanh@nvidia.com \
--cc=kch@nvidia.com \
--cc=kevin.tian@intel.com \
--cc=kvm@vger.kernel.org \
--cc=leoyang.li@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=robin.murphy@arm.com \
--cc=stuyoder@gmail.com \
--cc=thierry.reding@gmail.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.