* [PATCH] ARM: boot: dts: bcm2711: Fix HVS register range
@ 2022-02-19 12:07 ` Stefan Wahren
0 siblings, 0 replies; 4+ messages in thread
From: Stefan Wahren @ 2022-02-19 12:07 UTC (permalink / raw)
To: Rob Herring, Florian Fainelli, Nicolas Saenz Julienne
Cc: Ray Jui, Scott Branden, bcm-kernel-feedback-list, Arnd Bergmann,
Olof Johansson, Phil Elwell, devicetree, soc, linux-arm-kernel,
linux-rpi-kernel, Maxime Ripard, Stefan Wahren
From: Maxime Ripard <maxime@cerno.tech>
While the HVS has the same context memory size in the BCM2711 than in
the previous SoCs, the range allocated to the registers doubled and it
now takes 16k + 16k, compared to 8k + 16k before.
The KMS driver will use the whole context RAM though, eventually
resulting in a pointer dereference error when we access the higher half
of the context memory since it hasn't been mapped.
Fixes: 4564363351e2 ("ARM: dts: bcm2711: Enable the display pipeline")
Signed-off-by: Maxime Ripard <maxime@cerno.tech>
Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
---
arch/arm/boot/dts/bcm2711.dtsi | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/boot/dts/bcm2711.dtsi b/arch/arm/boot/dts/bcm2711.dtsi
index dff18fc..21294f7 100644
--- a/arch/arm/boot/dts/bcm2711.dtsi
+++ b/arch/arm/boot/dts/bcm2711.dtsi
@@ -290,6 +290,7 @@
hvs: hvs@7e400000 {
compatible = "brcm,bcm2711-hvs";
+ reg = <0x7e400000 0x8000>;
interrupts = <GIC_SPI 97 IRQ_TYPE_LEVEL_HIGH>;
};
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH] ARM: boot: dts: bcm2711: Fix HVS register range
@ 2022-02-19 12:07 ` Stefan Wahren
0 siblings, 0 replies; 4+ messages in thread
From: Stefan Wahren @ 2022-02-19 12:07 UTC (permalink / raw)
To: Rob Herring, Florian Fainelli, Nicolas Saenz Julienne
Cc: Ray Jui, Scott Branden, bcm-kernel-feedback-list, Arnd Bergmann,
Olof Johansson, Phil Elwell, devicetree, soc, linux-arm-kernel,
linux-rpi-kernel, Maxime Ripard, Stefan Wahren
From: Maxime Ripard <maxime@cerno.tech>
While the HVS has the same context memory size in the BCM2711 than in
the previous SoCs, the range allocated to the registers doubled and it
now takes 16k + 16k, compared to 8k + 16k before.
The KMS driver will use the whole context RAM though, eventually
resulting in a pointer dereference error when we access the higher half
of the context memory since it hasn't been mapped.
Fixes: 4564363351e2 ("ARM: dts: bcm2711: Enable the display pipeline")
Signed-off-by: Maxime Ripard <maxime@cerno.tech>
Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
---
arch/arm/boot/dts/bcm2711.dtsi | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/boot/dts/bcm2711.dtsi b/arch/arm/boot/dts/bcm2711.dtsi
index dff18fc..21294f7 100644
--- a/arch/arm/boot/dts/bcm2711.dtsi
+++ b/arch/arm/boot/dts/bcm2711.dtsi
@@ -290,6 +290,7 @@
hvs: hvs@7e400000 {
compatible = "brcm,bcm2711-hvs";
+ reg = <0x7e400000 0x8000>;
interrupts = <GIC_SPI 97 IRQ_TYPE_LEVEL_HIGH>;
};
--
2.7.4
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] ARM: boot: dts: bcm2711: Fix HVS register range
2022-02-19 12:07 ` Stefan Wahren
@ 2022-02-23 19:03 ` Florian Fainelli
-1 siblings, 0 replies; 4+ messages in thread
From: Florian Fainelli @ 2022-02-23 19:03 UTC (permalink / raw)
To: bcm-kernel-feedback-list, Stefan Wahren, Rob Herring,
Nicolas Saenz Julienne
Cc: Ray Jui, Scott Branden, Arnd Bergmann, Olof Johansson,
Phil Elwell, devicetree, soc, linux-arm-kernel, linux-rpi-kernel,
Maxime Ripard
On Sat, 19 Feb 2022 13:07:55 +0100, Stefan Wahren <stefan.wahren@i2se.com> wrote:
> From: Maxime Ripard <maxime@cerno.tech>
>
> While the HVS has the same context memory size in the BCM2711 than in
> the previous SoCs, the range allocated to the registers doubled and it
> now takes 16k + 16k, compared to 8k + 16k before.
>
> The KMS driver will use the whole context RAM though, eventually
> resulting in a pointer dereference error when we access the higher half
> of the context memory since it hasn't been mapped.
>
> Fixes: 4564363351e2 ("ARM: dts: bcm2711: Enable the display pipeline")
> Signed-off-by: Maxime Ripard <maxime@cerno.tech>
> Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
> ---
Applied to https://github.com/Broadcom/stblinux/commits/devicetree/fixes, thanks!
--
Florian
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] ARM: boot: dts: bcm2711: Fix HVS register range
@ 2022-02-23 19:03 ` Florian Fainelli
0 siblings, 0 replies; 4+ messages in thread
From: Florian Fainelli @ 2022-02-23 19:03 UTC (permalink / raw)
To: bcm-kernel-feedback-list, Stefan Wahren, Rob Herring,
Nicolas Saenz Julienne
Cc: Ray Jui, Scott Branden, Arnd Bergmann, Olof Johansson,
Phil Elwell, devicetree, soc, linux-arm-kernel, linux-rpi-kernel,
Maxime Ripard
On Sat, 19 Feb 2022 13:07:55 +0100, Stefan Wahren <stefan.wahren@i2se.com> wrote:
> From: Maxime Ripard <maxime@cerno.tech>
>
> While the HVS has the same context memory size in the BCM2711 than in
> the previous SoCs, the range allocated to the registers doubled and it
> now takes 16k + 16k, compared to 8k + 16k before.
>
> The KMS driver will use the whole context RAM though, eventually
> resulting in a pointer dereference error when we access the higher half
> of the context memory since it hasn't been mapped.
>
> Fixes: 4564363351e2 ("ARM: dts: bcm2711: Enable the display pipeline")
> Signed-off-by: Maxime Ripard <maxime@cerno.tech>
> Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
> ---
Applied to https://github.com/Broadcom/stblinux/commits/devicetree/fixes, thanks!
--
Florian
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-02-23 19:05 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-02-19 12:07 [PATCH] ARM: boot: dts: bcm2711: Fix HVS register range Stefan Wahren
2022-02-19 12:07 ` Stefan Wahren
2022-02-23 19:03 ` Florian Fainelli
2022-02-23 19:03 ` Florian Fainelli
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.