* [PATCH] coccinelle: misc: fix minmax.cocci warnings
2022-02-24 6:58 drivers/dma/dmatest.c:1033:23-24: WARNING opportunity for max() kernel test robot
@ 2022-02-24 6:55 ` kernel test robot
0 siblings, 0 replies; 2+ messages in thread
From: kernel test robot @ 2022-02-24 6:55 UTC (permalink / raw)
To: kbuild
[-- Attachment #1: Type: text/plain, Size: 2387 bytes --]
CC: kbuild-all(a)lists.01.org
BCC: lkp(a)intel.com
CC: linux-kernel(a)vger.kernel.org
TO: Denis Efremov <efremov@linux.com>
CC: Julia Lawall <Julia.Lawall@inria.fr>
CC: Vinod Koul <vkoul@kernel.org>
CC: dmaengine(a)vger.kernel.org
CC: linux-kernel(a)vger.kernel.org
From: kernel test robot <lkp@intel.com>
drivers/dma/dmatest.c:1033:23-24: WARNING opportunity for max()
drivers/dma/dmatest.c:1040:23-24: WARNING opportunity for max()
drivers/dma/dmatest.c:1046:22-23: WARNING opportunity for max()
drivers/dma/dmatest.c:1050:22-23: WARNING opportunity for max()
Check for opencoded min(), max() implementations.
Generated patches sometimes require adding a cast to fix compile warning.
Warnings/patches scope intentionally limited to a function body.
Generated by: scripts/coccinelle/misc/minmax.cocci
CC: Denis Efremov <efremov@linux.com>
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 23d04328444a8fa0ca060c5e532220dac8e8bc26
commit: 5f66f73b9ff4dcabd4e2405ba9c32e80e02f9408 coccinelle: misc: add minmax script
:::::: branch date: 11 hours ago
:::::: commit date: 10 months ago
Please take the patch only if it's a positive warning. Thanks!
drivers/dma/dmatest.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
--- a/drivers/dma/dmatest.c
+++ b/drivers/dma/dmatest.c
@@ -1030,24 +1030,24 @@ static int dmatest_add_channel(struct dm
if (dma_has_cap(DMA_MEMCPY, dma_dev->cap_mask)) {
if (dmatest == 0) {
cnt = dmatest_add_threads(info, dtc, DMA_MEMCPY);
- thread_count += cnt > 0 ? cnt : 0;
+ thread_count += max(cnt, 0);
}
}
if (dma_has_cap(DMA_MEMSET, dma_dev->cap_mask)) {
if (dmatest == 1) {
cnt = dmatest_add_threads(info, dtc, DMA_MEMSET);
- thread_count += cnt > 0 ? cnt : 0;
+ thread_count += max(cnt, 0);
}
}
if (dma_has_cap(DMA_XOR, dma_dev->cap_mask)) {
cnt = dmatest_add_threads(info, dtc, DMA_XOR);
- thread_count += cnt > 0 ? cnt : 0;
+ thread_count += max(cnt, 0);
}
if (dma_has_cap(DMA_PQ, dma_dev->cap_mask)) {
cnt = dmatest_add_threads(info, dtc, DMA_PQ);
- thread_count += cnt > 0 ? cnt : 0;
+ thread_count += max(cnt, 0);
}
pr_info("Added %u threads using %s\n",
^ permalink raw reply [flat|nested] 2+ messages in thread