All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Geis <pgwipeout@gmail.com>
To: Felipe Balbi <balbi@kernel.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Bin Yang <yangbin@rock-chips.com>,
	Heiko Stuebner <heiko@sntech.de>,
	Peter Geis <pgwipeout@gmail.com>,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH v1 4/8] usb: dwc3: core: do not use 3.0 clock when operating in 2.0 mode
Date: Fri, 25 Feb 2022 09:54:27 -0500	[thread overview]
Message-ID: <20220225145432.422130-5-pgwipeout@gmail.com> (raw)
In-Reply-To: <20220225145432.422130-1-pgwipeout@gmail.com>

From: Bin Yang <yangbin@rock-chips.com>

In the 3.0 device core, if the core is programmed to operate in
2.0 only, then setting the GUCTL1.DEV_FORCE_20_CLK_FOR_30_CLK makes
the internal 2.0(utmi/ulpi) clock to be routed as the 3.0 (pipe)
clock. Enabling this feature allows the pipe3 clock to be not-running
when forcibly operating in 2.0 device mode.

Signed-off-by: Bin Yang <yangbin@rock-chips.com>
Signed-off-by: Peter Geis <pgwipeout@gmail.com>
---
 drivers/usb/dwc3/core.c | 4 ++++
 drivers/usb/dwc3/core.h | 1 +
 2 files changed, 5 insertions(+)

diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c
index 18adddfba3da..032d40794fae 100644
--- a/drivers/usb/dwc3/core.c
+++ b/drivers/usb/dwc3/core.c
@@ -1167,6 +1167,10 @@ static int dwc3_core_init(struct dwc3 *dwc)
 		if (dwc->parkmode_disable_ss_quirk)
 			reg |= DWC3_GUCTL1_PARKMODE_DISABLE_SS;
 
+		if (dwc->maximum_speed == USB_SPEED_HIGH ||
+		    dwc->maximum_speed == USB_SPEED_FULL)
+			reg |= DWC3_GUCTL1_DEV_FORCE_20_CLK_FOR_30_CLK;
+
 		dwc3_writel(dwc->regs, DWC3_GUCTL1, reg);
 	}
 
diff --git a/drivers/usb/dwc3/core.h b/drivers/usb/dwc3/core.h
index eb9c1efced05..ea3ca04406bb 100644
--- a/drivers/usb/dwc3/core.h
+++ b/drivers/usb/dwc3/core.h
@@ -259,6 +259,7 @@
 /* Global User Control 1 Register */
 #define DWC3_GUCTL1_DEV_DECOUPLE_L1L2_EVT	BIT(31)
 #define DWC3_GUCTL1_TX_IPGAP_LINECHECK_DIS	BIT(28)
+#define DWC3_GUCTL1_DEV_FORCE_20_CLK_FOR_30_CLK	BIT(26)
 #define DWC3_GUCTL1_DEV_L1_EXIT_BY_HW		BIT(24)
 #define DWC3_GUCTL1_PARKMODE_DISABLE_SS		BIT(17)
 
-- 
2.25.1


  parent reply	other threads:[~2022-02-25 14:54 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-25 14:54 [PATCH v1 0/8] enable usb support on rk356x Peter Geis
2022-02-25 14:54 ` Peter Geis
2022-02-25 14:54 ` Peter Geis
2022-02-25 14:54 ` [PATCH v1 1/8] dt-bindings: soc: grf: add rk3566-pipe-grf compatible Peter Geis
2022-02-25 14:54   ` Peter Geis
2022-02-25 14:54   ` Peter Geis
2022-02-25 14:54 ` [PATCH v1 2/8] dt-bindings: usb: dwc3: add description for rk3568 Peter Geis
2022-02-25 14:54   ` Peter Geis
2022-02-25 14:54   ` Peter Geis
2022-02-25 16:07   ` Johan Jonker
2022-02-25 16:07     ` Johan Jonker
2022-02-25 16:07     ` Johan Jonker
2022-02-25 18:04     ` Peter Geis
2022-02-25 18:04       ` Peter Geis
2022-02-25 18:04       ` Peter Geis
2022-02-25 14:54 ` [PATCH v1 3/8] soc: rockchip: set dwc3 clock for rk3566 Peter Geis
2022-02-25 14:54   ` Peter Geis
2022-02-25 14:54   ` Peter Geis
2022-02-25 14:54 ` Peter Geis [this message]
2022-02-25 17:16   ` [PATCH v1 4/8] usb: dwc3: core: do not use 3.0 clock when operating in 2.0 mode Jack Pham
2022-02-25 17:55     ` Peter Geis
2022-02-25 14:54 ` [PATCH v1 5/8] usb: dwc3: reorder dwc-of-simple compatibles Peter Geis
2022-02-25 14:54 ` [PATCH v1 6/8] usb: dwc3: add rk3568 dwc3 support Peter Geis
2022-02-25 17:08   ` Michael Riesch
2022-02-25 17:55     ` Peter Geis
2022-02-25 14:54 ` [PATCH v1 7/8] arm64: dts: rockchip: add rk356x dwc3 usb3 nodes Peter Geis
2022-02-25 14:54   ` Peter Geis
2022-02-25 14:54   ` Peter Geis
2022-02-25 17:01   ` Michael Riesch
2022-02-25 17:01     ` Michael Riesch
2022-02-25 17:01     ` Michael Riesch
2022-02-25 17:59     ` Peter Geis
2022-02-25 17:59       ` Peter Geis
2022-02-25 17:59       ` Peter Geis
2022-02-25 18:25       ` Michael Riesch
2022-02-25 18:25         ` Michael Riesch
2022-02-25 18:25         ` Michael Riesch
2022-02-25 14:54 ` [PATCH v1 8/8] arm64: dts: rockchip: enable dwc3 on quartz64-a Peter Geis
2022-02-25 14:54   ` Peter Geis
2022-02-25 14:54   ` Peter Geis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220225145432.422130-5-pgwipeout@gmail.com \
    --to=pgwipeout@gmail.com \
    --cc=balbi@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=heiko@sntech.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=yangbin@rock-chips.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.