All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Kamel Bouhara via buildroot <buildroot@buildroot.org>
Cc: Kamel Bouhara <kamel.bouhara@bootlin.com>
Subject: Re: [Buildroot] [PATCH 2/4] package/odb: add dependency on host-libodb
Date: Sat, 26 Feb 2022 11:32:18 +0100	[thread overview]
Message-ID: <20220226113218.23e288ed@windsurf> (raw)
In-Reply-To: <20220225113400.802049-3-kamel.bouhara@bootlin.com>

Hello Kamel,

On Fri, 25 Feb 2022 12:33:58 +0100
Kamel Bouhara via buildroot <buildroot@buildroot.org> wrote:

> +# host-libodb is not needed to build host-odb, but it is needed to use
> +# the ODB compiler, as it install header files that are needed at
> +# runtime by the odb compiler.
> +HOST_ODB_DEPENDENCIES = host-libcutl host-libodb

You're in PATCH 2/4, and you're using host-libodb, which is only added
in PATCH 3/4. There is a patch ordering issue in your series.

> +ifeq ($(BR2_PACKAGE_BOOST),y)
> +HOST_ODB_DEPENDENCIES += host-boost host-libodb-boost

You're in PATCH 2/4, and you're using host-libodb-boost, which is only
added in PATCH 4/4, so there's another ordering issue in your series.

Also, the host-boost dependency here seems useless to me, as it's
implied by the host-libodb-boost dependency.

Also, why do you use ifeq ($(BR2_PACKAGE_BOOST),y) ? I think it would
be much more logical to use ifeq ($(BR2_PACKAGE_LIBODB_BOOST),y), no ?

Best regards,

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2022-02-26 10:32 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-25 11:33 [Buildroot] [PATCH 0/4] Add odb host variant and fix gcc-11 build Kamel Bouhara via buildroot
2022-02-25 11:33 ` [Buildroot] [PATCH 1/4] package/odb: backport more upstream commits to fix build with gcc 11.x Kamel Bouhara via buildroot
2022-02-25 11:33 ` [Buildroot] [PATCH 2/4] package/odb: add dependency on host-libodb Kamel Bouhara via buildroot
2022-02-26 10:32   ` Thomas Petazzoni via buildroot [this message]
2022-02-25 11:33 ` [Buildroot] [PATCH 3/4] package/libodb: add host variant Kamel Bouhara via buildroot
2022-02-26 10:32   ` Thomas Petazzoni via buildroot
2022-02-25 11:34 ` [Buildroot] [PATCH 4/4] package/libodb-boost: " Kamel Bouhara via buildroot
2022-02-26 10:35   ` Thomas Petazzoni via buildroot
2022-03-10  8:51     ` Kamel Bouhara via buildroot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220226113218.23e288ed@windsurf \
    --to=buildroot@buildroot.org \
    --cc=kamel.bouhara@bootlin.com \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.