Re: [Buildroot] [PATCH 4/4] package/libodb-boost: add host variant

[Kamel Bouhara via buildroot <buildroot@buildroot.org>]

On Sat, Feb 26, 2022 at 11:35:38AM +0100, Thomas Petazzoni wrote:
> On Fri, 25 Feb 2022 12:34:00 +0100
> Kamel Bouhara via buildroot <buildroot@buildroot.org> wrote:
>
> > Add host variant of libodb-boost required by host-odb package.
>
> This is a bit short, and I think just like PATCH 3/4, it needs a more
> extensive explanation that the ODB compiler needs the libodb-boost
> headers at compile time, and therefore installed in $(HOST_DIR).
>

Ack.

> > diff --git a/package/libodb-boost/libodb-boost.mk b/package/libodb-boost/libodb-boost.mk
> > index bac5f1e78f..7f2ad1fe72 100644
> > --- a/package/libodb-boost/libodb-boost.mk
> > +++ b/package/libodb-boost/libodb-boost.mk
> > @@ -11,7 +11,10 @@ LIBODB_BOOST_SITE = https://www.codesynthesis.com/download/odb/$(LIBODB_BOOST_VE
> >  LIBODB_BOOST_INSTALL_STAGING = YES
> >  LIBODB_BOOST_LICENSE = GPL-2.0
> >  LIBODB_BOOST_LICENSE_FILES = LICENSE
> > -LIBODB_BOOST_DEPENDENCIES = boost libodb
> > +LIBODB_BOOST_DEPENDENCIES = boost libodb \
> > +			    host-boost \
> > +			    host-libodb
>
> This seems wrong. Why is libodb-boost depending on host-libodb-boost.
> At least, this makes the dependencies added in your PATCH 2/4 a bit
> irrelevant.
>

Actually, that is the host variant that is depending on it. Your
following comments are completely right.

Thanks !

> I guess what you need to do instead is:
>
> HOST_LIBODB_BOOST_DEPENDENCIES = hoost-boost host-libodb
>
> And rely on the logic in odb.mk to pull in host-libodb-boost when
> BR2_PACKAGE_LIBODB_BOOST=y.
>

> Could you fix your patch series, and send a new iteration?
>
> Thanks!
>
> Thomas
> --
> Thomas Petazzoni, co-owner and CEO, Bootlin
> Embedded Linux and Kernel engineering and training
> https://bootlin.com

--
Kamel Bouhara, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot