From: Lecopzer Chen <lecopzer.chen@mediatek.com>
To: <linus.walleij@linaro.org>, <linux-kernel@vger.kernel.org>
Cc: <andreyknvl@gmail.com>, <anshuman.khandual@arm.com>,
<ardb@kernel.org>, <arnd@arndb.de>, <dvyukov@google.com>,
<geert+renesas@glider.be>, <glider@google.com>,
<kasan-dev@googlegroups.com>, <lecopzer.chen@mediatek.com>,
<linux-arm-kernel@lists.infradead.org>, <linux@armlinux.org.uk>,
<lukas.bulwahn@gmail.com>, <mark.rutland@arm.com>,
<masahiroy@kernel.org>, <matthias.bgg@gmail.com>,
<rmk+kernel@armlinux.org.uk>, <ryabinin.a.a@gmail.com>,
<yj.chiang@mediatek.com>
Subject: [PATCH v3 1/2] arm: kasan: support CONFIG_KASAN_VMALLOC
Date: Sun, 27 Feb 2022 21:47:25 +0800 [thread overview]
Message-ID: <20220227134726.27584-2-lecopzer.chen@mediatek.com> (raw)
In-Reply-To: <20220227134726.27584-1-lecopzer.chen@mediatek.com>
Simply make shadow of vmalloc area mapped on demand.
Since the virtual address of vmalloc for Arm is also between
MODULE_VADDR and 0x100000000 (ZONE_HIGHMEM), which means the shadow
address has already included between KASAN_SHADOW_START and
KASAN_SHADOW_END.
Thus we need to change nothing for memory map of Arm.
This can fix ARM_MODULE_PLTS with KASan, support KASan for higmem
and provide the first step to support CONFIG_VMAP_STACK with Arm.
Signed-off-by: Lecopzer Chen <lecopzer.chen@mediatek.com>
---
arch/arm/Kconfig | 1 +
arch/arm/include/asm/kasan_def.h | 11 ++++++++++-
arch/arm/mm/kasan_init.c | 6 +++++-
3 files changed, 16 insertions(+), 2 deletions(-)
diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
index 4c97cb40eebb..78250e246cc6 100644
--- a/arch/arm/Kconfig
+++ b/arch/arm/Kconfig
@@ -72,6 +72,7 @@ config ARM
select HAVE_ARCH_KFENCE if MMU && !XIP_KERNEL
select HAVE_ARCH_KGDB if !CPU_ENDIAN_BE32 && MMU
select HAVE_ARCH_KASAN if MMU && !XIP_KERNEL
+ select HAVE_ARCH_KASAN_VMALLOC if HAVE_ARCH_KASAN
select HAVE_ARCH_MMAP_RND_BITS if MMU
select HAVE_ARCH_PFN_VALID
select HAVE_ARCH_SECCOMP
diff --git a/arch/arm/include/asm/kasan_def.h b/arch/arm/include/asm/kasan_def.h
index 5739605aa7cf..96fd1d3b5a0c 100644
--- a/arch/arm/include/asm/kasan_def.h
+++ b/arch/arm/include/asm/kasan_def.h
@@ -19,7 +19,16 @@
* space to use as shadow memory for KASan as follows:
*
* +----+ 0xffffffff
- * | | \
+ * | |\
+ * | | |-> ZONE_HIGHMEM for vmalloc virtual address space.
+ * | | | Such as vmalloc(), GFP_HIGHUSER (__GFP__HIGHMEM),
+ * | | | module address using ARM_MODULE_PLTS, etc.
+ * | | |
+ * | | | If CONFIG_KASAN_VMALLOC=y, this area would populate
+ * | | | shadow address on demand.
+ * | |/
+ * +----+ VMALLOC_START
+ * | |\
* | | |-> Static kernel image (vmlinux) BSS and page table
* | |/
* +----+ PAGE_OFFSET
diff --git a/arch/arm/mm/kasan_init.c b/arch/arm/mm/kasan_init.c
index 5ad0d6c56d56..29caee9c79ce 100644
--- a/arch/arm/mm/kasan_init.c
+++ b/arch/arm/mm/kasan_init.c
@@ -236,7 +236,11 @@ void __init kasan_init(void)
clear_pgds(KASAN_SHADOW_START, KASAN_SHADOW_END);
- kasan_populate_early_shadow(kasan_mem_to_shadow((void *)VMALLOC_START),
+ if (!IS_ENABLED(CONFIG_KASAN_VMALLOC))
+ kasan_populate_early_shadow(kasan_mem_to_shadow((void *)VMALLOC_START),
+ kasan_mem_to_shadow((void *)VMALLOC_END));
+
+ kasan_populate_early_shadow(kasan_mem_to_shadow((void *)VMALLOC_END),
kasan_mem_to_shadow((void *)-1UL) + 1);
for_each_mem_range(i, &pa_start, &pa_end) {
--
2.25.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Lecopzer Chen <lecopzer.chen@mediatek.com>
To: <linus.walleij@linaro.org>, <linux-kernel@vger.kernel.org>
Cc: <andreyknvl@gmail.com>, <anshuman.khandual@arm.com>,
<ardb@kernel.org>, <arnd@arndb.de>, <dvyukov@google.com>,
<geert+renesas@glider.be>, <glider@google.com>,
<kasan-dev@googlegroups.com>, <lecopzer.chen@mediatek.com>,
<linux-arm-kernel@lists.infradead.org>, <linux@armlinux.org.uk>,
<lukas.bulwahn@gmail.com>, <mark.rutland@arm.com>,
<masahiroy@kernel.org>, <matthias.bgg@gmail.com>,
<rmk+kernel@armlinux.org.uk>, <ryabinin.a.a@gmail.com>,
<yj.chiang@mediatek.com>
Subject: [PATCH v3 1/2] arm: kasan: support CONFIG_KASAN_VMALLOC
Date: Sun, 27 Feb 2022 21:47:25 +0800 [thread overview]
Message-ID: <20220227134726.27584-2-lecopzer.chen@mediatek.com> (raw)
In-Reply-To: <20220227134726.27584-1-lecopzer.chen@mediatek.com>
Simply make shadow of vmalloc area mapped on demand.
Since the virtual address of vmalloc for Arm is also between
MODULE_VADDR and 0x100000000 (ZONE_HIGHMEM), which means the shadow
address has already included between KASAN_SHADOW_START and
KASAN_SHADOW_END.
Thus we need to change nothing for memory map of Arm.
This can fix ARM_MODULE_PLTS with KASan, support KASan for higmem
and provide the first step to support CONFIG_VMAP_STACK with Arm.
Signed-off-by: Lecopzer Chen <lecopzer.chen@mediatek.com>
---
arch/arm/Kconfig | 1 +
arch/arm/include/asm/kasan_def.h | 11 ++++++++++-
arch/arm/mm/kasan_init.c | 6 +++++-
3 files changed, 16 insertions(+), 2 deletions(-)
diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
index 4c97cb40eebb..78250e246cc6 100644
--- a/arch/arm/Kconfig
+++ b/arch/arm/Kconfig
@@ -72,6 +72,7 @@ config ARM
select HAVE_ARCH_KFENCE if MMU && !XIP_KERNEL
select HAVE_ARCH_KGDB if !CPU_ENDIAN_BE32 && MMU
select HAVE_ARCH_KASAN if MMU && !XIP_KERNEL
+ select HAVE_ARCH_KASAN_VMALLOC if HAVE_ARCH_KASAN
select HAVE_ARCH_MMAP_RND_BITS if MMU
select HAVE_ARCH_PFN_VALID
select HAVE_ARCH_SECCOMP
diff --git a/arch/arm/include/asm/kasan_def.h b/arch/arm/include/asm/kasan_def.h
index 5739605aa7cf..96fd1d3b5a0c 100644
--- a/arch/arm/include/asm/kasan_def.h
+++ b/arch/arm/include/asm/kasan_def.h
@@ -19,7 +19,16 @@
* space to use as shadow memory for KASan as follows:
*
* +----+ 0xffffffff
- * | | \
+ * | |\
+ * | | |-> ZONE_HIGHMEM for vmalloc virtual address space.
+ * | | | Such as vmalloc(), GFP_HIGHUSER (__GFP__HIGHMEM),
+ * | | | module address using ARM_MODULE_PLTS, etc.
+ * | | |
+ * | | | If CONFIG_KASAN_VMALLOC=y, this area would populate
+ * | | | shadow address on demand.
+ * | |/
+ * +----+ VMALLOC_START
+ * | |\
* | | |-> Static kernel image (vmlinux) BSS and page table
* | |/
* +----+ PAGE_OFFSET
diff --git a/arch/arm/mm/kasan_init.c b/arch/arm/mm/kasan_init.c
index 5ad0d6c56d56..29caee9c79ce 100644
--- a/arch/arm/mm/kasan_init.c
+++ b/arch/arm/mm/kasan_init.c
@@ -236,7 +236,11 @@ void __init kasan_init(void)
clear_pgds(KASAN_SHADOW_START, KASAN_SHADOW_END);
- kasan_populate_early_shadow(kasan_mem_to_shadow((void *)VMALLOC_START),
+ if (!IS_ENABLED(CONFIG_KASAN_VMALLOC))
+ kasan_populate_early_shadow(kasan_mem_to_shadow((void *)VMALLOC_START),
+ kasan_mem_to_shadow((void *)VMALLOC_END));
+
+ kasan_populate_early_shadow(kasan_mem_to_shadow((void *)VMALLOC_END),
kasan_mem_to_shadow((void *)-1UL) + 1);
for_each_mem_range(i, &pa_start, &pa_end) {
--
2.25.1
next prev parent reply other threads:[~2022-02-27 13:49 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-27 13:47 [PATCH v3 0/2] arm: kasan: support CONFIG_KASAN_VMALLOC Lecopzer Chen
2022-02-27 13:47 ` Lecopzer Chen
2022-02-27 13:47 ` Lecopzer Chen [this message]
2022-02-27 13:47 ` [PATCH v3 1/2] " Lecopzer Chen
2022-03-11 10:34 ` Russell King (Oracle)
2022-03-11 10:34 ` Russell King (Oracle)
2022-03-11 10:47 ` Lecopzer Chen
2022-03-11 10:47 ` Lecopzer Chen
2022-02-27 13:47 ` [PATCH v3 2/2] arm: kconfig: fix MODULE_PLTS for KASAN with KASAN_VMALLOC Lecopzer Chen
2022-02-27 13:47 ` Lecopzer Chen
2022-03-10 23:08 ` [PATCH v3 0/2] arm: kasan: support CONFIG_KASAN_VMALLOC Linus Walleij
2022-03-10 23:08 ` Linus Walleij
2022-03-11 10:37 ` Russell King (Oracle)
2022-03-11 10:37 ` Russell King (Oracle)
2022-03-11 10:52 ` Lecopzer Chen
2022-03-11 10:52 ` Lecopzer Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220227134726.27584-2-lecopzer.chen@mediatek.com \
--to=lecopzer.chen@mediatek.com \
--cc=andreyknvl@gmail.com \
--cc=anshuman.khandual@arm.com \
--cc=ardb@kernel.org \
--cc=arnd@arndb.de \
--cc=dvyukov@google.com \
--cc=geert+renesas@glider.be \
--cc=glider@google.com \
--cc=kasan-dev@googlegroups.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=lukas.bulwahn@gmail.com \
--cc=mark.rutland@arm.com \
--cc=masahiroy@kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=rmk+kernel@armlinux.org.uk \
--cc=ryabinin.a.a@gmail.com \
--cc=yj.chiang@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.