From: Dan Carpenter <dan.carpenter@oracle.com>
To: Yu Tu <yu.tu@amlogic.com>
Cc: linux-serial@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jirislaby@kernel.org>,
Neil Armstrong <narmstrong@baylibre.com>,
Kevin Hilman <khilman@baylibre.com>,
Jerome Brunet <jbrunet@baylibre.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
kernel test robot <lkp@intel.com>
Subject: Re: [PATCH V3] tty: serial: meson: Fix the compile link error reported by kernel test robot
Date: Mon, 28 Feb 2022 17:27:52 +0300 [thread overview]
Message-ID: <20220228142751.GF2812@kadam> (raw)
In-Reply-To: <20220228135530.6918-1-yu.tu@amlogic.com>
On Mon, Feb 28, 2022 at 09:55:30PM +0800, Yu Tu wrote:
> Describes the calculation of the UART baud rate clock using a clock
> frame. Forgot to add in Kconfig kernel test Robot compilation error
> due to COMMON_CLK dependency.
>
> Fixes: ("tty: serial:meson: Describes the calculation of the UART baud rate clock using a clock frame“)
> Reported-by: kernel test robot <lkp@intel.com>
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> Signed-off-by: Yu Tu <yu.tu@amlogic.com>
> ---
> drivers/tty/serial/Kconfig | 1 +
> drivers/tty/serial/meson_uart.c | 37 +++++++++++++++++++++++----------
> 2 files changed, 27 insertions(+), 11 deletions(-)
>
> diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig
> index e952ec5c7a7c..a0f2b82fc18b 100644
> --- a/drivers/tty/serial/Kconfig
> +++ b/drivers/tty/serial/Kconfig
> @@ -200,6 +200,7 @@ config SERIAL_KGDB_NMI
> config SERIAL_MESON
> tristate "Meson serial port support"
> depends on ARCH_MESON || COMPILE_TEST
> + depends on COMMON_CLK
> select SERIAL_CORE
> help
> This enables the driver for the on-chip UARTs of the Amlogic
This is a link issue. The rest is an unrelated error handling fix.
It should really be sent as two patches.
regards,
dan carpenter
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Yu Tu <yu.tu@amlogic.com>
Cc: linux-serial@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jirislaby@kernel.org>,
Neil Armstrong <narmstrong@baylibre.com>,
Kevin Hilman <khilman@baylibre.com>,
Jerome Brunet <jbrunet@baylibre.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
kernel test robot <lkp@intel.com>
Subject: Re: [PATCH V3] tty: serial: meson: Fix the compile link error reported by kernel test robot
Date: Mon, 28 Feb 2022 17:27:52 +0300 [thread overview]
Message-ID: <20220228142751.GF2812@kadam> (raw)
In-Reply-To: <20220228135530.6918-1-yu.tu@amlogic.com>
On Mon, Feb 28, 2022 at 09:55:30PM +0800, Yu Tu wrote:
> Describes the calculation of the UART baud rate clock using a clock
> frame. Forgot to add in Kconfig kernel test Robot compilation error
> due to COMMON_CLK dependency.
>
> Fixes: ("tty: serial:meson: Describes the calculation of the UART baud rate clock using a clock frame“)
> Reported-by: kernel test robot <lkp@intel.com>
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> Signed-off-by: Yu Tu <yu.tu@amlogic.com>
> ---
> drivers/tty/serial/Kconfig | 1 +
> drivers/tty/serial/meson_uart.c | 37 +++++++++++++++++++++++----------
> 2 files changed, 27 insertions(+), 11 deletions(-)
>
> diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig
> index e952ec5c7a7c..a0f2b82fc18b 100644
> --- a/drivers/tty/serial/Kconfig
> +++ b/drivers/tty/serial/Kconfig
> @@ -200,6 +200,7 @@ config SERIAL_KGDB_NMI
> config SERIAL_MESON
> tristate "Meson serial port support"
> depends on ARCH_MESON || COMPILE_TEST
> + depends on COMMON_CLK
> select SERIAL_CORE
> help
> This enables the driver for the on-chip UARTs of the Amlogic
This is a link issue. The rest is an unrelated error handling fix.
It should really be sent as two patches.
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Yu Tu <yu.tu@amlogic.com>
Cc: linux-serial@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jirislaby@kernel.org>,
Neil Armstrong <narmstrong@baylibre.com>,
Kevin Hilman <khilman@baylibre.com>,
Jerome Brunet <jbrunet@baylibre.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
kernel test robot <lkp@intel.com>
Subject: Re: [PATCH V3] tty: serial: meson: Fix the compile link error reported by kernel test robot
Date: Mon, 28 Feb 2022 17:27:52 +0300 [thread overview]
Message-ID: <20220228142751.GF2812@kadam> (raw)
In-Reply-To: <20220228135530.6918-1-yu.tu@amlogic.com>
On Mon, Feb 28, 2022 at 09:55:30PM +0800, Yu Tu wrote:
> Describes the calculation of the UART baud rate clock using a clock
> frame. Forgot to add in Kconfig kernel test Robot compilation error
> due to COMMON_CLK dependency.
>
> Fixes: ("tty: serial:meson: Describes the calculation of the UART baud rate clock using a clock frame“)
> Reported-by: kernel test robot <lkp@intel.com>
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> Signed-off-by: Yu Tu <yu.tu@amlogic.com>
> ---
> drivers/tty/serial/Kconfig | 1 +
> drivers/tty/serial/meson_uart.c | 37 +++++++++++++++++++++++----------
> 2 files changed, 27 insertions(+), 11 deletions(-)
>
> diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig
> index e952ec5c7a7c..a0f2b82fc18b 100644
> --- a/drivers/tty/serial/Kconfig
> +++ b/drivers/tty/serial/Kconfig
> @@ -200,6 +200,7 @@ config SERIAL_KGDB_NMI
> config SERIAL_MESON
> tristate "Meson serial port support"
> depends on ARCH_MESON || COMPILE_TEST
> + depends on COMMON_CLK
> select SERIAL_CORE
> help
> This enables the driver for the on-chip UARTs of the Amlogic
This is a link issue. The rest is an unrelated error handling fix.
It should really be sent as two patches.
regards,
dan carpenter
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-02-28 14:37 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-28 13:55 [PATCH V3] tty: serial: meson: Fix the compile link error reported by kernel test robot Yu Tu
2022-02-28 13:55 ` Yu Tu
2022-02-28 13:55 ` Yu Tu
2022-02-28 14:13 ` Neil Armstrong
2022-02-28 14:13 ` Neil Armstrong
2022-02-28 14:13 ` Neil Armstrong
2022-02-28 14:36 ` Yu Tu
2022-02-28 14:36 ` Yu Tu
2022-02-28 14:36 ` Yu Tu
2022-02-28 21:21 ` Greg Kroah-Hartman
2022-02-28 21:21 ` Greg Kroah-Hartman
2022-02-28 21:21 ` Greg Kroah-Hartman
2022-03-01 7:23 ` Neil Armstrong
2022-03-01 7:23 ` Neil Armstrong
2022-03-01 7:23 ` Neil Armstrong
2022-03-01 7:47 ` Yu Tu
2022-03-01 7:47 ` Yu Tu
2022-03-01 7:47 ` Yu Tu
2022-03-01 8:33 ` Jerome Brunet
2022-03-01 8:33 ` Jerome Brunet
2022-03-01 8:33 ` Jerome Brunet
2022-03-01 21:06 ` Greg Kroah-Hartman
2022-03-01 21:06 ` Greg Kroah-Hartman
2022-03-01 21:06 ` Greg Kroah-Hartman
2022-03-03 8:09 ` Neil Armstrong
2022-03-03 8:09 ` Neil Armstrong
2022-03-03 8:09 ` Neil Armstrong
2022-02-28 14:27 ` Dan Carpenter [this message]
2022-02-28 14:27 ` Dan Carpenter
2022-02-28 14:27 ` Dan Carpenter
2022-02-28 21:23 ` Greg Kroah-Hartman
2022-02-28 21:23 ` Greg Kroah-Hartman
2022-02-28 21:23 ` Greg Kroah-Hartman
2022-03-01 2:43 ` Yu Tu
2022-03-01 2:43 ` Yu Tu
2022-03-01 2:43 ` Yu Tu
-- strict thread matches above, loose matches on Subject: below --
2022-03-01 5:33 Yu Tu
2022-03-01 5:33 ` Yu Tu
2022-03-01 5:33 ` Yu Tu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220228142751.GF2812@kadam \
--to=dan.carpenter@oracle.com \
--cc=gregkh@linuxfoundation.org \
--cc=jbrunet@baylibre.com \
--cc=jirislaby@kernel.org \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=lkp@intel.com \
--cc=martin.blumenstingl@googlemail.com \
--cc=narmstrong@baylibre.com \
--cc=yu.tu@amlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.