All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mathieu Poirier <mathieu.poirier@linaro.org>
To: Anshuman Khandual <anshuman.khandual@arm.com>
Cc: linux-arm-kernel@lists.infradead.org,
	Suzuki K Poulose <suzuki.poulose@arm.com>,
	Mike Leach <mike.leach@linaro.org>, Leo Yan <leo.yan@linaro.org>,
	coresight@lists.linaro.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] coresight: Drop unused 'none' enum value for each component
Date: Mon, 28 Feb 2022 09:54:06 -0700	[thread overview]
Message-ID: <20220228165406.GA1278407@p14s> (raw)
In-Reply-To: <1645005118-10561-1-git-send-email-anshuman.khandual@arm.com>

Good morning,

On Wed, Feb 16, 2022 at 03:21:58PM +0530, Anshuman Khandual wrote:
> CORESIGHT_DEV_TYPE_NONE/CORESIGHT_DEV_SUBTYPE_XXXX_NONE values are not used
> any where. Actual enumeration can start from 0. Just drop these unused enum
> values.
> 
> Cc: Mathieu Poirier <mathieu.poirier@linaro.org>
> Cc: Suzuki K Poulose <suzuki.poulose@arm.com>
> Cc: Mike Leach <mike.leach@linaro.org>
> Cc: Leo Yan <leo.yan@linaro.org>
> Cc: coresight@lists.linaro.org
> Cc: linux-arm-kernel@lists.infradead.org
> Cc: linux-kernel@vger.kernel.org
> Signed-off-by: Anshuman Khandual <anshuman.khandual@arm.com>
> ---
>  drivers/hwtracing/coresight/coresight-core.c | 3 ---
>  include/linux/coresight.h                    | 5 -----
>  2 files changed, 8 deletions(-)
> 
> diff --git a/drivers/hwtracing/coresight/coresight-core.c b/drivers/hwtracing/coresight/coresight-core.c
> index 88653d1c06a4..af00dca8d1ac 100644
> --- a/drivers/hwtracing/coresight/coresight-core.c
> +++ b/drivers/hwtracing/coresight/coresight-core.c
> @@ -1278,9 +1278,6 @@ static struct attribute *coresight_source_attrs[] = {
>  ATTRIBUTE_GROUPS(coresight_source);
>  
>  static struct device_type coresight_dev_type[] = {
> -	{
> -		.name = "none",
> -	},
>  	{
>  		.name = "sink",
>  		.groups = coresight_sink_groups,
> diff --git a/include/linux/coresight.h b/include/linux/coresight.h
> index 93a2922b7653..9f445f09fcfe 100644
> --- a/include/linux/coresight.h
> +++ b/include/linux/coresight.h
> @@ -36,7 +36,6 @@
>  extern struct bus_type coresight_bustype;
>  
>  enum coresight_dev_type {
> -	CORESIGHT_DEV_TYPE_NONE,
>  	CORESIGHT_DEV_TYPE_SINK,
>  	CORESIGHT_DEV_TYPE_LINK,
>  	CORESIGHT_DEV_TYPE_LINKSINK,
> @@ -46,7 +45,6 @@ enum coresight_dev_type {
>  };
>  
>  enum coresight_dev_subtype_sink {
> -	CORESIGHT_DEV_SUBTYPE_SINK_NONE,
>  	CORESIGHT_DEV_SUBTYPE_SINK_PORT,
>  	CORESIGHT_DEV_SUBTYPE_SINK_BUFFER,
>  	CORESIGHT_DEV_SUBTYPE_SINK_SYSMEM,
> @@ -54,21 +52,18 @@ enum coresight_dev_subtype_sink {
>  };
>  
>  enum coresight_dev_subtype_link {
> -	CORESIGHT_DEV_SUBTYPE_LINK_NONE,
>  	CORESIGHT_DEV_SUBTYPE_LINK_MERG,
>  	CORESIGHT_DEV_SUBTYPE_LINK_SPLIT,
>  	CORESIGHT_DEV_SUBTYPE_LINK_FIFO,
>  };
>  
>  enum coresight_dev_subtype_source {
> -	CORESIGHT_DEV_SUBTYPE_SOURCE_NONE,
>  	CORESIGHT_DEV_SUBTYPE_SOURCE_PROC,
>  	CORESIGHT_DEV_SUBTYPE_SOURCE_BUS,
>  	CORESIGHT_DEV_SUBTYPE_SOURCE_SOFTWARE,
>  };
>  
>  enum coresight_dev_subtype_helper {
> -	CORESIGHT_DEV_SUBTYPE_HELPER_NONE,
>  	CORESIGHT_DEV_SUBTYPE_HELPER_CATU,
>  };

These have never been used in the 7 years the subsystem has existed and I don't
see in what kind of situation they could be...

I have applied this patch.

Thanks,
Mathieu

>  
> -- 
> 2.20.1
> 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Mathieu Poirier <mathieu.poirier@linaro.org>
To: Anshuman Khandual <anshuman.khandual@arm.com>
Cc: linux-arm-kernel@lists.infradead.org,
	Suzuki K Poulose <suzuki.poulose@arm.com>,
	Mike Leach <mike.leach@linaro.org>, Leo Yan <leo.yan@linaro.org>,
	coresight@lists.linaro.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] coresight: Drop unused 'none' enum value for each component
Date: Mon, 28 Feb 2022 09:54:06 -0700	[thread overview]
Message-ID: <20220228165406.GA1278407@p14s> (raw)
In-Reply-To: <1645005118-10561-1-git-send-email-anshuman.khandual@arm.com>

Good morning,

On Wed, Feb 16, 2022 at 03:21:58PM +0530, Anshuman Khandual wrote:
> CORESIGHT_DEV_TYPE_NONE/CORESIGHT_DEV_SUBTYPE_XXXX_NONE values are not used
> any where. Actual enumeration can start from 0. Just drop these unused enum
> values.
> 
> Cc: Mathieu Poirier <mathieu.poirier@linaro.org>
> Cc: Suzuki K Poulose <suzuki.poulose@arm.com>
> Cc: Mike Leach <mike.leach@linaro.org>
> Cc: Leo Yan <leo.yan@linaro.org>
> Cc: coresight@lists.linaro.org
> Cc: linux-arm-kernel@lists.infradead.org
> Cc: linux-kernel@vger.kernel.org
> Signed-off-by: Anshuman Khandual <anshuman.khandual@arm.com>
> ---
>  drivers/hwtracing/coresight/coresight-core.c | 3 ---
>  include/linux/coresight.h                    | 5 -----
>  2 files changed, 8 deletions(-)
> 
> diff --git a/drivers/hwtracing/coresight/coresight-core.c b/drivers/hwtracing/coresight/coresight-core.c
> index 88653d1c06a4..af00dca8d1ac 100644
> --- a/drivers/hwtracing/coresight/coresight-core.c
> +++ b/drivers/hwtracing/coresight/coresight-core.c
> @@ -1278,9 +1278,6 @@ static struct attribute *coresight_source_attrs[] = {
>  ATTRIBUTE_GROUPS(coresight_source);
>  
>  static struct device_type coresight_dev_type[] = {
> -	{
> -		.name = "none",
> -	},
>  	{
>  		.name = "sink",
>  		.groups = coresight_sink_groups,
> diff --git a/include/linux/coresight.h b/include/linux/coresight.h
> index 93a2922b7653..9f445f09fcfe 100644
> --- a/include/linux/coresight.h
> +++ b/include/linux/coresight.h
> @@ -36,7 +36,6 @@
>  extern struct bus_type coresight_bustype;
>  
>  enum coresight_dev_type {
> -	CORESIGHT_DEV_TYPE_NONE,
>  	CORESIGHT_DEV_TYPE_SINK,
>  	CORESIGHT_DEV_TYPE_LINK,
>  	CORESIGHT_DEV_TYPE_LINKSINK,
> @@ -46,7 +45,6 @@ enum coresight_dev_type {
>  };
>  
>  enum coresight_dev_subtype_sink {
> -	CORESIGHT_DEV_SUBTYPE_SINK_NONE,
>  	CORESIGHT_DEV_SUBTYPE_SINK_PORT,
>  	CORESIGHT_DEV_SUBTYPE_SINK_BUFFER,
>  	CORESIGHT_DEV_SUBTYPE_SINK_SYSMEM,
> @@ -54,21 +52,18 @@ enum coresight_dev_subtype_sink {
>  };
>  
>  enum coresight_dev_subtype_link {
> -	CORESIGHT_DEV_SUBTYPE_LINK_NONE,
>  	CORESIGHT_DEV_SUBTYPE_LINK_MERG,
>  	CORESIGHT_DEV_SUBTYPE_LINK_SPLIT,
>  	CORESIGHT_DEV_SUBTYPE_LINK_FIFO,
>  };
>  
>  enum coresight_dev_subtype_source {
> -	CORESIGHT_DEV_SUBTYPE_SOURCE_NONE,
>  	CORESIGHT_DEV_SUBTYPE_SOURCE_PROC,
>  	CORESIGHT_DEV_SUBTYPE_SOURCE_BUS,
>  	CORESIGHT_DEV_SUBTYPE_SOURCE_SOFTWARE,
>  };
>  
>  enum coresight_dev_subtype_helper {
> -	CORESIGHT_DEV_SUBTYPE_HELPER_NONE,
>  	CORESIGHT_DEV_SUBTYPE_HELPER_CATU,
>  };

These have never been used in the 7 years the subsystem has existed and I don't
see in what kind of situation they could be...

I have applied this patch.

Thanks,
Mathieu

>  
> -- 
> 2.20.1
> 

  reply	other threads:[~2022-02-28 16:55 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-16  9:51 [PATCH] coresight: Drop unused 'none' enum value for each component Anshuman Khandual
2022-02-16  9:51 ` Anshuman Khandual
2022-02-28 16:54 ` Mathieu Poirier [this message]
2022-02-28 16:54   ` Mathieu Poirier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220228165406.GA1278407@p14s \
    --to=mathieu.poirier@linaro.org \
    --cc=anshuman.khandual@arm.com \
    --cc=coresight@lists.linaro.org \
    --cc=leo.yan@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mike.leach@linaro.org \
    --cc=suzuki.poulose@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.