All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lukas Wunner <lukas@wunner.de>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
	"open list:RADEON and AMDGPU DRM DRIVERS"
	<amd-gfx@lists.freedesktop.org>,
	Michael Jamet <michael.jamet@intel.com>,
	"open list:PCI SUBSYSTEM" <linux-pci@vger.kernel.org>,
	"open list:THUNDERBOLT DRIVER" <linux-usb@vger.kernel.org>,
	"open list:DRM DRIVERS" <dri-devel@lists.freedesktop.org>,
	"open list:X86 PLATFORM DRIVERS"
	<platform-driver-x86@vger.kernel.org>,
	Andreas Noever <andreas.noever@gmail.com>,
	"Limonciello, Mario" <Mario.Limonciello@amd.com>,
	"open list:DRM DRIVER FOR NVIDIA GEFORCE/QUADRO GPUS"
	<nouveau@lists.freedesktop.org>,
	Yehezkel Bernat <YehezkelShB@gmail.com>,
	"Deucher, Alexander" <Alexander.Deucher@amd.com>,
	Mika Westerberg <mika.westerberg@linux.intel.com>
Subject: Re: [PATCH v5 3/7] PCI: Drop the `is_thunderbolt` attribute from PCI core
Date: Mon, 28 Feb 2022 23:32:46 +0100	[thread overview]
Message-ID: <20220228223246.GA11428@wunner.de> (raw)
In-Reply-To: <20220228221344.GA529289@bhelgaas>

On Mon, Feb 28, 2022 at 04:13:44PM -0600, Bjorn Helgaas wrote:
> On Mon, Feb 28, 2022 at 03:33:13PM +0000, Limonciello, Mario wrote:
> > > On Fri, Feb 25, 2022 at 11:42:24AM -0600, Bjorn Helgaas wrote:
> > > > That would just leave the "PCI_VSEC_ID_INTEL_TBT implies external-
> > > facing"
> > > > assumption above.  Not having a Thunderbolt spec, I have no idea how
> > > > you deal with that.
> > > 
> > > You can download the spec here:
[...]
> > > Inside the archive there is also the DVSEC spec with name "USB4 DVSEC
> > > Version 1.0.pdf".
> > 
> > The spec has Host_Router_indication (bits 18-19) as meaning external facing.
> > I'll respin the patch 3 for using that.
> 
> Thanks, please include the spec citation when you do.  And probably
> the URL, because it's not at all obvious how the casual reader would
> get from "is_thunderbolt" to a recent add-on to the USB4 spec.

PCI_VSEC_ID_INTEL_TBT is not mentioned at all in the USB4 spec,
hence there's no connection between "is_thunderbolt" and the USB4 spec.

It's a proprietary VSEC used by Intel and the only way to recognize
pre-USB4 Thunderbolt devices that I know of.  Its ID is also
different from the DVSEC IDs given in the above-mentioned spec.

Thanks,

Lukas

WARNING: multiple messages have this Message-ID (diff)
From: Lukas Wunner <lukas@wunner.de>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: "Limonciello, Mario" <Mario.Limonciello@amd.com>,
	Mika Westerberg <mika.westerberg@linux.intel.com>,
	Michael Jamet <michael.jamet@intel.com>,
	"open list:PCI SUBSYSTEM" <linux-pci@vger.kernel.org>,
	"open list:THUNDERBOLT DRIVER" <linux-usb@vger.kernel.org>,
	Yehezkel Bernat <YehezkelShB@gmail.com>,
	"open list:DRM DRIVERS" <dri-devel@lists.freedesktop.org>,
	"open list:X86 PLATFORM DRIVERS" 
	<platform-driver-x86@vger.kernel.org>,
	Andreas Noever <andreas.noever@gmail.com>,
	"open list:RADEON and AMDGPU DRM DRIVERS" 
	<amd-gfx@lists.freedesktop.org>,
	"open list:DRM DRIVER FOR NVIDIA GEFORCE/QUADRO GPUS" 
	<nouveau@lists.freedesktop.org>,
	Bjorn Helgaas <bhelgaas@google.com>,
	"Deucher, Alexander" <Alexander.Deucher@amd.com>
Subject: Re: [PATCH v5 3/7] PCI: Drop the `is_thunderbolt` attribute from PCI core
Date: Mon, 28 Feb 2022 23:32:46 +0100	[thread overview]
Message-ID: <20220228223246.GA11428@wunner.de> (raw)
In-Reply-To: <20220228221344.GA529289@bhelgaas>

On Mon, Feb 28, 2022 at 04:13:44PM -0600, Bjorn Helgaas wrote:
> On Mon, Feb 28, 2022 at 03:33:13PM +0000, Limonciello, Mario wrote:
> > > On Fri, Feb 25, 2022 at 11:42:24AM -0600, Bjorn Helgaas wrote:
> > > > That would just leave the "PCI_VSEC_ID_INTEL_TBT implies external-
> > > facing"
> > > > assumption above.  Not having a Thunderbolt spec, I have no idea how
> > > > you deal with that.
> > > 
> > > You can download the spec here:
[...]
> > > Inside the archive there is also the DVSEC spec with name "USB4 DVSEC
> > > Version 1.0.pdf".
> > 
> > The spec has Host_Router_indication (bits 18-19) as meaning external facing.
> > I'll respin the patch 3 for using that.
> 
> Thanks, please include the spec citation when you do.  And probably
> the URL, because it's not at all obvious how the casual reader would
> get from "is_thunderbolt" to a recent add-on to the USB4 spec.

PCI_VSEC_ID_INTEL_TBT is not mentioned at all in the USB4 spec,
hence there's no connection between "is_thunderbolt" and the USB4 spec.

It's a proprietary VSEC used by Intel and the only way to recognize
pre-USB4 Thunderbolt devices that I know of.  Its ID is also
different from the DVSEC IDs given in the above-mentioned spec.

Thanks,

Lukas

WARNING: multiple messages have this Message-ID (diff)
From: Lukas Wunner <lukas@wunner.de>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
	"open list:RADEON and AMDGPU DRM DRIVERS"
	<amd-gfx@lists.freedesktop.org>,
	Michael Jamet <michael.jamet@intel.com>,
	"open list:PCI SUBSYSTEM" <linux-pci@vger.kernel.org>,
	"open list:THUNDERBOLT DRIVER" <linux-usb@vger.kernel.org>,
	"open list:DRM DRIVERS" <dri-devel@lists.freedesktop.org>,
	"open list:X86 PLATFORM DRIVERS"
	<platform-driver-x86@vger.kernel.org>,
	Andreas Noever <andreas.noever@gmail.com>,
	"Limonciello, Mario" <Mario.Limonciello@amd.com>,
	"open list:DRM DRIVER FOR NVIDIA GEFORCE/QUADRO GPUS"
	<nouveau@lists.freedesktop.org>,
	Yehezkel Bernat <YehezkelShB@gmail.com>,
	"Deucher, Alexander" <Alexander.Deucher@amd.com>,
	Mika Westerberg <mika.westerberg@linux.intel.com>
Subject: Re: [Nouveau] [PATCH v5 3/7] PCI: Drop the `is_thunderbolt` attribute from PCI core
Date: Mon, 28 Feb 2022 23:32:46 +0100	[thread overview]
Message-ID: <20220228223246.GA11428@wunner.de> (raw)
In-Reply-To: <20220228221344.GA529289@bhelgaas>

On Mon, Feb 28, 2022 at 04:13:44PM -0600, Bjorn Helgaas wrote:
> On Mon, Feb 28, 2022 at 03:33:13PM +0000, Limonciello, Mario wrote:
> > > On Fri, Feb 25, 2022 at 11:42:24AM -0600, Bjorn Helgaas wrote:
> > > > That would just leave the "PCI_VSEC_ID_INTEL_TBT implies external-
> > > facing"
> > > > assumption above.  Not having a Thunderbolt spec, I have no idea how
> > > > you deal with that.
> > > 
> > > You can download the spec here:
[...]
> > > Inside the archive there is also the DVSEC spec with name "USB4 DVSEC
> > > Version 1.0.pdf".
> > 
> > The spec has Host_Router_indication (bits 18-19) as meaning external facing.
> > I'll respin the patch 3 for using that.
> 
> Thanks, please include the spec citation when you do.  And probably
> the URL, because it's not at all obvious how the casual reader would
> get from "is_thunderbolt" to a recent add-on to the USB4 spec.

PCI_VSEC_ID_INTEL_TBT is not mentioned at all in the USB4 spec,
hence there's no connection between "is_thunderbolt" and the USB4 spec.

It's a proprietary VSEC used by Intel and the only way to recognize
pre-USB4 Thunderbolt devices that I know of.  Its ID is also
different from the DVSEC IDs given in the above-mentioned spec.

Thanks,

Lukas

  reply	other threads:[~2022-02-28 22:32 UTC|newest]

Thread overview: 70+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-24 21:51 [PATCH v5 0/7] Overhaul `is_thunderbolt` Mario Limonciello
2022-02-24 21:51 ` Mario Limonciello
2022-02-24 21:51 ` [Nouveau] " Mario Limonciello
2022-02-24 21:51 ` Mario Limonciello
2022-02-24 21:51 ` [PATCH v5 1/7] PCI: Move `is_thunderbolt` check for lack of command completed to a quirk Mario Limonciello
2022-02-24 21:51   ` Mario Limonciello
2022-02-24 21:51   ` [Nouveau] " Mario Limonciello
2022-02-24 21:51   ` Mario Limonciello
2022-02-24 21:51 ` [PATCH v5 2/7] PCI: Move check for old Apple Thunderbolt controllers into " Mario Limonciello
2022-02-24 21:51   ` Mario Limonciello
2022-02-24 21:51   ` [Nouveau] " Mario Limonciello
2022-02-24 21:51   ` Mario Limonciello
2022-02-24 21:51 ` [PATCH v5 3/7] PCI: Drop the `is_thunderbolt` attribute from PCI core Mario Limonciello
2022-02-24 21:51   ` Mario Limonciello
2022-02-24 21:51   ` [Nouveau] " Mario Limonciello
2022-02-24 21:51   ` Mario Limonciello
2022-02-25  1:23   ` Bjorn Helgaas
2022-02-25  1:23     ` Bjorn Helgaas
2022-02-25  1:23     ` [Nouveau] " Bjorn Helgaas
2022-02-25  1:23     ` Bjorn Helgaas
2022-02-25  1:27     ` Bjorn Helgaas
2022-02-25  1:27       ` Bjorn Helgaas
2022-02-25  1:27       ` [Nouveau] " Bjorn Helgaas
2022-02-25  1:27       ` Bjorn Helgaas
2022-02-25 16:13     ` Alex Deucher
2022-02-25 16:13       ` Alex Deucher
2022-02-25 16:13       ` [Nouveau] " Alex Deucher
2022-02-25 16:13       ` Alex Deucher
2022-02-25 17:42   ` Bjorn Helgaas
2022-02-25 17:42     ` Bjorn Helgaas
2022-02-25 17:42     ` [Nouveau] " Bjorn Helgaas
2022-02-25 17:42     ` Bjorn Helgaas
2022-02-28 10:16     ` Mika Westerberg
2022-02-28 10:16       ` Mika Westerberg
2022-02-28 10:16       ` [Nouveau] " Mika Westerberg
2022-02-28 10:16       ` Mika Westerberg
2022-02-28 15:33       ` Limonciello, Mario
2022-02-28 15:33         ` Limonciello, Mario
2022-02-28 15:33         ` [Nouveau] " Limonciello, Mario
2022-02-28 15:33         ` Limonciello, Mario
2022-02-28 22:13         ` Bjorn Helgaas
2022-02-28 22:13           ` Bjorn Helgaas
2022-02-28 22:13           ` [Nouveau] " Bjorn Helgaas
2022-02-28 22:13           ` Bjorn Helgaas
2022-02-28 22:32           ` Lukas Wunner [this message]
2022-02-28 22:32             ` [Nouveau] " Lukas Wunner
2022-02-28 22:32             ` Lukas Wunner
2022-02-28 22:36             ` Limonciello, Mario
2022-02-28 22:36               ` [Nouveau] " Limonciello, Mario
2022-02-28 22:36               ` Limonciello, Mario
2022-03-01  7:04               ` Mika Westerberg
2022-03-01  7:04                 ` Mika Westerberg
2022-03-01  7:04                 ` [Nouveau] " Mika Westerberg
2022-03-01  7:04                 ` Mika Westerberg
2022-02-24 21:51 ` [PATCH v5 4/7] drm/amd: drop the use of `pci_is_thunderbolt_attached` Mario Limonciello
2022-02-24 21:51   ` Mario Limonciello
2022-02-24 21:51   ` [Nouveau] " Mario Limonciello
2022-02-24 21:51   ` Mario Limonciello
2022-02-24 21:51 ` [PATCH v5 5/7] drm/nouveau: " Mario Limonciello
2022-02-24 21:51   ` Mario Limonciello
2022-02-24 21:51   ` [Nouveau] " Mario Limonciello
2022-02-24 21:51   ` Mario Limonciello
2022-02-24 21:51 ` [PATCH v5 6/7] drm/radeon: " Mario Limonciello
2022-02-24 21:51   ` Mario Limonciello
2022-02-24 21:51   ` [Nouveau] " Mario Limonciello
2022-02-24 21:51   ` Mario Limonciello
2022-02-24 21:51 ` [PATCH v5 7/7] PCI: drop `pci_is_thunderbolt_attached` Mario Limonciello
2022-02-24 21:51   ` Mario Limonciello
2022-02-24 21:51   ` [Nouveau] " Mario Limonciello
2022-02-24 21:51   ` Mario Limonciello

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220228223246.GA11428@wunner.de \
    --to=lukas@wunner.de \
    --cc=Alexander.Deucher@amd.com \
    --cc=Mario.Limonciello@amd.com \
    --cc=YehezkelShB@gmail.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=andreas.noever@gmail.com \
    --cc=bhelgaas@google.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=helgaas@kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=michael.jamet@intel.com \
    --cc=mika.westerberg@linux.intel.com \
    --cc=nouveau@lists.freedesktop.org \
    --cc=platform-driver-x86@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.