All of lore.kernel.org
 help / color / mirror / Atom feed
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: Guenter Roeck <linux@roeck-us.net>,
	Roger Quadros <rogerq@kernel.org>,
	krzysztof.kozlowski@canonical.com, vigneshr@ti.com, nm@ti.com,
	linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mtd: rawnand: omap2: Actually prevent invalid configuration and build error
Date: Fri, 4 Mar 2022 16:54:51 +0100	[thread overview]
Message-ID: <20220304165451.0129012e@xps13> (raw)
In-Reply-To: <4bbe337e-8cd8-a4d6-303d-d5aa21bee2e0@infradead.org>

Hi Guenter, Roger,

rdunlap@infradead.org wrote on Sat, 26 Feb 2022 22:55:28 -0800:

> On 2/19/22 16:44, Guenter Roeck wrote:
> > On Sat, Feb 19, 2022 at 09:36:00PM +0200, Roger Quadros wrote:  
> >> The root of the problem is that we are selecting symbols that have
> >> dependencies. This can cause random configurations that can fail.
> >> The cleanest solution is to avoid using select.
> >>
> >> This driver uses interfaces from the OMAP_GPMC driver so we have to
> >> depend on it instead.
> >>
> >> Fixes: 4cd335dae3cf ("mtd: rawnand: omap2: Prevent invalid configuration and build error")
> >> Signed-off-by: Roger Quadros <rogerq@kernel.org>  
> > 
> > Tested-by: Guenter Roeck <linux@roeck-us.net>  
> 
> Tested-by: Randy Dunlap <rdunlap@infradead.org>

Sorry for noticing that just now, but there is still a problem with
this patch: we now always compile-in the OMAP_GPMC driver whenever we
need the NAND controller, even though it is not needed. This grows the
kernel for no reason.

In fact, Roger once said:

	"We will figure out how to enable OMAP_GPMC for K3 architecture
	some other way."

It turns out this is not what was finally proposed. Could we try yet
another solution?

> 
> Thanks.
> 
> >   
> >> ---
> >>  drivers/mtd/nand/raw/Kconfig | 3 +--
> >>  1 file changed, 1 insertion(+), 2 deletions(-)
> >>
> >> diff --git a/drivers/mtd/nand/raw/Kconfig b/drivers/mtd/nand/raw/Kconfig
> >> index 36e697456ec4..9b078e78f3fa 100644
> >> --- a/drivers/mtd/nand/raw/Kconfig
> >> +++ b/drivers/mtd/nand/raw/Kconfig
> >> @@ -42,8 +42,7 @@ config MTD_NAND_OMAP2
> >>  	tristate "OMAP2, OMAP3, OMAP4 and Keystone NAND controller"
> >>  	depends on ARCH_OMAP2PLUS || ARCH_KEYSTONE || ARCH_K3 || COMPILE_TEST
> >>  	depends on HAS_IOMEM
> >> -	select MEMORY
> >> -	select OMAP_GPMC
> >> +	depends on OMAP_GPMC
> >>  	help
> >>  	  Support for NAND flash on Texas Instruments OMAP2, OMAP3, OMAP4
> >>  	  and Keystone platforms.
> >> -- 
> >> 2.17.1
> >>  
> 

Thanks,
Miquèl

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

WARNING: multiple messages have this Message-ID (diff)
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: Guenter Roeck <linux@roeck-us.net>,
	Roger Quadros <rogerq@kernel.org>,
	krzysztof.kozlowski@canonical.com, vigneshr@ti.com, nm@ti.com,
	linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mtd: rawnand: omap2: Actually prevent invalid configuration and build error
Date: Fri, 4 Mar 2022 16:54:51 +0100	[thread overview]
Message-ID: <20220304165451.0129012e@xps13> (raw)
In-Reply-To: <4bbe337e-8cd8-a4d6-303d-d5aa21bee2e0@infradead.org>

Hi Guenter, Roger,

rdunlap@infradead.org wrote on Sat, 26 Feb 2022 22:55:28 -0800:

> On 2/19/22 16:44, Guenter Roeck wrote:
> > On Sat, Feb 19, 2022 at 09:36:00PM +0200, Roger Quadros wrote:  
> >> The root of the problem is that we are selecting symbols that have
> >> dependencies. This can cause random configurations that can fail.
> >> The cleanest solution is to avoid using select.
> >>
> >> This driver uses interfaces from the OMAP_GPMC driver so we have to
> >> depend on it instead.
> >>
> >> Fixes: 4cd335dae3cf ("mtd: rawnand: omap2: Prevent invalid configuration and build error")
> >> Signed-off-by: Roger Quadros <rogerq@kernel.org>  
> > 
> > Tested-by: Guenter Roeck <linux@roeck-us.net>  
> 
> Tested-by: Randy Dunlap <rdunlap@infradead.org>

Sorry for noticing that just now, but there is still a problem with
this patch: we now always compile-in the OMAP_GPMC driver whenever we
need the NAND controller, even though it is not needed. This grows the
kernel for no reason.

In fact, Roger once said:

	"We will figure out how to enable OMAP_GPMC for K3 architecture
	some other way."

It turns out this is not what was finally proposed. Could we try yet
another solution?

> 
> Thanks.
> 
> >   
> >> ---
> >>  drivers/mtd/nand/raw/Kconfig | 3 +--
> >>  1 file changed, 1 insertion(+), 2 deletions(-)
> >>
> >> diff --git a/drivers/mtd/nand/raw/Kconfig b/drivers/mtd/nand/raw/Kconfig
> >> index 36e697456ec4..9b078e78f3fa 100644
> >> --- a/drivers/mtd/nand/raw/Kconfig
> >> +++ b/drivers/mtd/nand/raw/Kconfig
> >> @@ -42,8 +42,7 @@ config MTD_NAND_OMAP2
> >>  	tristate "OMAP2, OMAP3, OMAP4 and Keystone NAND controller"
> >>  	depends on ARCH_OMAP2PLUS || ARCH_KEYSTONE || ARCH_K3 || COMPILE_TEST
> >>  	depends on HAS_IOMEM
> >> -	select MEMORY
> >> -	select OMAP_GPMC
> >> +	depends on OMAP_GPMC
> >>  	help
> >>  	  Support for NAND flash on Texas Instruments OMAP2, OMAP3, OMAP4
> >>  	  and Keystone platforms.
> >> -- 
> >> 2.17.1
> >>  
> 

Thanks,
Miquèl

  reply	other threads:[~2022-03-04 15:55 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-20  0:44 [PATCH] mtd: rawnand: omap2: Actually prevent invalid configuration and build error Guenter Roeck
2022-02-27  6:55 ` Randy Dunlap
2022-02-27  6:55   ` Randy Dunlap
2022-03-04 15:54   ` Miquel Raynal [this message]
2022-03-04 15:54     ` Miquel Raynal
2022-03-04 20:04     ` Guenter Roeck
2022-03-04 20:04       ` Guenter Roeck
2022-03-04 22:50     ` Roger Quadros
2022-03-04 22:50       ` Roger Quadros
2022-03-07 10:03       ` Miquel Raynal
2022-03-07 10:03         ` Miquel Raynal
2022-03-07 12:25         ` Roger Quadros
2022-03-07 12:25           ` Roger Quadros
2022-03-07 14:12           ` Miquel Raynal
2022-03-07 14:12             ` Miquel Raynal
2022-03-07 21:05             ` Roger Quadros
2022-03-07 21:05               ` Roger Quadros
2022-03-08  9:26               ` Miquel Raynal
2022-03-08  9:26                 ` Miquel Raynal
2022-03-07 14:21           ` Miquel Raynal
2022-03-07 14:21             ` Miquel Raynal
  -- strict thread matches above, loose matches on Subject: below --
2022-02-19 19:36 Roger Quadros
2022-02-19 19:36 ` Roger Quadros
2022-02-25 11:15 ` Miquel Raynal
2022-02-25 11:15   ` Miquel Raynal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220304165451.0129012e@xps13 \
    --to=miquel.raynal@bootlin.com \
    --cc=krzysztof.kozlowski@canonical.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=linux@roeck-us.net \
    --cc=nm@ti.com \
    --cc=rdunlap@infradead.org \
    --cc=rogerq@kernel.org \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.