From: Halil Pasic <pasic@linux.ibm.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Marek Szyprowski <m.szyprowski@samsung.com>,
Robin Murphy <robin.murphy@arm.com>,
Doug Gilbert <dgilbert@interlog.com>,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Christian Borntraeger <borntraeger@de.ibm.com>,
Anshuman Khandual <khandual@linux.vnet.ibm.com>,
Thiago Jung Bauermann <bauerman@linux.ibm.com>,
Tom Lendacky <thomas.lendacky@amd.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
stable@vger.kernel.org, iommu@lists.linux-foundation.org,
linux-doc@vger.kernel.org, Halil Pasic <pasic@linux.ibm.com>
Subject: Re: [PATCH 0/2] swiotlb: rework fix info leak with DMA_FROM_DEVICE
Date: Fri, 4 Mar 2022 17:29:08 +0100 [thread overview]
Message-ID: <20220304172908.43ab261d.pasic@linux.ibm.com> (raw)
In-Reply-To: <YiI2DPIrNLKwanZw@infradead.org>
On Fri, 4 Mar 2022 07:53:48 -0800
Christoph Hellwig <hch@infradead.org> wrote:
> On Fri, Mar 04, 2022 at 02:58:57PM +0100, Halil Pasic wrote:
> > Unfortunately, we ended up with the wrong version of the patch "fix info
> > leak with DMA_FROM_DEVICE" getting merged. We got v4 merged, but the
> > version we want is v7 with some minor tweaks which were supposed to be
> > applied by Christoph (swiotlb maintainer). After pointing this out, I
> > was asked by Christoph to create an incremental fix.
> >
> > IMHO the cleanest way to do this is a reverting the incorrect version
> > of the patch and applying the correct one. I hope that qualifies as
> > an incremental fix.
>
> I'd really do one patch to move to the expected state. I'd volunteer
> to merge the two patches, but I've recently shown that I'm not
> exactly good at that..
No problem, I can do that. It isn't hard to squash things together, but
when I was about to write the commit message, I had the feeling doing
a revert is cleaner.
Any other opinions?
Regards,
Halil
WARNING: multiple messages have this Message-ID (diff)
From: Halil Pasic <pasic@linux.ibm.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Tom Lendacky <thomas.lendacky@amd.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
linux-doc@vger.kernel.org, stable@vger.kernel.org,
Halil Pasic <pasic@linux.ibm.com>,
Christian Borntraeger <borntraeger@de.ibm.com>,
iommu@lists.linux-foundation.org,
Doug Gilbert <dgilbert@interlog.com>,
Anshuman Khandual <khandual@linux.vnet.ibm.com>,
Robin Murphy <robin.murphy@arm.com>,
Thiago Jung Bauermann <bauerman@linux.ibm.com>
Subject: Re: [PATCH 0/2] swiotlb: rework fix info leak with DMA_FROM_DEVICE
Date: Fri, 4 Mar 2022 17:29:08 +0100 [thread overview]
Message-ID: <20220304172908.43ab261d.pasic@linux.ibm.com> (raw)
In-Reply-To: <YiI2DPIrNLKwanZw@infradead.org>
On Fri, 4 Mar 2022 07:53:48 -0800
Christoph Hellwig <hch@infradead.org> wrote:
> On Fri, Mar 04, 2022 at 02:58:57PM +0100, Halil Pasic wrote:
> > Unfortunately, we ended up with the wrong version of the patch "fix info
> > leak with DMA_FROM_DEVICE" getting merged. We got v4 merged, but the
> > version we want is v7 with some minor tweaks which were supposed to be
> > applied by Christoph (swiotlb maintainer). After pointing this out, I
> > was asked by Christoph to create an incremental fix.
> >
> > IMHO the cleanest way to do this is a reverting the incorrect version
> > of the patch and applying the correct one. I hope that qualifies as
> > an incremental fix.
>
> I'd really do one patch to move to the expected state. I'd volunteer
> to merge the two patches, but I've recently shown that I'm not
> exactly good at that..
No problem, I can do that. It isn't hard to squash things together, but
when I was about to write the commit message, I had the feeling doing
a revert is cleaner.
Any other opinions?
Regards,
Halil
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
next prev parent reply other threads:[~2022-03-04 16:29 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-04 13:58 [PATCH 0/2] swiotlb: rework fix info leak with DMA_FROM_DEVICE Halil Pasic
2022-03-04 13:58 ` Halil Pasic
2022-03-04 13:58 ` [PATCH 1/2] Revert "swiotlb: fix info leak with DMA_FROM_DEVICE" Halil Pasic
2022-03-04 13:58 ` Halil Pasic
2022-03-04 14:28 ` Greg KH
2022-03-04 14:28 ` Greg KH
2022-03-04 16:34 ` Halil Pasic
2022-03-04 16:34 ` Halil Pasic
2022-03-04 16:55 ` Greg KH
2022-03-04 16:55 ` Greg KH
2022-03-05 0:42 ` Halil Pasic
2022-03-05 0:42 ` Halil Pasic
2022-03-04 13:58 ` [PATCH 2/2] swiotlb: fix info leak with DMA_FROM_DEVICE Halil Pasic
2022-03-04 13:58 ` Halil Pasic
2022-03-04 14:28 ` Greg KH
2022-03-04 14:28 ` Greg KH
2022-03-04 15:53 ` [PATCH 0/2] swiotlb: rework " Christoph Hellwig
2022-03-04 15:53 ` Christoph Hellwig
2022-03-04 16:29 ` Halil Pasic [this message]
2022-03-04 16:29 ` Halil Pasic
2022-03-04 18:49 ` Matthew Wilcox
2022-03-04 18:49 ` Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220304172908.43ab261d.pasic@linux.ibm.com \
--to=pasic@linux.ibm.com \
--cc=bauerman@linux.ibm.com \
--cc=borntraeger@de.ibm.com \
--cc=dgilbert@interlog.com \
--cc=hch@infradead.org \
--cc=iommu@lists.linux-foundation.org \
--cc=jejb@linux.ibm.com \
--cc=khandual@linux.vnet.ibm.com \
--cc=linux-doc@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=martin.petersen@oracle.com \
--cc=mst@redhat.com \
--cc=robin.murphy@arm.com \
--cc=stable@vger.kernel.org \
--cc=thomas.lendacky@amd.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.