From: Peter Kjellerstedt <pkj@axis.com>
To: <bitbake-devel@lists.openembedded.org>
Subject: [PATCH 1/3] knotty.py: Improve the message while waiting for running tasks to finish
Date: Mon, 7 Mar 2022 14:36:18 +0100 [thread overview]
Message-ID: <20220307133620.12404-1-pkj@axis.com> (raw)
From: Peter Kjellerstedt <peter.kjellerstedt@axis.com>
Use pluralise() to correct the grammar, and drop the colon at the end if
runnning in quiet mode.
Signed-off-by: Peter Kjellerstedt <peter.kjellerstedt@axis.com>
---
bitbake/lib/bb/ui/knotty.py | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/bitbake/lib/bb/ui/knotty.py b/bitbake/lib/bb/ui/knotty.py
index b02e59c1fe..a520895da2 100644
--- a/bitbake/lib/bb/ui/knotty.py
+++ b/bitbake/lib/bb/ui/knotty.py
@@ -272,7 +272,10 @@ class TerminalFilter(object):
tasks.append("%s (pid %s)" % (activetasks[t]["title"], activetasks[t]["pid"]))
if self.main.shutdown:
- content = "Waiting for %s running tasks to finish:" % len(activetasks)
+ content = pluralise("Waiting for %s running task to finish",
+ "Waiting for %s running tasks to finish", len(activetasks))
+ if not self.quiet:
+ content += ':'
print(content)
else:
if self.quiet:
next reply other threads:[~2022-03-07 13:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-07 13:36 Peter Kjellerstedt [this message]
2022-03-07 13:36 ` [PATCH 2/3] knotty.py: Give the setscene tasks their own progress bar Peter Kjellerstedt
2022-03-07 15:48 ` [bitbake-devel] " Richard Purdie
2022-03-07 16:00 ` Peter Kjellerstedt
2022-03-07 13:36 ` [PATCH 3/3] knotty.py: Separate the display of main tasks from running tasks Peter Kjellerstedt
2022-03-07 15:46 ` [bitbake-devel] " Richard Purdie
2022-03-07 16:01 ` Peter Kjellerstedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220307133620.12404-1-pkj@axis.com \
--to=pkj@axis.com \
--cc=bitbake-devel@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.