From: Peter Kjellerstedt <peter.kjellerstedt@axis.com>
To: Richard Purdie <richard.purdie@linuxfoundation.org>,
"bitbake-devel@lists.openembedded.org"
<bitbake-devel@lists.openembedded.org>
Subject: RE: [bitbake-devel] [PATCH 3/3] knotty.py: Separate the display of main tasks from running tasks
Date: Mon, 7 Mar 2022 16:01:01 +0000 [thread overview]
Message-ID: <ae09826d6386494eb2bd939f05b8c4b1@axis.com> (raw)
In-Reply-To: <de7c81bffbc020841e3fd956f64288cb1a91297f.camel@linuxfoundation.org>
> -----Original Message-----
> From: Richard Purdie <richard.purdie@linuxfoundation.org>
> Sent: den 7 mars 2022 16:46
> To: Peter Kjellerstedt <peter.kjellerstedt@axis.com>; bitbake-
> devel@lists.openembedded.org
> Subject: Re: [bitbake-devel] [PATCH 3/3] knotty.py: Separate the display
> of main tasks from running tasks
>
> On Mon, 2022-03-07 at 14:36 +0100, Peter Kjellerstedt wrote:
> > From: Peter Kjellerstedt <peter.kjellerstedt@axis.com>
> >
> > It can be confusing that the count of running tasks shown together with
> > the progress bar for the main tasks also includes any running setscene
> > tasks.
> >
> > Separate the display so that the message for the main tasks' progress
> > bar only includes information on the main tasks, and the display of the
> > count of currently running tasks gets it own line.
> >
> > Signed-off-by: Peter Kjellerstedt <peter.kjellerstedt@axis.com>
> > ---
> >
> > This should be considered an RFC. With this change, the progress lines
> > for the setscene tasks and the main tasks (is that a good name for
> > those tasks?) look the same. The drawback is that it adds a line to
> > the display.
>
> I'm not keen. The progress bar only relates to "real" tasks, not setscene
> ones. I know some of the running tasks might be setscene ones but that was
> a compromise in the previous patches to keep the number of lines minimal.
> I wasn't convinced that issue mattered that much in reality.
As I said, this was just an RFC. I can live without it.
>
> Cheers,
>
> Richard
//Peter
prev parent reply other threads:[~2022-03-07 16:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-07 13:36 [PATCH 1/3] knotty.py: Improve the message while waiting for running tasks to finish Peter Kjellerstedt
2022-03-07 13:36 ` [PATCH 2/3] knotty.py: Give the setscene tasks their own progress bar Peter Kjellerstedt
2022-03-07 15:48 ` [bitbake-devel] " Richard Purdie
2022-03-07 16:00 ` Peter Kjellerstedt
2022-03-07 13:36 ` [PATCH 3/3] knotty.py: Separate the display of main tasks from running tasks Peter Kjellerstedt
2022-03-07 15:46 ` [bitbake-devel] " Richard Purdie
2022-03-07 16:01 ` Peter Kjellerstedt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ae09826d6386494eb2bd939f05b8c4b1@axis.com \
--to=peter.kjellerstedt@axis.com \
--cc=bitbake-devel@lists.openembedded.org \
--cc=richard.purdie@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.