From: Vincent Whitchurch <vincent.whitchurch@axis.com>
To: Rob Herring <robh+dt@kernel.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jirislaby@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
kernel <kernel@axis.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"open list:SERIAL DRIVERS" <linux-serial@vger.kernel.org>,
linux-samsung-soc <linux-samsung-soc@vger.kernel.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
Alim Akhtar <alim.akhtar@samsung.com>
Subject: Re: [PATCH 1/2] dt-bindings: serial: samsung: Add ARTPEC-8 UART
Date: Wed, 9 Mar 2022 09:57:56 +0100 [thread overview]
Message-ID: <20220309085756.GA18220@axis.com> (raw)
In-Reply-To: <CAL_JsqKBDOu+63YrDCX51-zoTPu1utiPxXYmihL9kMvrpD3ctA@mail.gmail.com>
On Tue, Mar 08, 2022 at 04:41:45PM +0100, Rob Herring wrote:
> On Mon, Mar 7, 2022 at 2:51 AM Vincent Whitchurch
> <vincent.whitchurch@axis.com> wrote:
> >
> > Add a compatible for the UART on the ARTPEC-8 SoC.
>
> Yes, the diff says that already. Perhaps some explanation why you are
> adding another vendor SoC to Samsung UART and how the h/w is
> different. I can only guess based on having just gone thru this with
> Apple.
The IP has been customized for the ARTPEC-8 SoC but is closely related
to the variants used on the Exynos chips. I can add this information to
the commit message.
The choice of the vendor prefix is similar to the solution chosen in
this patch:
https://lore.kernel.org/lkml/20220125031604.76009-2-alim.akhtar@samsung.com/
WARNING: multiple messages have this Message-ID (diff)
From: Vincent Whitchurch <vincent.whitchurch@axis.com>
To: Rob Herring <robh+dt@kernel.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jirislaby@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
kernel <kernel@axis.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"open list:SERIAL DRIVERS" <linux-serial@vger.kernel.org>,
linux-samsung-soc <linux-samsung-soc@vger.kernel.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
Alim Akhtar <alim.akhtar@samsung.com>
Subject: Re: [PATCH 1/2] dt-bindings: serial: samsung: Add ARTPEC-8 UART
Date: Wed, 9 Mar 2022 09:57:56 +0100 [thread overview]
Message-ID: <20220309085756.GA18220@axis.com> (raw)
In-Reply-To: <CAL_JsqKBDOu+63YrDCX51-zoTPu1utiPxXYmihL9kMvrpD3ctA@mail.gmail.com>
On Tue, Mar 08, 2022 at 04:41:45PM +0100, Rob Herring wrote:
> On Mon, Mar 7, 2022 at 2:51 AM Vincent Whitchurch
> <vincent.whitchurch@axis.com> wrote:
> >
> > Add a compatible for the UART on the ARTPEC-8 SoC.
>
> Yes, the diff says that already. Perhaps some explanation why you are
> adding another vendor SoC to Samsung UART and how the h/w is
> different. I can only guess based on having just gone thru this with
> Apple.
The IP has been customized for the ARTPEC-8 SoC but is closely related
to the variants used on the Exynos chips. I can add this information to
the commit message.
The choice of the vendor prefix is similar to the solution chosen in
this patch:
https://lore.kernel.org/lkml/20220125031604.76009-2-alim.akhtar@samsung.com/
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-03-09 8:58 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-07 8:50 [PATCH 0/2] Add support for ARTPEC-8 UART Vincent Whitchurch
2022-03-07 8:50 ` Vincent Whitchurch
2022-03-07 8:50 ` [PATCH 1/2] dt-bindings: serial: samsung: Add " Vincent Whitchurch
2022-03-07 8:50 ` Vincent Whitchurch
2022-03-07 8:58 ` Krzysztof Kozlowski
2022-03-07 8:58 ` Krzysztof Kozlowski
2022-03-08 15:41 ` Rob Herring
2022-03-08 15:41 ` Rob Herring
2022-03-09 8:57 ` Vincent Whitchurch [this message]
2022-03-09 8:57 ` Vincent Whitchurch
2022-03-07 8:50 ` [PATCH 2/2] tty: serial: samsung: Add ARTPEC-8 support Vincent Whitchurch
2022-03-07 8:50 ` Vincent Whitchurch
2022-03-07 9:04 ` Krzysztof Kozlowski
2022-03-07 9:04 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220309085756.GA18220@axis.com \
--to=vincent.whitchurch@axis.com \
--cc=alim.akhtar@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=kernel@axis.com \
--cc=krzysztof.kozlowski@canonical.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.