From: kernel test robot <lkp@intel.com>
To: Oscar Salvador <osalvador@suse.de>,
Andrew Morton <akpm@linux-foundation.org>
Cc: kbuild-all@lists.01.org,
Linux Memory Management List <linux-mm@kvack.org>,
Dave Hansen <dave.hansen@linux.intel.com>,
"Huang, Ying" <ying.huang@intel.com>,
Abhishek Goel <huntbag@linux.vnet.ibm.com>,
linux-kernel@vger.kernel.org, Oscar Salvador <osalvador@suse.de>
Subject: Re: [PATCH] mm: Only re-generate demotion targets when a numa node changes its N_CPU state
Date: Thu, 10 Mar 2022 09:17:28 +0800 [thread overview]
Message-ID: <202203100900.4UKi7486-lkp@intel.com> (raw)
In-Reply-To: <20220309144644.4278-1-osalvador@suse.de>
Hi Oscar,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on hnaz-mm/master]
url: https://github.com/0day-ci/linux/commits/Oscar-Salvador/mm-Only-re-generate-demotion-targets-when-a-numa-node-changes-its-N_CPU-state/20220309-224707
base: https://github.com/hnaz/linux-mm master
config: riscv-randconfig-s032-20220309 (https://download.01.org/0day-ci/archive/20220310/202203100900.4UKi7486-lkp@intel.com/config)
compiler: riscv32-linux-gcc (GCC) 11.2.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# apt-get install sparse
# sparse version: v0.6.4-dirty
# https://github.com/0day-ci/linux/commit/8af0c9ff9475c64e31963a5810b127875081c5ff
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Oscar-Salvador/mm-Only-re-generate-demotion-targets-when-a-numa-node-changes-its-N_CPU-state/20220309-224707
git checkout 8af0c9ff9475c64e31963a5810b127875081c5ff
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=riscv SHELL=/bin/bash
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
mm/vmstat.c: In function 'vmstat_cpu_online':
>> mm/vmstat.c:2056:17: error: implicit declaration of function 'set_migration_target_nodes' [-Werror=implicit-function-declaration]
2056 | set_migration_target_nodes();
| ^~~~~~~~~~~~~~~~~~~~~~~~~~
cc1: some warnings being treated as errors
vim +/set_migration_target_nodes +2056 mm/vmstat.c
2049
2050 static int vmstat_cpu_online(unsigned int cpu)
2051 {
2052 refresh_zone_stat_thresholds();
2053
2054 if (!node_state(cpu_to_node(cpu), N_CPU)) {
2055 node_set_state(cpu_to_node(cpu), N_CPU);
> 2056 set_migration_target_nodes();
2057 }
2058
2059 return 0;
2060 }
2061
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
prev parent reply other threads:[~2022-03-10 1:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-09 14:46 [PATCH] mm: Only re-generate demotion targets when a numa node changes its N_CPU state Oscar Salvador
2022-03-09 21:02 ` Andrew Morton
2022-03-09 21:55 ` Oscar Salvador
2022-03-10 0:39 ` Huang, Ying
2022-03-10 5:48 ` Oscar Salvador
2022-03-10 6:24 ` Baolin Wang
2022-03-10 0:56 ` kernel test robot
2022-03-10 1:17 ` kernel test robot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202203100900.4UKi7486-lkp@intel.com \
--to=lkp@intel.com \
--cc=akpm@linux-foundation.org \
--cc=dave.hansen@linux.intel.com \
--cc=huntbag@linux.vnet.ibm.com \
--cc=kbuild-all@lists.01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=osalvador@suse.de \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.