From: Oscar Salvador <osalvador@suse.de>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Dave Hansen <dave.hansen@linux.intel.com>,
"Huang, Ying" <ying.huang@intel.com>,
Abhishek Goel <huntbag@linux.vnet.ibm.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm: Only re-generate demotion targets when a numa node changes its N_CPU state
Date: Wed, 9 Mar 2022 22:55:29 +0100 [thread overview]
Message-ID: <YikiUbWCb3VSrJzV@localhost.localdomain> (raw)
In-Reply-To: <20220309130249.60733272aafb3bd5f2e6b88c@linux-foundation.org>
On Wed, Mar 09, 2022 at 01:02:49PM -0800, Andrew Morton wrote:
> On Wed, 9 Mar 2022 15:46:44 +0100 Oscar Salvador <osalvador@suse.de> wrote:
> > +static inline void set_migration_target_nodes() {}
>
> Compiler won't like that. Please test (compile and runtime) with
> CONFIG_HOTPLUG_CPU=n.
Sorry, fat fingers. This on top:
diff --git a/include/linux/migrate.h b/include/linux/migrate.h
index c64fe2923fb0..b82b4a9a0136 100644
--- a/include/linux/migrate.h
+++ b/include/linux/migrate.h
@@ -51,7 +51,7 @@ extern bool numa_demotion_enabled;
#ifdef CONFIG_HOTPLUG_CPU
extern void set_migration_target_nodes(void);
#else
-static inline void set_migration_target_nodes() {}
+static inline void set_migration_target_nodes(void) {}
#endif
#else
I will wait for some feedback before sending a v2.
thanks Andrew!
--
Oscar Salvador
SUSE Labs
next prev parent reply other threads:[~2022-03-09 21:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-09 14:46 [PATCH] mm: Only re-generate demotion targets when a numa node changes its N_CPU state Oscar Salvador
2022-03-09 21:02 ` Andrew Morton
2022-03-09 21:55 ` Oscar Salvador [this message]
2022-03-10 0:39 ` Huang, Ying
2022-03-10 5:48 ` Oscar Salvador
2022-03-10 6:24 ` Baolin Wang
2022-03-10 0:56 ` kernel test robot
2022-03-10 1:17 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YikiUbWCb3VSrJzV@localhost.localdomain \
--to=osalvador@suse.de \
--cc=akpm@linux-foundation.org \
--cc=dave.hansen@linux.intel.com \
--cc=huntbag@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.