All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hans Schultz <schultz.hans@gmail.com>
To: davem@davemloft.net, kuba@kernel.org
Cc: Ivan Vecera <ivecera@redhat.com>, Andrew Lunn <andrew@lunn.ch>,
	Florian Fainelli <f.fainelli@gmail.com>,
	Jiri Pirko <jiri@resnulli.us>,
	Daniel Borkmann <daniel@iogearbox.net>,
	netdev@vger.kernel.org, Nikolay Aleksandrov <razor@blackwall.org>,
	bridge@lists.linux-foundation.org, linux-kernel@vger.kernel.org,
	Ido Schimmel <idosch@nvidia.com>,
	Hans Schultz <schultz.hans+netdev@gmail.com>,
	Roopa Prabhu <roopa@nvidia.com>,
	Vladimir Oltean <olteanv@gmail.com>,
	Vivien Didelot <vivien.didelot@gmail.com>
Subject: [Bridge] [PATCH net-next 2/3] net: switchdev: add support for offloading of fdb locked flag
Date: Thu, 10 Mar 2022 15:23:19 +0100	[thread overview]
Message-ID: <20220310142320.611738-3-schultz.hans+netdev@gmail.com> (raw)
In-Reply-To: <20220310142320.611738-1-schultz.hans+netdev@gmail.com>

Used for Mac-auth/MAB feature in the offloaded case.

Signed-off-by: Hans Schultz <schultz.hans+netdev@gmail.com>
---
 include/net/switchdev.h | 3 ++-
 net/bridge/br.c         | 3 ++-
 net/bridge/br_fdb.c     | 7 +++++--
 net/bridge/br_private.h | 2 +-
 4 files changed, 10 insertions(+), 5 deletions(-)

diff --git a/include/net/switchdev.h b/include/net/switchdev.h
index 3e424d40fae3..d5d923411f5e 100644
--- a/include/net/switchdev.h
+++ b/include/net/switchdev.h
@@ -229,7 +229,8 @@ struct switchdev_notifier_fdb_info {
 	u16 vid;
 	u8 added_by_user:1,
 	   is_local:1,
-	   offloaded:1;
+	   offloaded:1,
+	   locked:1;
 };
 
 struct switchdev_notifier_port_obj_info {
diff --git a/net/bridge/br.c b/net/bridge/br.c
index b1dea3febeea..adcdbecbc218 100644
--- a/net/bridge/br.c
+++ b/net/bridge/br.c
@@ -166,7 +166,8 @@ static int br_switchdev_event(struct notifier_block *unused,
 	case SWITCHDEV_FDB_ADD_TO_BRIDGE:
 		fdb_info = ptr;
 		err = br_fdb_external_learn_add(br, p, fdb_info->addr,
-						fdb_info->vid, false);
+						fdb_info->vid, false,
+						fdb_info->locked);
 		if (err) {
 			err = notifier_from_errno(err);
 			break;
diff --git a/net/bridge/br_fdb.c b/net/bridge/br_fdb.c
index 396dcf3084cf..91387aa7e400 100644
--- a/net/bridge/br_fdb.c
+++ b/net/bridge/br_fdb.c
@@ -987,7 +987,7 @@ static int __br_fdb_add(struct ndmsg *ndm, struct net_bridge *br,
 					   "FDB entry towards bridge must be permanent");
 			return -EINVAL;
 		}
-		err = br_fdb_external_learn_add(br, p, addr, vid, true);
+		err = br_fdb_external_learn_add(br, p, addr, vid, true, false);
 	} else {
 		spin_lock_bh(&br->hash_lock);
 		err = fdb_add_entry(br, p, addr, ndm, nlh_flags, vid, nfea_tb);
@@ -1216,7 +1216,7 @@ void br_fdb_unsync_static(struct net_bridge *br, struct net_bridge_port *p)
 
 int br_fdb_external_learn_add(struct net_bridge *br, struct net_bridge_port *p,
 			      const unsigned char *addr, u16 vid,
-			      bool swdev_notify)
+			      bool swdev_notify, bool locked)
 {
 	struct net_bridge_fdb_entry *fdb;
 	bool modified = false;
@@ -1236,6 +1236,9 @@ int br_fdb_external_learn_add(struct net_bridge *br, struct net_bridge_port *p,
 		if (!p)
 			flags |= BIT(BR_FDB_LOCAL);
 
+		if (locked)
+			flags |= BIT(BR_FDB_ENTRY_LOCKED);
+
 		fdb = fdb_create(br, p, addr, vid, flags);
 		if (!fdb) {
 			err = -ENOMEM;
diff --git a/net/bridge/br_private.h b/net/bridge/br_private.h
index f5a0b68c4857..3275e33b112f 100644
--- a/net/bridge/br_private.h
+++ b/net/bridge/br_private.h
@@ -790,7 +790,7 @@ int br_fdb_sync_static(struct net_bridge *br, struct net_bridge_port *p);
 void br_fdb_unsync_static(struct net_bridge *br, struct net_bridge_port *p);
 int br_fdb_external_learn_add(struct net_bridge *br, struct net_bridge_port *p,
 			      const unsigned char *addr, u16 vid,
-			      bool swdev_notify);
+			      bool swdev_notify, bool locked);
 int br_fdb_external_learn_del(struct net_bridge *br, struct net_bridge_port *p,
 			      const unsigned char *addr, u16 vid,
 			      bool swdev_notify);
-- 
2.30.2


WARNING: multiple messages have this Message-ID (diff)
From: Hans Schultz <schultz.hans@gmail.com>
To: davem@davemloft.net, kuba@kernel.org
Cc: netdev@vger.kernel.org,
	Hans Schultz <schultz.hans+netdev@gmail.com>,
	Andrew Lunn <andrew@lunn.ch>,
	Vivien Didelot <vivien.didelot@gmail.com>,
	Florian Fainelli <f.fainelli@gmail.com>,
	Vladimir Oltean <olteanv@gmail.com>,
	Jiri Pirko <jiri@resnulli.us>, Ivan Vecera <ivecera@redhat.com>,
	Roopa Prabhu <roopa@nvidia.com>,
	Nikolay Aleksandrov <razor@blackwall.org>,
	Daniel Borkmann <daniel@iogearbox.net>,
	Ido Schimmel <idosch@nvidia.com>,
	linux-kernel@vger.kernel.org, bridge@lists.linux-foundation.org
Subject: [PATCH net-next 2/3] net: switchdev: add support for offloading of fdb locked flag
Date: Thu, 10 Mar 2022 15:23:19 +0100	[thread overview]
Message-ID: <20220310142320.611738-3-schultz.hans+netdev@gmail.com> (raw)
In-Reply-To: <20220310142320.611738-1-schultz.hans+netdev@gmail.com>

Used for Mac-auth/MAB feature in the offloaded case.

Signed-off-by: Hans Schultz <schultz.hans+netdev@gmail.com>
---
 include/net/switchdev.h | 3 ++-
 net/bridge/br.c         | 3 ++-
 net/bridge/br_fdb.c     | 7 +++++--
 net/bridge/br_private.h | 2 +-
 4 files changed, 10 insertions(+), 5 deletions(-)

diff --git a/include/net/switchdev.h b/include/net/switchdev.h
index 3e424d40fae3..d5d923411f5e 100644
--- a/include/net/switchdev.h
+++ b/include/net/switchdev.h
@@ -229,7 +229,8 @@ struct switchdev_notifier_fdb_info {
 	u16 vid;
 	u8 added_by_user:1,
 	   is_local:1,
-	   offloaded:1;
+	   offloaded:1,
+	   locked:1;
 };
 
 struct switchdev_notifier_port_obj_info {
diff --git a/net/bridge/br.c b/net/bridge/br.c
index b1dea3febeea..adcdbecbc218 100644
--- a/net/bridge/br.c
+++ b/net/bridge/br.c
@@ -166,7 +166,8 @@ static int br_switchdev_event(struct notifier_block *unused,
 	case SWITCHDEV_FDB_ADD_TO_BRIDGE:
 		fdb_info = ptr;
 		err = br_fdb_external_learn_add(br, p, fdb_info->addr,
-						fdb_info->vid, false);
+						fdb_info->vid, false,
+						fdb_info->locked);
 		if (err) {
 			err = notifier_from_errno(err);
 			break;
diff --git a/net/bridge/br_fdb.c b/net/bridge/br_fdb.c
index 396dcf3084cf..91387aa7e400 100644
--- a/net/bridge/br_fdb.c
+++ b/net/bridge/br_fdb.c
@@ -987,7 +987,7 @@ static int __br_fdb_add(struct ndmsg *ndm, struct net_bridge *br,
 					   "FDB entry towards bridge must be permanent");
 			return -EINVAL;
 		}
-		err = br_fdb_external_learn_add(br, p, addr, vid, true);
+		err = br_fdb_external_learn_add(br, p, addr, vid, true, false);
 	} else {
 		spin_lock_bh(&br->hash_lock);
 		err = fdb_add_entry(br, p, addr, ndm, nlh_flags, vid, nfea_tb);
@@ -1216,7 +1216,7 @@ void br_fdb_unsync_static(struct net_bridge *br, struct net_bridge_port *p)
 
 int br_fdb_external_learn_add(struct net_bridge *br, struct net_bridge_port *p,
 			      const unsigned char *addr, u16 vid,
-			      bool swdev_notify)
+			      bool swdev_notify, bool locked)
 {
 	struct net_bridge_fdb_entry *fdb;
 	bool modified = false;
@@ -1236,6 +1236,9 @@ int br_fdb_external_learn_add(struct net_bridge *br, struct net_bridge_port *p,
 		if (!p)
 			flags |= BIT(BR_FDB_LOCAL);
 
+		if (locked)
+			flags |= BIT(BR_FDB_ENTRY_LOCKED);
+
 		fdb = fdb_create(br, p, addr, vid, flags);
 		if (!fdb) {
 			err = -ENOMEM;
diff --git a/net/bridge/br_private.h b/net/bridge/br_private.h
index f5a0b68c4857..3275e33b112f 100644
--- a/net/bridge/br_private.h
+++ b/net/bridge/br_private.h
@@ -790,7 +790,7 @@ int br_fdb_sync_static(struct net_bridge *br, struct net_bridge_port *p);
 void br_fdb_unsync_static(struct net_bridge *br, struct net_bridge_port *p);
 int br_fdb_external_learn_add(struct net_bridge *br, struct net_bridge_port *p,
 			      const unsigned char *addr, u16 vid,
-			      bool swdev_notify);
+			      bool swdev_notify, bool locked);
 int br_fdb_external_learn_del(struct net_bridge *br, struct net_bridge_port *p,
 			      const unsigned char *addr, u16 vid,
 			      bool swdev_notify);
-- 
2.30.2


  parent reply	other threads:[~2022-03-10 14:23 UTC|newest]

Thread overview: 106+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-10 14:23 [Bridge] [PATCH net-next 0/3] Extend locked port feature with FDB locked flag (MAC-Auth/MAB) Hans Schultz
2022-03-10 14:23 ` Hans Schultz
2022-03-10 14:23 ` [Bridge] [PATCH net-next 1/3] net: bridge: add fdb flag to extent locked port feature Hans Schultz
2022-03-10 14:23   ` Hans Schultz
2022-03-10 14:42   ` [Bridge] " Nikolay Aleksandrov
2022-03-10 14:42     ` Nikolay Aleksandrov
2022-03-10 15:38     ` [Bridge] " Hans Schultz
2022-03-10 15:38       ` Hans Schultz
2022-03-10 15:57       ` [Bridge] " Nikolay Aleksandrov
2022-03-10 15:57         ` Nikolay Aleksandrov
2022-03-10 16:11         ` [Bridge] " Hans Schultz
2022-03-10 16:11           ` Hans Schultz
2022-03-10 16:14           ` [Bridge] " Nikolay Aleksandrov
2022-03-10 16:14             ` Nikolay Aleksandrov
2022-03-10 16:33             ` [Bridge] " Hans Schultz
2022-03-10 16:33               ` Hans Schultz
2022-03-14 15:30   ` [Bridge] " Ido Schimmel
2022-03-14 15:30     ` Ido Schimmel
2022-03-15  8:48     ` [Bridge] " Hans Schultz
2022-03-15  8:48       ` Hans Schultz
2022-03-15 11:00       ` [Bridge] " Ido Schimmel
2022-03-15 11:00         ` Ido Schimmel
2022-03-10 14:23 ` Hans Schultz [this message]
2022-03-10 14:23   ` [PATCH net-next 2/3] net: switchdev: add support for offloading of fdb locked flag Hans Schultz
2022-03-10 14:23 ` [Bridge] [PATCH net-next 3/3] net: dsa: mv88e6xxx: mac-auth/MAB implementation Hans Schultz
2022-03-10 14:23   ` Hans Schultz
2022-03-10 14:28   ` [Bridge] " Vladimir Oltean
2022-03-10 14:28     ` Vladimir Oltean
2022-03-10 15:00     ` [Bridge] " Hans Schultz
2022-03-10 15:00       ` Hans Schultz
2022-03-10 15:07       ` [Bridge] " Vladimir Oltean
2022-03-10 15:07         ` Vladimir Oltean
2022-03-10 15:51         ` [Bridge] " Hans Schultz
2022-03-10 15:51           ` Hans Schultz
2022-03-10 16:05           ` [Bridge] " Vladimir Oltean
2022-03-10 16:05             ` Vladimir Oltean
2022-03-10 16:40             ` [Bridge] " Hans Schultz
2022-03-10 16:40               ` Hans Schultz
2022-03-10 15:57     ` [Bridge] " Hans Schultz
2022-03-10 15:57       ` Hans Schultz
2022-03-14 10:46     ` [Bridge] " Hans Schultz
2022-03-14 10:46       ` Hans Schultz
2022-03-16 23:34       ` [Bridge] " Vladimir Oltean
2022-03-16 23:34         ` Vladimir Oltean
2022-03-17  8:52         ` [Bridge] " Hans Schultz
2022-03-17  8:52           ` Hans Schultz
2022-03-17 14:19           ` [Bridge] " Andrew Lunn
2022-03-17 14:19             ` Andrew Lunn
2022-03-17 15:36             ` [Bridge] " Vladimir Oltean
2022-03-17 15:36               ` Vladimir Oltean
2022-03-17 16:07               ` [Bridge] " Hans Schultz
2022-03-17 16:07                 ` Hans Schultz
2022-03-17 16:18                 ` [Bridge] " Vladimir Oltean
2022-03-17 16:18                   ` Vladimir Oltean
2022-03-17 16:58                   ` [Bridge] " Hans Schultz
2022-03-17 16:58                     ` Hans Schultz
2022-03-17 17:20                     ` [Bridge] " Vladimir Oltean
2022-03-17 17:20                       ` Vladimir Oltean
2022-03-18 10:04                       ` [Bridge] " Hans Schultz
2022-03-18 10:04                         ` Hans Schultz
2022-03-18 12:14                         ` [Bridge] " Vladimir Oltean
2022-03-18 12:14                           ` Vladimir Oltean
2022-03-18 13:10                           ` [Bridge] " Hans Schultz
2022-03-18 13:10                             ` Hans Schultz
2022-03-18 13:19                             ` [Bridge] " Vladimir Oltean
2022-03-18 13:19                               ` Vladimir Oltean
2022-03-22 11:01                               ` [Bridge] " Hans Schultz
2022-03-22 11:01                                 ` Hans Schultz
2022-03-22 11:08                                 ` [Bridge] " Vladimir Oltean
2022-03-22 11:08                                   ` Vladimir Oltean
2022-03-22 13:21                                   ` [Bridge] " Hans Schultz
2022-03-22 13:21                                     ` Hans Schultz
2022-03-22 14:47                                     ` [Bridge] " Hans Schultz
2022-03-22 14:47                                       ` Hans Schultz
2022-03-23 10:13                                   ` [Bridge] " Hans Schultz
2022-03-23 10:13                                     ` Hans Schultz
2022-03-23 10:16                                     ` [Bridge] " Vladimir Oltean
2022-03-23 10:16                                       ` Vladimir Oltean
2022-03-23 10:46                                       ` [Bridge] " Hans Schultz
2022-03-23 10:46                                         ` Hans Schultz
2022-03-23 10:57                                       ` [Bridge] " Hans Schultz
2022-03-23 10:57                                         ` Hans Schultz
2022-03-23 11:21                                         ` [Bridge] " Vladimir Oltean
2022-03-23 11:21                                           ` Vladimir Oltean
2022-03-23 11:43                                           ` [Bridge] " Hans Schultz
2022-03-23 11:43                                             ` Hans Schultz
2022-03-23 11:54                                             ` [Bridge] " Vladimir Oltean
2022-03-23 11:54                                               ` Vladimir Oltean
2022-03-21 14:51             ` [Bridge] " Hans Schultz
2022-03-21 14:51               ` Hans Schultz
2022-03-10 14:54   ` [Bridge] " Andrew Lunn
2022-03-10 14:54     ` Andrew Lunn
2022-03-11  7:59     ` [Bridge] " Hans Schultz
2022-03-11  7:59       ` Hans Schultz
2022-03-14 15:50 ` [Bridge] [PATCH net-next 0/3] Extend locked port feature with FDB locked flag (MAC-Auth/MAB) Ido Schimmel
2022-03-14 15:50   ` Ido Schimmel
2022-03-15  8:59   ` [Bridge] " Hans Schultz
2022-03-15  8:59     ` Hans Schultz
2022-03-15 11:11     ` [Bridge] " Ido Schimmel
2022-03-15 11:11       ` Ido Schimmel
2022-03-17  0:18 ` [Bridge] " Florian Fainelli
2022-03-17  0:18   ` Florian Fainelli
2022-03-17  8:29   ` [Bridge] " Hans Schultz
2022-03-17  8:29     ` Hans Schultz
2022-03-17 18:42     ` [Bridge] " Vladimir Oltean
2022-03-17 18:42       ` Vladimir Oltean

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220310142320.611738-3-schultz.hans+netdev@gmail.com \
    --to=schultz.hans@gmail.com \
    --cc=andrew@lunn.ch \
    --cc=bridge@lists.linux-foundation.org \
    --cc=daniel@iogearbox.net \
    --cc=davem@davemloft.net \
    --cc=f.fainelli@gmail.com \
    --cc=idosch@nvidia.com \
    --cc=ivecera@redhat.com \
    --cc=jiri@resnulli.us \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=olteanv@gmail.com \
    --cc=razor@blackwall.org \
    --cc=roopa@nvidia.com \
    --cc=schultz.hans+netdev@gmail.com \
    --cc=vivien.didelot@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.