Re: [Buildroot] [PATCH v3 2/7] boot/optee-os: add support to build with python-cryptography

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

Hello Clément,

On Fri, 11 Mar 2022 13:36:31 +0100
Clément Léger <clement.leger@bootlin.com> wrote:

> Newer version of optee-os (>= 3.16) uses python-cryptography instead of
> python-pycryptodomex in python scripts. Add support to build these
> newer versions by adding a new
> BR2_TARGET_OPTEE_OS_NEEDS_PYTHON_CRYPTOGRAPHY option which will
> select host-python-cryptography dependency when building optee-os.
> 
> Acked-by: Etienne Carriere <etienne.carriere@linaro.org>
> Signed-off-by: Clément Léger <clement.leger@bootlin.com>
> ---
>  boot/optee-os/Config.in   | 8 ++++++++
>  boot/optee-os/optee-os.mk | 7 ++++++-
>  2 files changed, 14 insertions(+), 1 deletion(-)
> 
> diff --git a/boot/optee-os/Config.in b/boot/optee-os/Config.in
> index 0974578484..f8426f9ab2 100644
> --- a/boot/optee-os/Config.in
> +++ b/boot/optee-os/Config.in
> @@ -48,6 +48,14 @@ config BR2_TARGET_OPTEE_OS_CUSTOM_REPO_VERSION
>  
>  endif
>  
> +config BR2_TARGET_OPTEE_OS_NEEDS_PYTHON_CRYPTOGRAPHY
> +	bool "optee-os needs host-python-cryptography to build"

Just:

	bool "optee-os needs host-python-cryptography"

you also need to add some dependencies, because rust is not supported
on all host architectures, so you need:

	depends on BR2_PACKAGE_HOST_RUSTC_ARCH_SUPPORTS

> -OPTEE_OS_DEPENDENCIES = host-openssl host-python3 host-python-pycryptodomex host-python-pyelftools
> +OPTEE_OS_DEPENDENCIES = host-openssl host-python3 host-python-pyelftools
> +ifeq ($(BR2_TARGET_OPTEE_OS_NEEDS_PYTHON_CRYPTOGRAPHY),y)
> +OPTEE_OS_DEPENDENCIES += host-python-cryptography
> +else
> +OPTEE_OS_DEPENDENCIES += host-python-pycryptodomex
> +endif

Semantically speaking, it's a bit odd that enabling
BR2_TARGET_OPTEE_OS_NEEDS_PYTHON_CRYPTOGRAPHY drops the
host-python-pycryptodomex dependency. But I guess this is what makes
the most sense in that situation.

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot