Re: [Buildroot] [PATCH v3 1/7] package/python-cryptography: enable host package

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

Hello,

On Fri, 11 Mar 2022 13:36:30 +0100
Clément Léger <clement.leger@bootlin.com> wrote:

> Enable host package and add needed dependencies.
> 
> Acked-by: Etienne Carriere <etienne.carriere@linaro.org>
> Signed-off-by: Clément Léger <clement.leger@bootlin.com>
> ---
>  package/python-cryptography/python-cryptography.mk | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/package/python-cryptography/python-cryptography.mk b/package/python-cryptography/python-cryptography.mk
> index a524f729c8..4ff61c7f86 100644
> --- a/package/python-cryptography/python-cryptography.mk
> +++ b/package/python-cryptography/python-cryptography.mk
> @@ -17,6 +17,11 @@ PYTHON_CRYPTOGRAPHY_DEPENDENCIES = \
>  	host-python-cffi \
>  	host-rustc \
>  	openssl
> +HOST_PYTHON_CRYPTOGRAPHY_DEPENDENCIES = \
> +	host-python-setuptools-rust \
> +	host-python-cffi \
> +	host-rustc \
> +	openssl

Also, I am actually surprised this is enough. Indeed, there are some
parts in Rust in python-cryptography, so we have quite some extra
variables for the target packages to handle this:

PYTHON_CRYPTOGRAPHY_ENV = \
        $(PKG_CARGO_ENV) \
        PYO3_CROSS_LIB_DIR="$(STAGING_DIR)/usr/lib/python$(PYTHON3_VERSION_MAJOR)"
# We need to vendor the Cargo crates at download time
PYTHON_CRYPTOGRAPHY_DOWNLOAD_POST_PROCESS = cargo
PYTHON_CRYPTOGRAPHY_DOWNLOAD_DEPENDENCIES = host-rustc
PYTHON_CRYPTOGRAPHY_DL_ENV = \
        BR_CARGO_MANIFEST_PATH=src/rust/Cargo.toml

For the last 3 variables, I can explain that it possibly worked for you
because you perhaps already had the python-cryptography tarball in
DL_DIR downloaded by the host variant of the package. But if you remove
this tarball, and build just the host variant, I would suspect that it
will fail to build.

However, I can't really explain why your package works without
HOST_PYTHON_CRYTOGRAPHY_ENV.

Make sure to do a clean build in a Docker container that doesn't have
Rust installed (there is an official Buildroot Docker image that is
available for this kind of testing).

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot