From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Jonathan Cameron <jic23@kernel.org>
Cc: linux-iio@vger.kernel.org, Lars-Peter Clausen <lars@metafoo.de>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
Alexandru Ardelean <ardeleanalex@gmail.com>,
Denis Ciocca <denis.ciocca@st.com>,
Linus Walleij <linus.walleij@linaro.org>,
Lorenzo Bianconi <lorenzo@kernel.org>,
christophe.priouzeau@st.com
Subject: Re: [PATCH v3 13/13] iio: core: Clarify the modes
Date: Tue, 15 Mar 2022 16:44:50 +0100 [thread overview]
Message-ID: <20220315164450.2fca5fcf@xps13> (raw)
In-Reply-To: <20220227133549.016935a1@jic23-huawei>
Hello,
+ Christophe
jic23@kernel.org wrote on Sun, 27 Feb 2022 13:35:49 +0000:
> On Mon, 14 Feb 2022 09:53:08 +0100
> Miquel Raynal <miquel.raynal@bootlin.com> wrote:
>
> > Hi Jonathan,
> >
> > jic23@kernel.org wrote on Sun, 13 Feb 2022 18:42:24 +0000:
> >
> > > On Mon, 7 Feb 2022 15:38:40 +0100
> > > Miquel Raynal <miquel.raynal@bootlin.com> wrote:
> > >
> > > > As part of a previous discussion with Jonathan Cameron [1], it appeared
> > > > necessary to clarify the meaning of each mode so that new developers
> > > > could understand better what they should use or not use and when.
> > > >
> > > > The idea of renaming these modes as been let aside because naming is a
> > > > big deal and requires a lot of thinking. So for now let's focus on
> > > > correctly explaining what each mode implies.
> > > >
> > > > [1] https://lore.kernel.org/linux-iio/20210930165510.2295e6c4@jic23-huawei/
> > > >
> > > > Suggested-by: Jonathan Cameron <jic23@kernel.org>
> > > > Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
> > > One trivial thing inline as a result of edits in v3.
> > >
> > > Otherwise, I want to let this series sit a little longer and ideally get
> > > some eyes on the st_sensors patches.
> >
> > Sure.
>
> Denis, Linus, Lorenzo,
>
> If any of you have time to take a look at patches 4-8 in this series or ideally
> to run basic sanity tests with series in place that would be great.
> https://patchwork.kernel.org/project/linux-iio/list/?series=611853
>
> I don't have a convenient platform to test that driver on any more and the
> changes are invasive enough to make me a little nervous about taking the
> series without someone more familiar with that driver taking a look.
I'm adding Christophe from ST who might also help having these patches
tested or at least reviewed.
TLDR: as part of a wider cleanup, I ended up "playing" with locks in
the st_sensors drivers, so any testing or feedback is welcome!
Thanks,
Miquèl
next prev parent reply other threads:[~2022-03-15 15:45 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-07 14:38 [PATCH v3 00/13] Miscellaneous IIO core enhancements Miquel Raynal
2022-02-07 14:38 ` [PATCH v3 01/13] iio: core: Enhance the kernel doc of modes and currentmodes iio_dev entries Miquel Raynal
2022-02-07 14:38 ` [PATCH v3 02/13] iio: magnetometer: rm3100: Stop abusing the ->currentmode Miquel Raynal
2022-02-07 14:38 ` [PATCH v3 03/13] iio: adc: stm32-dfsdm: Avoid dereferencing ->currentmode Miquel Raynal
2022-02-07 14:38 ` [PATCH v3 04/13] iio: st_sensors: Return as early as possible from the _write_raw() callbacks Miquel Raynal
2022-02-07 14:38 ` [PATCH v3 05/13] iio: st_sensors: Drop the protection on _avail functions Miquel Raynal
2022-02-07 14:38 ` [PATCH v3 06/13] iio: st_sensors: Add a local lock for protecting odr Miquel Raynal
2022-02-07 14:38 ` [PATCH v3 07/13] iio: st_sensors: Stop abusing mlock to ensure internal coherency Miquel Raynal
2022-02-07 14:38 ` [PATCH v3 08/13] iio: st_sensors: Use iio_device_claim/release_direct_mode() when relevant Miquel Raynal
2022-02-07 14:38 ` [PATCH v3 09/13] iio: Un-inline iio_buffer_enabled() Miquel Raynal
2022-02-07 14:38 ` [PATCH v3 10/13] iio: core: Hide read accesses to iio_dev->currentmode Miquel Raynal
2022-02-07 14:38 ` [PATCH v3 11/13] iio: core: Move the currentmode entry to the opaque structure Miquel Raynal
2022-02-07 14:38 ` [PATCH v3 12/13] iio: core: Simplify the registration of kfifo buffers Miquel Raynal
2022-02-07 14:38 ` [PATCH v3 13/13] iio: core: Clarify the modes Miquel Raynal
2022-02-13 18:42 ` Jonathan Cameron
2022-02-14 8:53 ` Miquel Raynal
2022-02-27 13:35 ` Jonathan Cameron
2022-03-15 15:44 ` Miquel Raynal [this message]
2022-04-05 8:02 ` Miquel Raynal
2022-04-10 15:27 ` Jonathan Cameron
2022-04-11 7:12 ` Miquel Raynal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220315164450.2fca5fcf@xps13 \
--to=miquel.raynal@bootlin.com \
--cc=ardeleanalex@gmail.com \
--cc=christophe.priouzeau@st.com \
--cc=denis.ciocca@st.com \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linus.walleij@linaro.org \
--cc=linux-iio@vger.kernel.org \
--cc=lorenzo@kernel.org \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.