* [PATCH] drm/amdgpu: fix off by one in amdgpu_gfx_kiq_acquire()
@ 2022-03-16 8:41 ` Dan Carpenter
0 siblings, 0 replies; 5+ messages in thread
From: Dan Carpenter @ 2022-03-16 8:41 UTC (permalink / raw)
To: Alex Deucher
Cc: Tao Zhou, David Airlie, kernel-janitors, Pan, Xinhui, Nirmoy Das,
amd-gfx, Lijo Lazar, Michel Dänzer, yipechai, dri-devel,
Evan Quan, Christian König, Dennis Li, Alex Xie
This post-op should be a pre-op so that we do not pass -1 as the bit
number to test_bit(). The current code will loop downwards from 63 to
-1. After changing to a pre-op, it loops from 63 to 0.
Fixes: 71c37505e7ea ("drm/amdgpu/gfx: move more common KIQ code to amdgpu_gfx.c")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c
index 8fe939976224..28a736c507bb 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c
@@ -266,7 +266,7 @@ static int amdgpu_gfx_kiq_acquire(struct amdgpu_device *adev,
* adev->gfx.mec.num_pipe_per_mec
* adev->gfx.mec.num_queue_per_pipe;
- while (queue_bit-- >= 0) {
+ while (--queue_bit >= 0) {
if (test_bit(queue_bit, adev->gfx.mec.queue_bitmap))
continue;
--
2.20.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* [PATCH] drm/amdgpu: fix off by one in amdgpu_gfx_kiq_acquire()
@ 2022-03-16 8:41 ` Dan Carpenter
0 siblings, 0 replies; 5+ messages in thread
From: Dan Carpenter @ 2022-03-16 8:41 UTC (permalink / raw)
To: Alex Deucher
Cc: Christian König, Pan, Xinhui, David Airlie, Daniel Vetter,
yipechai, Tao Zhou, Lijo Lazar, Evan Quan, Michel Dänzer,
Dennis Li, Nirmoy Das, Alex Xie, amd-gfx, dri-devel,
kernel-janitors
This post-op should be a pre-op so that we do not pass -1 as the bit
number to test_bit(). The current code will loop downwards from 63 to
-1. After changing to a pre-op, it loops from 63 to 0.
Fixes: 71c37505e7ea ("drm/amdgpu/gfx: move more common KIQ code to amdgpu_gfx.c")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c
index 8fe939976224..28a736c507bb 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c
@@ -266,7 +266,7 @@ static int amdgpu_gfx_kiq_acquire(struct amdgpu_device *adev,
* adev->gfx.mec.num_pipe_per_mec
* adev->gfx.mec.num_queue_per_pipe;
- while (queue_bit-- >= 0) {
+ while (--queue_bit >= 0) {
if (test_bit(queue_bit, adev->gfx.mec.queue_bitmap))
continue;
--
2.20.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] drm/amdgpu: fix off by one in amdgpu_gfx_kiq_acquire()
2022-03-16 8:41 ` Dan Carpenter
@ 2022-03-17 20:37 ` Alex Deucher
-1 siblings, 0 replies; 5+ messages in thread
From: Alex Deucher @ 2022-03-17 20:37 UTC (permalink / raw)
To: Dan Carpenter
Cc: Pan, Xinhui, David Airlie, Tao Zhou, kernel-janitors,
amd-gfx list, Lijo Lazar, Michel Dänzer, Nirmoy Das,
Maling list - DRI developers, Evan Quan, Alex Deucher, yipechai,
Christian König, Dennis Li, Alex Xie
Applied. Thanks!
Alex
On Wed, Mar 16, 2022 at 4:42 AM Dan Carpenter <dan.carpenter@oracle.com> wrote:
>
> This post-op should be a pre-op so that we do not pass -1 as the bit
> number to test_bit(). The current code will loop downwards from 63 to
> -1. After changing to a pre-op, it loops from 63 to 0.
>
> Fixes: 71c37505e7ea ("drm/amdgpu/gfx: move more common KIQ code to amdgpu_gfx.c")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c
> index 8fe939976224..28a736c507bb 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c
> @@ -266,7 +266,7 @@ static int amdgpu_gfx_kiq_acquire(struct amdgpu_device *adev,
> * adev->gfx.mec.num_pipe_per_mec
> * adev->gfx.mec.num_queue_per_pipe;
>
> - while (queue_bit-- >= 0) {
> + while (--queue_bit >= 0) {
> if (test_bit(queue_bit, adev->gfx.mec.queue_bitmap))
> continue;
>
> --
> 2.20.1
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] drm/amdgpu: fix off by one in amdgpu_gfx_kiq_acquire()
@ 2022-03-17 20:37 ` Alex Deucher
0 siblings, 0 replies; 5+ messages in thread
From: Alex Deucher @ 2022-03-17 20:37 UTC (permalink / raw)
To: Dan Carpenter
Cc: Alex Deucher, Tao Zhou, David Airlie, kernel-janitors,
Pan, Xinhui, Nirmoy Das, amd-gfx list, Lijo Lazar,
Michel Dänzer, yipechai, Maling list - DRI developers,
Evan Quan, Christian König, Dennis Li, Alex Xie
Applied. Thanks!
Alex
On Wed, Mar 16, 2022 at 4:42 AM Dan Carpenter <dan.carpenter@oracle.com> wrote:
>
> This post-op should be a pre-op so that we do not pass -1 as the bit
> number to test_bit(). The current code will loop downwards from 63 to
> -1. After changing to a pre-op, it loops from 63 to 0.
>
> Fixes: 71c37505e7ea ("drm/amdgpu/gfx: move more common KIQ code to amdgpu_gfx.c")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c
> index 8fe939976224..28a736c507bb 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c
> @@ -266,7 +266,7 @@ static int amdgpu_gfx_kiq_acquire(struct amdgpu_device *adev,
> * adev->gfx.mec.num_pipe_per_mec
> * adev->gfx.mec.num_queue_per_pipe;
>
> - while (queue_bit-- >= 0) {
> + while (--queue_bit >= 0) {
> if (test_bit(queue_bit, adev->gfx.mec.queue_bitmap))
> continue;
>
> --
> 2.20.1
>
^ permalink raw reply [flat|nested] 5+ messages in thread