From: Christoph Hellwig <hch@lst.de>
To: Ryusuke Konishi <konishi.ryusuke@gmail.com>
Cc: "Jens Axboe" <axboe@kernel.dk>,
"Konstantin Komarov" <almaz.alexandrovich@paragon-software.com>,
linux-nfs@vger.kernel.org,
linux-nilfs <linux-nilfs@vger.kernel.org>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Mike Snitzer" <snitzer@redhat.com>,
"Philipp Reisner" <philipp.reisner@linbit.com>,
"Pavel Begunkov" <asml.silence@gmail.com>,
linux-block@vger.kernel.org,
"Roger Pau Monné" <roger.pau@citrix.co>,
"device-mapper development" <dm-devel@redhat.com>,
"Md . Haris Iqbal" <haris.iqbal@ionos.com>,
linux-fsdevel@vger.kernel.org, xen-devel@lists.xenproject.org,
"Lars Ellenberg" <lars.ellenberg@linbit.com>,
ntfs3@lists.linux.dev, "Jack Wang" <jinpu.wang@ionos.com>,
"Christoph Hellwig" <hch@lst.de>,
"Guenter Roeck" <linux@roeck-us.net>,
drbd-dev@lists.linbit.com
Subject: Re: [dm-devel] [PATCH 01/19] fs: remove mpage_alloc
Date: Wed, 23 Mar 2022 07:42:48 +0100 [thread overview]
Message-ID: <20220323064248.GA24874@lst.de> (raw)
In-Reply-To: <CAKFNMonRd5QQMzLoH3T=M=C=2Q_j9d86EYzZeY4DU2HQAE3E8w@mail.gmail.com>
On Wed, Mar 23, 2022 at 06:38:22AM +0900, Ryusuke Konishi wrote:
> This looks because the mask of GFP_KERNEL is removed along with
> the removal of mpage_alloc().
>
> The default value of the gfp flag is set to GFP_HIGHUSER_MOVABLE by
> inode_init_always().
> So, __GFP_HIGHMEM hits the gfp warning at bio_alloc() that
> do_mpage_readpage() calls.
Yeah. Let's try this to match the iomap code:
diff --git a/fs/mpage.c b/fs/mpage.c
index 9ed1e58e8d70b..d465883edf719 100644
--- a/fs/mpage.c
+++ b/fs/mpage.c
@@ -148,13 +148,11 @@ static struct bio *do_mpage_readpage(struct mpage_readpage_args *args)
int op = REQ_OP_READ;
unsigned nblocks;
unsigned relative_block;
- gfp_t gfp;
+ gfp_t gfp = mapping_gfp_constraint(page->mapping, GFP_KERNEL);
if (args->is_readahead) {
op |= REQ_RAHEAD;
- gfp = readahead_gfp_mask(page->mapping);
- } else {
- gfp = mapping_gfp_constraint(page->mapping, GFP_KERNEL);
+ gfp |= __GFP_NORETRY | __GFP_NOWARN;
}
if (page_has_buffers(page))
--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Ryusuke Konishi <konishi.ryusuke@gmail.com>
Cc: "Christoph Hellwig" <hch@lst.de>,
"Guenter Roeck" <linux@roeck-us.net>,
"Jens Axboe" <axboe@kernel.dk>,
linux-block@vger.kernel.org, linux-nfs@vger.kernel.org,
linux-nilfs <linux-nilfs@vger.kernel.org>,
"Mike Snitzer" <snitzer@redhat.com>,
"Philipp Reisner" <philipp.reisner@linbit.com>,
"Konstantin Komarov" <almaz.alexandrovich@paragon-software.com>,
"Roger Pau Monné" <roger.pau@citrix.co>,
"device-mapper development" <dm-devel@redhat.com>,
"Md . Haris Iqbal" <haris.iqbal@ionos.com>,
"Lars Ellenberg" <lars.ellenberg@linbit.com>,
linux-fsdevel@vger.kernel.org, xen-devel@lists.xenproject.org,
"Andrew Morton" <akpm@linux-foundation.org>,
ntfs3@lists.linux.dev, "Jack Wang" <jinpu.wang@ionos.com>,
"Pavel Begunkov" <asml.silence@gmail.com>,
drbd-dev@lists.linbit.com
Subject: Re: [dm-devel] [PATCH 01/19] fs: remove mpage_alloc
Date: Wed, 23 Mar 2022 07:42:48 +0100 [thread overview]
Message-ID: <20220323064248.GA24874@lst.de> (raw)
In-Reply-To: <CAKFNMonRd5QQMzLoH3T=M=C=2Q_j9d86EYzZeY4DU2HQAE3E8w@mail.gmail.com>
On Wed, Mar 23, 2022 at 06:38:22AM +0900, Ryusuke Konishi wrote:
> This looks because the mask of GFP_KERNEL is removed along with
> the removal of mpage_alloc().
>
> The default value of the gfp flag is set to GFP_HIGHUSER_MOVABLE by
> inode_init_always().
> So, __GFP_HIGHMEM hits the gfp warning at bio_alloc() that
> do_mpage_readpage() calls.
Yeah. Let's try this to match the iomap code:
diff --git a/fs/mpage.c b/fs/mpage.c
index 9ed1e58e8d70b..d465883edf719 100644
--- a/fs/mpage.c
+++ b/fs/mpage.c
@@ -148,13 +148,11 @@ static struct bio *do_mpage_readpage(struct mpage_readpage_args *args)
int op = REQ_OP_READ;
unsigned nblocks;
unsigned relative_block;
- gfp_t gfp;
+ gfp_t gfp = mapping_gfp_constraint(page->mapping, GFP_KERNEL);
if (args->is_readahead) {
op |= REQ_RAHEAD;
- gfp = readahead_gfp_mask(page->mapping);
- } else {
- gfp = mapping_gfp_constraint(page->mapping, GFP_KERNEL);
+ gfp |= __GFP_NORETRY | __GFP_NOWARN;
}
if (page_has_buffers(page))
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>
To: Ryusuke Konishi
<konishi.ryusuke-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: "Christoph Hellwig" <hch-jcswGhMUV9g@public.gmane.org>,
"Guenter Roeck" <linux-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>,
"Jens Axboe" <axboe-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org>,
linux-block-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-nilfs <linux-nilfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"Mike Snitzer" <snitzer-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
"Philipp Reisner"
<philipp.reisner-63ez5xqkn6DQT0dZR+AlfA@public.gmane.org>,
"Konstantin Komarov"
<almaz.alexandrovich-m5I1DM4ARimttCpgsWEBFlaTQe2KTcn/@public.gmane.org>,
"Roger Pau Monné"
<roger.pau-Sxgqhf6Nn4Bhl2p70BpVqQ@public.gmane.org>,
"device-mapper development"
<dm-devel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
"Md . Haris Iqbal"
<haris.iqbal-vEVw2sk9H7kAvxtiuMwx3w@public.gmane.org>,
"Lars Ellenberg"
<lars.ellenberg-63ez5xqkn6DQT0dZR+AlfA@public.gmane.org>,
linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
xen-devel-GuqFBffKawtpuQazS67q72D2FQJk+8+b@public.gmane.org,
"Andrew Morton"
<akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>,
ntfs3-cunTk1MwBs/YUNznpcFYbw@public.gmane.org,
"Jack Wang" <jinpu.wang-vEVw2sk9H7kAvxtiuMwx3w@public.gmane.org>,
"Pavel Begunkov"
<asml.silence-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
drbd-dev-cunTk1MwBs8qoQakbn7OcQ@public.gmane.org
Subject: Re: [dm-devel] [PATCH 01/19] fs: remove mpage_alloc
Date: Wed, 23 Mar 2022 07:42:48 +0100 [thread overview]
Message-ID: <20220323064248.GA24874@lst.de> (raw)
In-Reply-To: <CAKFNMonRd5QQMzLoH3T=M=C=2Q_j9d86EYzZeY4DU2HQAE3E8w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
On Wed, Mar 23, 2022 at 06:38:22AM +0900, Ryusuke Konishi wrote:
> This looks because the mask of GFP_KERNEL is removed along with
> the removal of mpage_alloc().
>
> The default value of the gfp flag is set to GFP_HIGHUSER_MOVABLE by
> inode_init_always().
> So, __GFP_HIGHMEM hits the gfp warning at bio_alloc() that
> do_mpage_readpage() calls.
Yeah. Let's try this to match the iomap code:
diff --git a/fs/mpage.c b/fs/mpage.c
index 9ed1e58e8d70b..d465883edf719 100644
--- a/fs/mpage.c
+++ b/fs/mpage.c
@@ -148,13 +148,11 @@ static struct bio *do_mpage_readpage(struct mpage_readpage_args *args)
int op = REQ_OP_READ;
unsigned nblocks;
unsigned relative_block;
- gfp_t gfp;
+ gfp_t gfp = mapping_gfp_constraint(page->mapping, GFP_KERNEL);
if (args->is_readahead) {
op |= REQ_RAHEAD;
- gfp = readahead_gfp_mask(page->mapping);
- } else {
- gfp = mapping_gfp_constraint(page->mapping, GFP_KERNEL);
+ gfp |= __GFP_NORETRY | __GFP_NOWARN;
}
if (page_has_buffers(page))
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Ryusuke Konishi <konishi.ryusuke@gmail.com>
Cc: "Jens Axboe" <axboe@kernel.dk>,
"Konstantin Komarov" <almaz.alexandrovich@paragon-software.com>,
linux-nfs@vger.kernel.org,
linux-nilfs <linux-nilfs@vger.kernel.org>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Mike Snitzer" <snitzer@redhat.com>,
"Philipp Reisner" <philipp.reisner@linbit.com>,
"Pavel Begunkov" <asml.silence@gmail.com>,
linux-block@vger.kernel.org,
"Roger Pau Monné" <roger.pau@citrix.co>,
"device-mapper development" <dm-devel@redhat.com>,
"Md . Haris Iqbal" <haris.iqbal@ionos.com>,
linux-fsdevel@vger.kernel.org, xen-devel@lists.xenproject.org,
"Lars Ellenberg" <lars.ellenberg@linbit.com>,
ntfs3@lists.linux.dev, "Jack Wang" <jinpu.wang@ionos.com>,
"Christoph Hellwig" <hch@lst.de>,
"Guenter Roeck" <linux@roeck-us.net>,
drbd-dev@lists.linbit.com
Subject: Re: [Drbd-dev] [dm-devel] [PATCH 01/19] fs: remove mpage_alloc
Date: Wed, 23 Mar 2022 07:42:48 +0100 [thread overview]
Message-ID: <20220323064248.GA24874@lst.de> (raw)
In-Reply-To: <CAKFNMonRd5QQMzLoH3T=M=C=2Q_j9d86EYzZeY4DU2HQAE3E8w@mail.gmail.com>
On Wed, Mar 23, 2022 at 06:38:22AM +0900, Ryusuke Konishi wrote:
> This looks because the mask of GFP_KERNEL is removed along with
> the removal of mpage_alloc().
>
> The default value of the gfp flag is set to GFP_HIGHUSER_MOVABLE by
> inode_init_always().
> So, __GFP_HIGHMEM hits the gfp warning at bio_alloc() that
> do_mpage_readpage() calls.
Yeah. Let's try this to match the iomap code:
diff --git a/fs/mpage.c b/fs/mpage.c
index 9ed1e58e8d70b..d465883edf719 100644
--- a/fs/mpage.c
+++ b/fs/mpage.c
@@ -148,13 +148,11 @@ static struct bio *do_mpage_readpage(struct mpage_readpage_args *args)
int op = REQ_OP_READ;
unsigned nblocks;
unsigned relative_block;
- gfp_t gfp;
+ gfp_t gfp = mapping_gfp_constraint(page->mapping, GFP_KERNEL);
if (args->is_readahead) {
op |= REQ_RAHEAD;
- gfp = readahead_gfp_mask(page->mapping);
- } else {
- gfp = mapping_gfp_constraint(page->mapping, GFP_KERNEL);
+ gfp |= __GFP_NORETRY | __GFP_NOWARN;
}
if (page_has_buffers(page))
next prev parent reply other threads:[~2022-03-23 6:43 UTC|newest]
Thread overview: 116+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-24 9:10 [dm-devel] improve the bio allocation interface v2 Christoph Hellwig
2022-01-24 9:10 ` [Drbd-dev] " Christoph Hellwig
2022-01-24 9:10 ` Christoph Hellwig
2022-01-24 9:10 ` [dm-devel] [PATCH 01/19] fs: remove mpage_alloc Christoph Hellwig
2022-01-24 9:10 ` [Drbd-dev] " Christoph Hellwig
2022-01-24 9:10 ` Christoph Hellwig
2022-03-22 21:19 ` [dm-devel] " Guenter Roeck
2022-03-22 21:19 ` [Drbd-dev] " Guenter Roeck
2022-03-22 21:19 ` Guenter Roeck
2022-03-22 21:38 ` Ryusuke Konishi
2022-03-22 21:38 ` [Drbd-dev] " Ryusuke Konishi
2022-03-22 21:38 ` Ryusuke Konishi
2022-03-22 21:38 ` Ryusuke Konishi
2022-03-23 6:42 ` Christoph Hellwig [this message]
2022-03-23 6:42 ` [Drbd-dev] " Christoph Hellwig
2022-03-23 6:42 ` Christoph Hellwig
2022-03-23 6:42 ` Christoph Hellwig
2022-03-23 9:29 ` Ryusuke Konishi
2022-03-23 9:29 ` [Drbd-dev] " Ryusuke Konishi
2022-03-23 9:29 ` Ryusuke Konishi
2022-01-24 9:10 ` [dm-devel] [PATCH 02/19] nilfs2: remove nilfs_alloc_seg_bio Christoph Hellwig
2022-01-24 9:10 ` [Drbd-dev] " Christoph Hellwig
2022-01-24 9:10 ` Christoph Hellwig
2022-01-24 9:10 ` Christoph Hellwig
2022-01-27 21:38 ` [dm-devel] " Ryusuke Konishi
2022-01-27 21:38 ` [Drbd-dev] " Ryusuke Konishi
2022-01-27 21:38 ` Ryusuke Konishi
2022-01-24 9:10 ` [dm-devel] [PATCH 03/19] nfs/blocklayout: remove bl_alloc_init_bio Christoph Hellwig
2022-01-24 9:10 ` [Drbd-dev] " Christoph Hellwig
2022-01-24 9:10 ` Christoph Hellwig
2022-01-24 9:10 ` Christoph Hellwig
2022-01-24 9:10 ` [dm-devel] [PATCH 04/19] ntfs3: remove ntfs_alloc_bio Christoph Hellwig
2022-01-24 9:10 ` [Drbd-dev] " Christoph Hellwig
2022-01-24 9:10 ` Christoph Hellwig
2022-01-24 9:10 ` Christoph Hellwig
2022-01-24 9:10 ` [dm-devel] [PATCH 05/19] dm: bio_alloc can't fail if it is allowed to sleep Christoph Hellwig
2022-01-24 9:10 ` [Drbd-dev] " Christoph Hellwig
2022-01-24 9:10 ` Christoph Hellwig
2022-01-24 9:10 ` Christoph Hellwig
2022-01-27 17:08 ` [dm-devel] " Mike Snitzer
2022-01-27 17:08 ` [Drbd-dev] " Mike Snitzer
2022-01-27 17:08 ` Mike Snitzer
2022-01-27 17:08 ` Mike Snitzer
2022-01-24 9:10 ` [dm-devel] [PATCH 06/19] dm-crypt: remove clone_init Christoph Hellwig
2022-01-24 9:10 ` [Drbd-dev] " Christoph Hellwig
2022-01-24 9:10 ` Christoph Hellwig
2022-01-24 9:10 ` Christoph Hellwig
2022-01-27 17:09 ` [dm-devel] " Mike Snitzer
2022-01-27 17:09 ` [Drbd-dev] " Mike Snitzer
2022-01-27 17:09 ` Mike Snitzer
2022-01-24 9:10 ` [dm-devel] [PATCH 07/19] dm-snap: use blkdev_issue_flush instead of open coding it Christoph Hellwig
2022-01-24 9:10 ` [Drbd-dev] " Christoph Hellwig
2022-01-24 9:10 ` Christoph Hellwig
2022-01-24 9:10 ` Christoph Hellwig
2022-01-27 17:11 ` [dm-devel] " Mike Snitzer
2022-01-27 17:11 ` [Drbd-dev] " Mike Snitzer
2022-01-27 17:11 ` Mike Snitzer
2022-01-27 17:11 ` Mike Snitzer
2022-01-24 9:10 ` [dm-devel] [PATCH 08/19] dm-thin: " Christoph Hellwig
2022-01-24 9:10 ` [Drbd-dev] " Christoph Hellwig
2022-01-24 9:10 ` Christoph Hellwig
2022-01-24 9:10 ` Christoph Hellwig
2022-01-27 17:11 ` [dm-devel] " Mike Snitzer
2022-01-27 17:11 ` [Drbd-dev] " Mike Snitzer
2022-01-27 17:11 ` Mike Snitzer
2022-01-24 9:10 ` [dm-devel] [PATCH 09/19] drbd: bio_alloc can't fail if it is allow to sleep Christoph Hellwig
2022-01-24 9:10 ` [Drbd-dev] " Christoph Hellwig
2022-01-24 9:10 ` Christoph Hellwig
2022-01-24 9:10 ` [dm-devel] [PATCH 10/19] rnbd-srv: simplify bio mapping in process_rdma Christoph Hellwig
2022-01-24 9:10 ` [Drbd-dev] " Christoph Hellwig
2022-01-24 9:10 ` Christoph Hellwig
2022-01-24 9:10 ` [dm-devel] [PATCH 11/19] rnbd-srv: remove struct rnbd_dev_blk_io Christoph Hellwig
2022-01-24 9:10 ` [Drbd-dev] " Christoph Hellwig
2022-01-24 9:10 ` Christoph Hellwig
2022-01-24 9:10 ` Christoph Hellwig
2022-01-24 21:07 ` [dm-devel] " Jinpu Wang
2022-01-24 21:07 ` [Drbd-dev] " Jinpu Wang
2022-01-24 21:07 ` Jinpu Wang
2022-01-24 21:07 ` Jinpu Wang
2022-01-24 9:11 ` [dm-devel] [PATCH 12/19] xen-blkback: bio_alloc can't fail if it is allow to sleep Christoph Hellwig
2022-01-24 9:11 ` [Drbd-dev] " Christoph Hellwig
2022-01-24 9:11 ` Christoph Hellwig
2022-01-24 9:11 ` [dm-devel] [PATCH 13/19] block: move blk_next_bio to bio.c Christoph Hellwig
2022-01-24 9:11 ` [Drbd-dev] " Christoph Hellwig
2022-01-24 9:11 ` Christoph Hellwig
2022-01-24 9:11 ` [dm-devel] [PATCH 14/19] block: pass a block_device and opf to blk_next_bio Christoph Hellwig
2022-01-24 9:11 ` [Drbd-dev] " Christoph Hellwig
2022-01-24 9:11 ` Christoph Hellwig
2022-01-24 9:11 ` Christoph Hellwig
2022-01-24 9:11 ` [dm-devel] [PATCH 15/19] block: pass a block_device and opf to bio_alloc_bioset Christoph Hellwig
2022-01-24 9:11 ` [Drbd-dev] " Christoph Hellwig
2022-01-24 9:11 ` Christoph Hellwig
2022-01-24 9:11 ` Christoph Hellwig
2022-01-24 9:11 ` [dm-devel] [PATCH 16/19] block: pass a block_device and opf to bio_alloc_kiocb Christoph Hellwig
2022-01-24 9:11 ` [Drbd-dev] " Christoph Hellwig
2022-01-24 9:11 ` Christoph Hellwig
2022-01-24 9:11 ` Christoph Hellwig
2022-01-24 9:11 ` [dm-devel] [PATCH 17/19] block: pass a block_device and opf to bio_alloc Christoph Hellwig
2022-01-24 9:11 ` [Drbd-dev] " Christoph Hellwig
2022-01-24 9:11 ` Christoph Hellwig
2022-01-24 9:11 ` Christoph Hellwig
2022-01-24 9:11 ` [dm-devel] [PATCH 18/19] block: pass a block_device and opf to bio_init Christoph Hellwig
2022-01-24 9:11 ` [Drbd-dev] " Christoph Hellwig
2022-01-24 9:11 ` Christoph Hellwig
2022-01-24 9:11 ` Christoph Hellwig
2022-01-24 9:11 ` [dm-devel] [PATCH 19/19] block: pass a block_device and opf to bio_reset Christoph Hellwig
2022-01-24 9:11 ` [Drbd-dev] " Christoph Hellwig
2022-01-24 9:11 ` Christoph Hellwig
2022-01-24 9:11 ` Christoph Hellwig
2022-02-02 14:50 ` [dm-devel] improve the bio allocation interface v2 Jens Axboe
2022-02-02 14:50 ` [Drbd-dev] " Jens Axboe
2022-02-02 14:50 ` Jens Axboe
2022-02-02 14:50 ` Jens Axboe
-- strict thread matches above, loose matches on Subject: below --
2022-03-23 15:43 [dm-devel] [PATCH 01/19] fs: remove mpage_alloc Guenter Roeck
2022-03-23 15:43 ` Guenter Roeck
2022-01-18 7:19 [dm-devel] improve the bio allocation interface Christoph Hellwig
2022-01-18 7:19 ` [dm-devel] [PATCH 01/19] fs: remove mpage_alloc Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220323064248.GA24874@lst.de \
--to=hch@lst.de \
--cc=akpm@linux-foundation.org \
--cc=almaz.alexandrovich@paragon-software.com \
--cc=asml.silence@gmail.com \
--cc=axboe@kernel.dk \
--cc=dm-devel@redhat.com \
--cc=drbd-dev@lists.linbit.com \
--cc=haris.iqbal@ionos.com \
--cc=jinpu.wang@ionos.com \
--cc=konishi.ryusuke@gmail.com \
--cc=lars.ellenberg@linbit.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=linux-nilfs@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=ntfs3@lists.linux.dev \
--cc=philipp.reisner@linbit.com \
--cc=roger.pau@citrix.co \
--cc=snitzer@redhat.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.