* [PATCH] Bluetooth: mt7921s: fix a NULL check
@ 2022-03-23 7:48 ` Dan Carpenter
0 siblings, 0 replies; 8+ messages in thread
From: Dan Carpenter @ 2022-03-23 7:48 UTC (permalink / raw)
To: Marcel Holtmann, Yake Yang
Cc: Johan Hedberg, Luiz Augusto von Dentz, Matthias Brugger,
Sean Wang, Mark Chen, linux-bluetooth, linux-mediatek,
kernel-janitors
There is a typo in the NULL check so it's never true. It should be
checking "*ven_data" instead of "ven_data".
Fixes: 3cabc5ca2c9d ("Bluetooth: mt7921s: Add .btmtk_get_codec_config_data")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
drivers/bluetooth/btmtksdio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/bluetooth/btmtksdio.c b/drivers/bluetooth/btmtksdio.c
index f3dc5881fff7..b6d77e04240c 100644
--- a/drivers/bluetooth/btmtksdio.c
+++ b/drivers/bluetooth/btmtksdio.c
@@ -961,7 +961,7 @@ static int btmtksdio_get_codec_config_data(struct hci_dev *hdev,
}
*ven_data = kmalloc(sizeof(__u8), GFP_KERNEL);
- if (!ven_data) {
+ if (!*ven_data) {
err = -ENOMEM;
goto error;
}
--
2.20.1
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply related [flat|nested] 8+ messages in thread* 回复: [PATCH] Bluetooth: mt7921s: fix a NULL check
2022-03-23 7:48 ` Dan Carpenter
(?)
@ 2022-03-23 7:57 ` Yake Yang (杨亚克)
2022-03-23 8:49 ` bluez.test.bot
-1 siblings, 1 reply; 8+ messages in thread
From: Yake Yang (杨亚克) @ 2022-03-23 7:57 UTC (permalink / raw)
To: Dan Carpenter, Marcel Holtmann
Cc: Johan Hedberg, Luiz Augusto von Dentz, Matthias Brugger,
Sean Wang, Mark Chen, linux-bluetooth@vger.kernel.org,
linux-mediatek@lists.infradead.org,
kernel-janitors@vger.kernel.org,
Miles Chen (��民��)
Hi Dan,
Thanks for fixing this issue, we will update patch.
-----邮件原件-----
发件人: Dan Carpenter <dan.carpenter@oracle.com>
发送时间: 2022年3月23日 15:49
收件人: Marcel Holtmann <marcel@holtmann.org>; Yake Yang (杨亚克) <yake.yang@mediatek.com>
抄送: Johan Hedberg <johan.hedberg@gmail.com>; Luiz Augusto von Dentz <luiz.dentz@gmail.com>; Matthias Brugger <matthias.bgg@gmail.com>; Sean Wang <Sean.Wang@mediatek.com>; Mark Chen <markyawenchen@gmail.com>; linux-bluetooth@vger.kernel.org; linux-mediatek@lists.infradead.org; kernel-janitors@vger.kernel.org
主题: [PATCH] Bluetooth: mt7921s: fix a NULL check
There is a typo in the NULL check so it's never true. It should be checking "*ven_data" instead of "ven_data".
Fixes: 3cabc5ca2c9d ("Bluetooth: mt7921s: Add .btmtk_get_codec_config_data")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
drivers/bluetooth/btmtksdio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/bluetooth/btmtksdio.c b/drivers/bluetooth/btmtksdio.c index f3dc5881fff7..b6d77e04240c 100644
--- a/drivers/bluetooth/btmtksdio.c
+++ b/drivers/bluetooth/btmtksdio.c
@@ -961,7 +961,7 @@ static int btmtksdio_get_codec_config_data(struct hci_dev *hdev,
}
*ven_data = kmalloc(sizeof(__u8), GFP_KERNEL);
- if (!ven_data) {
+ if (!*ven_data) {
err = -ENOMEM;
goto error;
}
--
2.20.1
^ permalink raw reply [flat|nested] 8+ messages in thread* RE: Bluetooth: mt7921s: fix a NULL check
2022-03-23 7:48 ` Dan Carpenter
(?)
(?)
@ 2022-03-23 8:49 ` bluez.test.bot
2022-03-23 9:18 ` Dan Carpenter
-1 siblings, 1 reply; 8+ messages in thread
From: bluez.test.bot @ 2022-03-23 8:49 UTC (permalink / raw)
To: linux-bluetooth, dan.carpenter
[-- Attachment #1: Type: text/plain, Size: 560 bytes --]
This is an automated email and please do not reply to this email.
Dear Submitter,
Thank you for submitting the patches to the linux bluetooth mailing list.
While preparing the CI tests, the patches you submitted couldn't be applied to the current HEAD of the repository.
----- Output -----
error: patch failed: drivers/bluetooth/btmtksdio.c:961
error: drivers/bluetooth/btmtksdio.c: patch does not apply
hint: Use 'git am --show-current-patch' to see the failed patch
Please resolve the issue and submit the patches again.
---
Regards,
Linux Bluetooth
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: Bluetooth: mt7921s: fix a NULL check
2022-03-23 8:49 ` bluez.test.bot
@ 2022-03-23 9:18 ` Dan Carpenter
0 siblings, 0 replies; 8+ messages in thread
From: Dan Carpenter @ 2022-03-23 9:18 UTC (permalink / raw)
To: linux-bluetooth
On Wed, Mar 23, 2022 at 01:49:26AM -0700, bluez.test.bot@gmail.com wrote:
> This is an automated email and please do not reply to this email.
>
> Dear Submitter,
>
> Thank you for submitting the patches to the linux bluetooth mailing list.
> While preparing the CI tests, the patches you submitted couldn't be applied to the current HEAD of the repository.
>
> ----- Output -----
> error: patch failed: drivers/bluetooth/btmtksdio.c:961
> error: drivers/bluetooth/btmtksdio.c: patch does not apply
> hint: Use 'git am --show-current-patch' to see the failed patch
>
>
> Please resolve the issue and submit the patches again.
I tested it and it applies to:
git://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth-next.git master
It would help if the email said what tree the build-bot is using. Who
is maintaining the build-bot?
regards,
dan carpenter
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] Bluetooth: mt7921s: fix a NULL check
2022-03-23 7:48 ` Dan Carpenter
@ 2022-03-23 10:50 ` patchwork-bot+bluetooth
-1 siblings, 0 replies; 8+ messages in thread
From: patchwork-bot+bluetooth @ 2022-03-23 10:50 UTC (permalink / raw)
To: Dan Carpenter
Cc: marcel, yake.yang, johan.hedberg, luiz.dentz, matthias.bgg,
sean.wang, markyawenchen, linux-bluetooth, linux-mediatek,
kernel-janitors
Hello:
This patch was applied to bluetooth/bluetooth-next.git (master)
by Marcel Holtmann <marcel@holtmann.org>:
On Wed, 23 Mar 2022 10:48:30 +0300 you wrote:
> There is a typo in the NULL check so it's never true. It should be
> checking "*ven_data" instead of "ven_data".
>
> Fixes: 3cabc5ca2c9d ("Bluetooth: mt7921s: Add .btmtk_get_codec_config_data")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> drivers/bluetooth/btmtksdio.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Here is the summary with links:
- Bluetooth: mt7921s: fix a NULL check
https://git.kernel.org/bluetooth/bluetooth-next/c/864cc8a234cd
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] Bluetooth: mt7921s: fix a NULL check
@ 2022-03-23 10:50 ` patchwork-bot+bluetooth
0 siblings, 0 replies; 8+ messages in thread
From: patchwork-bot+bluetooth @ 2022-03-23 10:50 UTC (permalink / raw)
To: Dan Carpenter
Cc: marcel, yake.yang, johan.hedberg, luiz.dentz, matthias.bgg,
sean.wang, markyawenchen, linux-bluetooth, linux-mediatek,
kernel-janitors
Hello:
This patch was applied to bluetooth/bluetooth-next.git (master)
by Marcel Holtmann <marcel@holtmann.org>:
On Wed, 23 Mar 2022 10:48:30 +0300 you wrote:
> There is a typo in the NULL check so it's never true. It should be
> checking "*ven_data" instead of "ven_data".
>
> Fixes: 3cabc5ca2c9d ("Bluetooth: mt7921s: Add .btmtk_get_codec_config_data")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> drivers/bluetooth/btmtksdio.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Here is the summary with links:
- Bluetooth: mt7921s: fix a NULL check
https://git.kernel.org/bluetooth/bluetooth-next/c/864cc8a234cd
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply [flat|nested] 8+ messages in thread