From: "Michael S. Tsirkin" <mst@redhat.com>
To: Stefano Garzarella <sgarzare@redhat.com>
Cc: kvm@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org,
Asias He <asias@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
Jakub Kicinski <kuba@kernel.org>,
Arseny Krasnov <arseny.krasnov@kaspersky.com>,
Paolo Abeni <pabeni@redhat.com>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH net v2 0/3] vsock/virtio: enable VQs early on probe and finish the setup before using them
Date: Wed, 23 Mar 2022 09:22:02 -0400 [thread overview]
Message-ID: <20220323092118-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20220323084954.11769-1-sgarzare@redhat.com>
On Wed, Mar 23, 2022 at 09:49:51AM +0100, Stefano Garzarella wrote:
> The first patch fixes a virtio-spec violation. The other two patches
> complete the driver configuration before using the VQs in the probe.
>
> The patch order should simplify backporting in stable branches.
Ok but I think the order is wrong. It should be 2-3-1,
otherwise bisect can pick just 1 and it will have
the issues previous reviw pointed out.
> v2:
> - patch 1 is not changed from v1
> - added 2 patches to complete the driver configuration before using the
> VQs in the probe [MST]
>
> v1: https://lore.kernel.org/netdev/20220322103823.83411-1-sgarzare@redhat.com/
>
> Stefano Garzarella (3):
> vsock/virtio: enable VQs early on probe
> vsock/virtio: initialize vdev->priv before using VQs
> vsock/virtio: read the negotiated features before using VQs
>
> net/vmw_vsock/virtio_transport.c | 10 ++++++----
> 1 file changed, 6 insertions(+), 4 deletions(-)
>
> --
> 2.35.1
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
WARNING: multiple messages have this Message-ID (diff)
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Stefano Garzarella <sgarzare@redhat.com>
Cc: netdev@vger.kernel.org, Stefan Hajnoczi <stefanha@redhat.com>,
Paolo Abeni <pabeni@redhat.com>,
Arseny Krasnov <arseny.krasnov@kaspersky.com>,
"David S. Miller" <davem@davemloft.net>,
kvm@vger.kernel.org, virtualization@lists.linux-foundation.org,
linux-kernel@vger.kernel.org, Asias He <asias@redhat.com>,
Jakub Kicinski <kuba@kernel.org>
Subject: Re: [PATCH net v2 0/3] vsock/virtio: enable VQs early on probe and finish the setup before using them
Date: Wed, 23 Mar 2022 09:22:02 -0400 [thread overview]
Message-ID: <20220323092118-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20220323084954.11769-1-sgarzare@redhat.com>
On Wed, Mar 23, 2022 at 09:49:51AM +0100, Stefano Garzarella wrote:
> The first patch fixes a virtio-spec violation. The other two patches
> complete the driver configuration before using the VQs in the probe.
>
> The patch order should simplify backporting in stable branches.
Ok but I think the order is wrong. It should be 2-3-1,
otherwise bisect can pick just 1 and it will have
the issues previous reviw pointed out.
> v2:
> - patch 1 is not changed from v1
> - added 2 patches to complete the driver configuration before using the
> VQs in the probe [MST]
>
> v1: https://lore.kernel.org/netdev/20220322103823.83411-1-sgarzare@redhat.com/
>
> Stefano Garzarella (3):
> vsock/virtio: enable VQs early on probe
> vsock/virtio: initialize vdev->priv before using VQs
> vsock/virtio: read the negotiated features before using VQs
>
> net/vmw_vsock/virtio_transport.c | 10 ++++++----
> 1 file changed, 6 insertions(+), 4 deletions(-)
>
> --
> 2.35.1
next prev parent reply other threads:[~2022-03-23 13:22 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-23 8:49 [PATCH net v2 0/3] vsock/virtio: enable VQs early on probe and finish the setup before using them Stefano Garzarella
2022-03-23 8:49 ` Stefano Garzarella
2022-03-23 8:49 ` [PATCH net v2 1/3] vsock/virtio: enable VQs early on probe Stefano Garzarella
2022-03-23 8:49 ` Stefano Garzarella
2022-03-23 13:44 ` Stefan Hajnoczi
2022-03-23 13:44 ` Stefan Hajnoczi
2022-03-23 13:54 ` Stefano Garzarella
2022-03-23 13:54 ` Stefano Garzarella
2022-03-23 8:49 ` [PATCH net v2 2/3] vsock/virtio: initialize vdev->priv before using VQs Stefano Garzarella
2022-03-23 8:49 ` Stefano Garzarella
2022-03-23 13:45 ` Stefan Hajnoczi
2022-03-23 13:45 ` Stefan Hajnoczi
2022-03-23 8:49 ` [PATCH net v2 3/3] vsock/virtio: read the negotiated features " Stefano Garzarella
2022-03-23 8:49 ` Stefano Garzarella
2022-03-23 13:45 ` Stefan Hajnoczi
2022-03-23 13:45 ` Stefan Hajnoczi
2022-03-23 13:22 ` Michael S. Tsirkin [this message]
2022-03-23 13:22 ` [PATCH net v2 0/3] vsock/virtio: enable VQs early on probe and finish the setup before using them Michael S. Tsirkin
2022-03-23 13:43 ` Stefano Garzarella
2022-03-23 13:43 ` Stefano Garzarella
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220323092118-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=arseny.krasnov@kaspersky.com \
--cc=asias@redhat.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sgarzare@redhat.com \
--cc=stefanha@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.