Re: [PATCH v6 3/3] mtd: cfi_cmdset_0002: Rename chip_ready variables and add ID definition

[Miquel Raynal <miquel.raynal@bootlin.com>]

Hi Tokunori,

ikegami.t@gmail.com wrote on Thu, 24 Mar 2022 01:46:00 +0900:

> Hi Miquel-san,
> 
> On 2022/03/23 17:02, Miquel Raynal wrote:
> > Hi Tokunori,
> >
> > ikegami.t@gmail.com wrote on Wed, 23 Mar 2022 08:49:52 +0900:
> >  
> >> The definition is for the S29GL064N model number 01, 02, V1 and V2.  
> > Please keep resending the entire series.  
> I see. (In the past it was mentioned as not necessary to send all patches if a patch fixed of series.)

Generally speaking, while you have not been notified that a patch got
applied, it's best to resend it as part of your series.

> >  
> >> Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>
> >> Cc: Miquel Raynal <miquel.raynal@bootlin.com>
> >> Cc: Richard Weinberger <richard@nod.at>
> >> Cc: Vignesh Raghavendra <vigneshr@ti.com>
> >> Cc: linux-mtd@lists.infradead.org  
> > You don't need all these Cc there, just add them when sending
> > everything with git-format-patch. I believe you can use these fields
> > just for "extra" people which are not notably expected.  
> 
> Will do as so. By the way it was commented on the version 1 patch by Vignesh-san as below so added CC maintainers by version 2 patch.
>   > Please CC maintainers from
>   >
>   > ./scripts/get_maintainer.pl -f drivers/mtd/chips/cfi_cmdset_0002.c
>   >
>   > Else, patch would not get attention in time.  

And Vignesh is right. You should Cc the maintainers, but you can do
that by using git-send-email --cc foo --cc bar. Adding Cc: lines with
all the maintainers in the patch does not really help and just grows
the commit log for no reason.



Thanks,
Miquèl

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/