* [PATCH] sandbox: sdl: Add stub sandbox_sdl_remove_display()
@ 2022-03-23 18:03 Andrew Scull
2022-03-23 18:06 ` Andrew Scull
0 siblings, 1 reply; 3+ messages in thread
From: Andrew Scull @ 2022-03-23 18:03 UTC (permalink / raw)
To: u-boot; +Cc: Andrew Scull, Simon Glass, Anatolij Gustschin
Building the sandbox with NO_SDL=1 resulted in an undefined reference to
'sandbox_sdl_remove_display'. Resolve this by adding a stub
implementation to match the stubs to the other similar functions.
Signed-off-by: Andrew Scull <ascull@google.com>
Cc: Simon Glass <sjg@chromium.org>
Cc: Anatolij Gustschin <agust@denx.de>
---
arch/sandbox/include/asm/sdl.h | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/arch/sandbox/include/asm/sdl.h b/arch/sandbox/include/asm/sdl.h
index e271a849af..821b0c6a0e 100644
--- a/arch/sandbox/include/asm/sdl.h
+++ b/arch/sandbox/include/asm/sdl.h
@@ -94,6 +94,11 @@ static inline int sandbox_sdl_init_display(int width, int height, int log2_bpp,
return -ENODEV;
}
+static int sandbox_sdl_remove_display(void)
+{
+ return -ENODEV;
+}
+
static inline int sandbox_sdl_sync(void *lcd_base)
{
return -ENODEV;
--
2.35.1.894.gb6a874cedc-goog
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] sandbox: sdl: Add stub sandbox_sdl_remove_display()
2022-03-23 18:03 [PATCH] sandbox: sdl: Add stub sandbox_sdl_remove_display() Andrew Scull
@ 2022-03-23 18:06 ` Andrew Scull
2022-03-23 18:53 ` Simon Glass
0 siblings, 1 reply; 3+ messages in thread
From: Andrew Scull @ 2022-03-23 18:06 UTC (permalink / raw)
To: u-boot; +Cc: Simon Glass, Anatolij Gustschin
> +static int sandbox_sdl_remove_display(void)
Forgot the inline :/ should I resend or can it be added when applying?
> +{
> + return -ENODEV;
> +}
> +
> static inline int sandbox_sdl_sync(void *lcd_base)
> {
> return -ENODEV;
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] sandbox: sdl: Add stub sandbox_sdl_remove_display()
2022-03-23 18:06 ` Andrew Scull
@ 2022-03-23 18:53 ` Simon Glass
0 siblings, 0 replies; 3+ messages in thread
From: Simon Glass @ 2022-03-23 18:53 UTC (permalink / raw)
To: Andrew Scull; +Cc: U-Boot Mailing List, Anatolij Gustschin
Hi Andrew,
On Wed, 23 Mar 2022 at 12:06, Andrew Scull <ascull@google.com> wrote:
>
> > +static int sandbox_sdl_remove_display(void)
>
> Forgot the inline :/ should I resend or can it be added when applying?
Best to resend I think. With that you can add:
Reviewed-by: Simon Glass <sjg@chromium.org>
>
> > +{
> > + return -ENODEV;
> > +}
> > +
> > static inline int sandbox_sdl_sync(void *lcd_base)
> > {
> > return -ENODEV;
Regards,
Simon
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-03-23 18:54 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-03-23 18:03 [PATCH] sandbox: sdl: Add stub sandbox_sdl_remove_display() Andrew Scull
2022-03-23 18:06 ` Andrew Scull
2022-03-23 18:53 ` Simon Glass
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.