All of lore.kernel.org
 help / color / mirror / Atom feed
* + fatfs-remove-redundant-judgment.patch added to -mm tree
@ 2022-03-28 21:28 Andrew Morton
  0 siblings, 0 replies; only message in thread
From: Andrew Morton @ 2022-03-28 21:28 UTC (permalink / raw)
  To: mm-commits, hulkci, hirofumi, fengyubo3, akpm


The patch titled
     Subject: fatfs: remove redundant judgment
has been added to the -mm tree.  Its filename is
     fatfs-remove-redundant-judgment.patch

This patch should soon appear at
    https://ozlabs.org/~akpm/mmots/broken-out/fatfs-remove-redundant-judgment.patch
and later at
    https://ozlabs.org/~akpm/mmotm/broken-out/fatfs-remove-redundant-judgment.patch

Before you just go and hit "reply", please:
   a) Consider who else should be cc'ed
   b) Prefer to cc a suitable mailing list as well
   c) Ideally: find the original patch on the mailing list and do a
      reply-to-all to that, adding suitable additional cc's

*** Remember to use Documentation/process/submit-checklist.rst when testing your code ***

The -mm tree is included into linux-next and is updated
there every 3-4 working days

------------------------------------------------------
From: Yubo Feng <fengyubo3@huawei.com>
Subject: fatfs: remove redundant judgment

iput() has already judged the incoming parameter, so there is no need to
repeat outside.

Link: https://lkml.kernel.org/r/1648265418-76563-1-git-send-email-fengyubo3@huawei.com
Signed-off-by: Yubo Feng <fengyubo3@huawei.com>
Reported-by: Hulk Robot <hulkci@huawei.com>
Acked-by: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 fs/fat/inode.c |    6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

--- a/fs/fat/inode.c~fatfs-remove-redundant-judgment
+++ a/fs/fat/inode.c
@@ -1889,10 +1889,8 @@ out_invalid:
 		fat_msg(sb, KERN_INFO, "Can't find a valid FAT filesystem");
 
 out_fail:
-	if (fsinfo_inode)
-		iput(fsinfo_inode);
-	if (fat_inode)
-		iput(fat_inode);
+	iput(fsinfo_inode);
+	iput(fat_inode);
 	unload_nls(sbi->nls_io);
 	unload_nls(sbi->nls_disk);
 	fat_reset_iocharset(&sbi->options);
_

Patches currently in -mm which might be from fengyubo3@huawei.com are

fatfs-remove-redundant-judgment.patch


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2022-03-28 21:32 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-03-28 21:28 + fatfs-remove-redundant-judgment.patch added to -mm tree Andrew Morton

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.