From: Dan Carpenter <dan.carpenter@oracle.com>
To: yuzhe <yuzhe@nfschina.com>
Cc: Marc Zyngier <maz@kernel.org>,
james.morse@arm.com, alexandru.elisei@arm.com,
suzuki.poulose@arm.com, catalin.marinas@arm.com, will@kernel.org,
linux-arm-kernel@lists.infradead.org,
kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org,
liqiong@nfschina.com, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] KVM: arm64: vgic-debug: remove unnecessary type castings
Date: Tue, 29 Mar 2022 14:21:42 +0300 [thread overview]
Message-ID: <20220329112141.GZ3293@kadam> (raw)
In-Reply-To: <0f4cf955-ca2b-626f-867e-5a0ecfe68ca1@nfschina.com>
On Tue, Mar 29, 2022 at 02:14:16PM +0800, yuzhe wrote:
> > > @@ -229,7 +229,7 @@ static void print_irq_state(struct seq_file *s, struct vgic_irq *irq,
> > > static int vgic_debug_show(struct seq_file *s, void *v)
> > > {
> > > - struct kvm *kvm = (struct kvm *)s->private;
> > > + struct kvm *kvm = s->private;
> > > struct vgic_state_iter *iter = (struct vgic_state_iter *)v;
^^^^^^^^^^^^^^^^^^^^^^^^^^
This cast is unnecessary. Look for others as well.
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: yuzhe <yuzhe@nfschina.com>
Cc: kernel-janitors@vger.kernel.org, Marc Zyngier <maz@kernel.org>,
linux-kernel@vger.kernel.org, liqiong@nfschina.com,
catalin.marinas@arm.com, will@kernel.org,
kvmarm@lists.cs.columbia.edu,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] KVM: arm64: vgic-debug: remove unnecessary type castings
Date: Tue, 29 Mar 2022 14:21:42 +0300 [thread overview]
Message-ID: <20220329112141.GZ3293@kadam> (raw)
In-Reply-To: <0f4cf955-ca2b-626f-867e-5a0ecfe68ca1@nfschina.com>
On Tue, Mar 29, 2022 at 02:14:16PM +0800, yuzhe wrote:
> > > @@ -229,7 +229,7 @@ static void print_irq_state(struct seq_file *s, struct vgic_irq *irq,
> > > static int vgic_debug_show(struct seq_file *s, void *v)
> > > {
> > > - struct kvm *kvm = (struct kvm *)s->private;
> > > + struct kvm *kvm = s->private;
> > > struct vgic_state_iter *iter = (struct vgic_state_iter *)v;
^^^^^^^^^^^^^^^^^^^^^^^^^^
This cast is unnecessary. Look for others as well.
regards,
dan carpenter
_______________________________________________
kvmarm mailing list
kvmarm@lists.cs.columbia.edu
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: yuzhe <yuzhe@nfschina.com>
Cc: Marc Zyngier <maz@kernel.org>,
james.morse@arm.com, alexandru.elisei@arm.com,
suzuki.poulose@arm.com, catalin.marinas@arm.com, will@kernel.org,
linux-arm-kernel@lists.infradead.org,
kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org,
liqiong@nfschina.com, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] KVM: arm64: vgic-debug: remove unnecessary type castings
Date: Tue, 29 Mar 2022 14:21:42 +0300 [thread overview]
Message-ID: <20220329112141.GZ3293@kadam> (raw)
In-Reply-To: <0f4cf955-ca2b-626f-867e-5a0ecfe68ca1@nfschina.com>
On Tue, Mar 29, 2022 at 02:14:16PM +0800, yuzhe wrote:
> > > @@ -229,7 +229,7 @@ static void print_irq_state(struct seq_file *s, struct vgic_irq *irq,
> > > static int vgic_debug_show(struct seq_file *s, void *v)
> > > {
> > > - struct kvm *kvm = (struct kvm *)s->private;
> > > + struct kvm *kvm = s->private;
> > > struct vgic_state_iter *iter = (struct vgic_state_iter *)v;
^^^^^^^^^^^^^^^^^^^^^^^^^^
This cast is unnecessary. Look for others as well.
regards,
dan carpenter
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-03-29 11:22 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-28 10:38 [PATCH] KVM: arm64: vgic-debug: remove unnecessary type castings yuzhe
2022-03-28 10:38 ` yuzhe
2022-03-28 10:38 ` yuzhe
2022-03-28 13:36 ` Marc Zyngier
2022-03-28 13:36 ` Marc Zyngier
2022-03-28 13:36 ` Marc Zyngier
2022-03-29 6:14 ` yuzhe
2022-03-29 6:14 ` yuzhe
2022-03-29 6:14 ` yuzhe
2022-03-29 7:07 ` Marc Zyngier
2022-03-29 7:07 ` Marc Zyngier
2022-03-29 7:07 ` Marc Zyngier
2022-03-29 7:26 ` yuzhe
2022-03-29 7:26 ` yuzhe
2022-03-29 7:26 ` yuzhe
2022-03-29 11:21 ` Dan Carpenter [this message]
2022-03-29 11:21 ` Dan Carpenter
2022-03-29 11:21 ` Dan Carpenter
2022-03-29 10:20 ` [PATCH] KVM: arm64: vgic: " Yu Zhe
2022-03-29 10:20 ` Yu Zhe
2022-03-29 10:20 ` Yu Zhe
2022-04-06 13:22 ` Marc Zyngier
2022-04-06 13:22 ` Marc Zyngier
2022-04-06 13:22 ` Marc Zyngier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220329112141.GZ3293@kadam \
--to=dan.carpenter@oracle.com \
--cc=alexandru.elisei@arm.com \
--cc=catalin.marinas@arm.com \
--cc=james.morse@arm.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liqiong@nfschina.com \
--cc=maz@kernel.org \
--cc=suzuki.poulose@arm.com \
--cc=will@kernel.org \
--cc=yuzhe@nfschina.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.