From: Christoph Hellwig <hch@lst.de>
To: David Hildenbrand <david@redhat.com>
Cc: Alex Sierra <alex.sierra@amd.com>,
rcampbell@nvidia.com, willy@infradead.org,
Felix.Kuehling@amd.com, apopple@nvidia.com,
amd-gfx@lists.freedesktop.org, linux-xfs@vger.kernel.org,
linux-mm@kvack.org, jglisse@redhat.com,
dri-devel@lists.freedesktop.org, jgg@nvidia.com,
akpm@linux-foundation.org, linux-ext4@vger.kernel.org,
Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH v2 1/3] mm: add vm_normal_lru_pages for LRU handled pages only
Date: Thu, 31 Mar 2022 10:57:53 +0200 [thread overview]
Message-ID: <20220331085753.GA22487@lst.de> (raw)
In-Reply-To: <709b459a-3c71-49b1-7ac1-3144ae0fa89a@redhat.com>
On Thu, Mar 31, 2022 at 10:55:13AM +0200, David Hildenbrand wrote:
> > Why can't this deal with ZONE_DEVICE pages? It certainly has
> > nothing do with a LRU I think. In fact being able to have
> > stats that count say the number of device pages here would
> > probably be useful at some point.
> >
> > In general I find the vm_normal_lru_page vs vm_normal_page
> > API highly confusing. An explicit check for zone device pages
> > in the dozen or so spots that care has a much better documentation
> > value, especially if accompanied by comments where it isn't entirely
> > obvious.
>
> What's your thought on FOLL_LRU?
Also a bit confusing, but inbetween all these FOLL_ flags it doesn't
really matter any more.
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: David Hildenbrand <david@redhat.com>
Cc: Christoph Hellwig <hch@lst.de>, Alex Sierra <alex.sierra@amd.com>,
jgg@nvidia.com, Felix.Kuehling@amd.com, linux-mm@kvack.org,
rcampbell@nvidia.com, linux-ext4@vger.kernel.org,
linux-xfs@vger.kernel.org, amd-gfx@lists.freedesktop.org,
dri-devel@lists.freedesktop.org, jglisse@redhat.com,
apopple@nvidia.com, willy@infradead.org,
akpm@linux-foundation.org
Subject: Re: [PATCH v2 1/3] mm: add vm_normal_lru_pages for LRU handled pages only
Date: Thu, 31 Mar 2022 10:57:53 +0200 [thread overview]
Message-ID: <20220331085753.GA22487@lst.de> (raw)
In-Reply-To: <709b459a-3c71-49b1-7ac1-3144ae0fa89a@redhat.com>
On Thu, Mar 31, 2022 at 10:55:13AM +0200, David Hildenbrand wrote:
> > Why can't this deal with ZONE_DEVICE pages? It certainly has
> > nothing do with a LRU I think. In fact being able to have
> > stats that count say the number of device pages here would
> > probably be useful at some point.
> >
> > In general I find the vm_normal_lru_page vs vm_normal_page
> > API highly confusing. An explicit check for zone device pages
> > in the dozen or so spots that care has a much better documentation
> > value, especially if accompanied by comments where it isn't entirely
> > obvious.
>
> What's your thought on FOLL_LRU?
Also a bit confusing, but inbetween all these FOLL_ flags it doesn't
really matter any more.
next prev parent reply other threads:[~2022-03-31 13:08 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-30 21:25 [PATCH v2 0/3] split vm_normal_pages for LRU and non-LRU handling Alex Sierra
2022-03-30 21:25 ` Alex Sierra
2022-03-30 21:25 ` [PATCH v2 1/3] mm: add vm_normal_lru_pages for LRU handled pages only Alex Sierra
2022-03-30 21:25 ` Alex Sierra
2022-03-31 8:53 ` Christoph Hellwig
2022-03-31 8:53 ` Christoph Hellwig
2022-03-31 8:55 ` David Hildenbrand
2022-03-31 8:55 ` David Hildenbrand
2022-03-31 8:57 ` Christoph Hellwig [this message]
2022-03-31 8:57 ` Christoph Hellwig
2022-04-01 20:08 ` Felix Kuehling
2022-04-01 20:08 ` Felix Kuehling
2022-04-04 17:38 ` Jason Gunthorpe
2022-04-04 17:38 ` Jason Gunthorpe
2022-04-04 19:22 ` Sierra Guiza, Alejandro (Alex)
2022-04-04 19:22 ` Sierra Guiza, Alejandro (Alex)
2022-03-30 21:25 ` [PATCH v2 2/3] tools: add more gup configs to hmm_gup selftests Alex Sierra
2022-03-30 21:25 ` Alex Sierra
2022-03-30 21:25 ` [PATCH v2 3/3] tools: add selftests to hmm for COW in device memory Alex Sierra
2022-03-30 21:25 ` Alex Sierra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220331085753.GA22487@lst.de \
--to=hch@lst.de \
--cc=Felix.Kuehling@amd.com \
--cc=akpm@linux-foundation.org \
--cc=alex.sierra@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=apopple@nvidia.com \
--cc=david@redhat.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=jgg@nvidia.com \
--cc=jglisse@redhat.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-xfs@vger.kernel.org \
--cc=rcampbell@nvidia.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.