From: Vladimir Sementsov-Ogievskiy <vladimir.sementsov-ogievskiy@openvz.org>
To: qemu-block@nongnu.org
Cc: kwolf@redhat.com, v.sementsov-og@mail.ru,
nikita.lapshin@virtuozzo.com, eblake@redhat.com,
qemu-devel@nongnu.org, hreitz@redhat.com, vsementsov@openvz.org,
jsnow@redhat.com
Subject: [PATCH v3 1/3] block: block_dirty_bitmap_merge(): fix error path
Date: Fri, 1 Apr 2022 13:08:02 +0300 [thread overview]
Message-ID: <20220401100804.315728-2-vsementsov@openvz.org> (raw)
In-Reply-To: <20220401100804.315728-1-vsementsov@openvz.org>
At the end we ignore failure of bdrv_merge_dirty_bitmap() and report
success. And still set errp. That's wrong.
Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@openvz.org>
Reviewed-by: Nikita Lapshin <nikita.lapshin@virtuozzo.com>
---
block/monitor/bitmap-qmp-cmds.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/block/monitor/bitmap-qmp-cmds.c b/block/monitor/bitmap-qmp-cmds.c
index 8e35616c2e..4db704c015 100644
--- a/block/monitor/bitmap-qmp-cmds.c
+++ b/block/monitor/bitmap-qmp-cmds.c
@@ -309,7 +309,10 @@ BdrvDirtyBitmap *block_dirty_bitmap_merge(const char *node, const char *target,
}
/* Merge into dst; dst is unchanged on failure. */
- bdrv_merge_dirty_bitmap(dst, anon, backup, errp);
+ if (!bdrv_merge_dirty_bitmap(dst, anon, backup, errp)) {
+ dst = NULL;
+ goto out;
+ }
out:
bdrv_release_dirty_bitmap(anon);
--
2.35.1
next prev parent reply other threads:[~2022-04-01 10:12 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-01 10:08 [PATCH v3 0/3] block/dirty-bitmaps: fix and improve bitmap merge Vladimir Sementsov-Ogievskiy
2022-04-01 10:08 ` Vladimir Sementsov-Ogievskiy [this message]
2022-05-03 9:27 ` [PATCH v3 1/3] block: block_dirty_bitmap_merge(): fix error path Kevin Wolf
2022-04-01 10:08 ` [PATCH v3 2/3] block: improve block_dirty_bitmap_merge(): don't allocate extra bitmap Vladimir Sementsov-Ogievskiy
2022-05-03 9:24 ` Kevin Wolf
2022-05-17 10:36 ` Vladimir Sementsov-Ogievskiy
2022-04-01 10:08 ` [PATCH v3 3/3] block: simplify handling of try to merge different sized bitmaps Vladimir Sementsov-Ogievskiy
2022-05-03 9:34 ` Kevin Wolf
2022-04-01 15:08 ` [PATCH v3 0/3] block/dirty-bitmaps: fix and improve bitmap merge Hanna Reitz
2022-04-01 20:17 ` Eric Blake
2022-04-01 21:06 ` Vladimir Sementsov-Ogievskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220401100804.315728-2-vsementsov@openvz.org \
--to=vladimir.sementsov-ogievskiy@openvz.org \
--cc=eblake@redhat.com \
--cc=hreitz@redhat.com \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=nikita.lapshin@virtuozzo.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=v.sementsov-og@mail.ru \
--cc=vsementsov@openvz.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.