From: Kevin Wolf <kwolf@redhat.com>
To: Vladimir Sementsov-Ogievskiy <vladimir.sementsov-ogievskiy@openvz.org>
Cc: qemu-block@nongnu.org, qemu-devel@nongnu.org, eblake@redhat.com,
hreitz@redhat.com, v.sementsov-og@mail.ru, jsnow@redhat.com,
vsementsov@openvz.org, nikita.lapshin@virtuozzo.com
Subject: Re: [PATCH v3 3/3] block: simplify handling of try to merge different sized bitmaps
Date: Tue, 3 May 2022 11:34:32 +0200 [thread overview]
Message-ID: <YnD3KJbZICgN7vkV@redhat.com> (raw)
In-Reply-To: <20220401100804.315728-4-vsementsov@openvz.org>
Am 01.04.2022 um 12:08 hat Vladimir Sementsov-Ogievskiy geschrieben:
> We have too much logic to simply check that bitmaps are of the same
> size. Let's just define that hbitmap_merge() and
> bdrv_dirty_bitmap_merge_internal() require their argument bitmaps be of
> same size, this simplifies things.
>
> Let's look through the callers:
>
> For backup_init_bcs_bitmap() we already assert that merge can't fail.
>
> In bdrv_reclaim_dirty_bitmap_locked() we gracefully handle the error
> that can't happen: successor always has same size as its parent, drop
> this logic.
>
> In bdrv_merge_dirty_bitmap() we already has assertion and separate
> check. Make the check explicit and improve error message.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@openvz.org>
> Reviewed-by: Nikita Lapshin <nikita.lapshin@virtuozzo.com>
Reviewed-by: Kevin Wolf <kwolf@redhat.com>
next prev parent reply other threads:[~2022-05-03 9:37 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-01 10:08 [PATCH v3 0/3] block/dirty-bitmaps: fix and improve bitmap merge Vladimir Sementsov-Ogievskiy
2022-04-01 10:08 ` [PATCH v3 1/3] block: block_dirty_bitmap_merge(): fix error path Vladimir Sementsov-Ogievskiy
2022-05-03 9:27 ` Kevin Wolf
2022-04-01 10:08 ` [PATCH v3 2/3] block: improve block_dirty_bitmap_merge(): don't allocate extra bitmap Vladimir Sementsov-Ogievskiy
2022-05-03 9:24 ` Kevin Wolf
2022-05-17 10:36 ` Vladimir Sementsov-Ogievskiy
2022-04-01 10:08 ` [PATCH v3 3/3] block: simplify handling of try to merge different sized bitmaps Vladimir Sementsov-Ogievskiy
2022-05-03 9:34 ` Kevin Wolf [this message]
2022-04-01 15:08 ` [PATCH v3 0/3] block/dirty-bitmaps: fix and improve bitmap merge Hanna Reitz
2022-04-01 20:17 ` Eric Blake
2022-04-01 21:06 ` Vladimir Sementsov-Ogievskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YnD3KJbZICgN7vkV@redhat.com \
--to=kwolf@redhat.com \
--cc=eblake@redhat.com \
--cc=hreitz@redhat.com \
--cc=jsnow@redhat.com \
--cc=nikita.lapshin@virtuozzo.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=v.sementsov-og@mail.ru \
--cc=vladimir.sementsov-ogievskiy@openvz.org \
--cc=vsementsov@openvz.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.