* [PATCH] drm: bridge: mcde_dsi: Drop explicit bridge remove
@ 2022-04-01 15:05 Jagan Teki
2022-04-01 20:32 ` Linus Walleij
0 siblings, 1 reply; 3+ messages in thread
From: Jagan Teki @ 2022-04-01 15:05 UTC (permalink / raw)
To: Andrzej Hajda, Neil Armstrong, Robert Foss, Laurent Pinchart
Cc: Sam Ravnborg, dri-devel, Jagan Teki, linux-amarula, Maxime Ripard
This driver has been changed to use the resource managed
devm_drm_of_get_bridge() to get bridge from ->bind(), it's
unnecessary to call drm_of_panel_bridge_remove() to remove the
bridge from ->unbind() as devm_drm_of_get_bridge()
is automatically remove the bridge when @dev is unbound.
Drop it the drm_bridge_remove().
Cc: Linus Walleij <linus.walleij@linaro.org>
Reported-by: Maxime Ripard <maxime@cerno.tech>
Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
---
drivers/gpu/drm/mcde/mcde_dsi.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/gpu/drm/mcde/mcde_dsi.c b/drivers/gpu/drm/mcde/mcde_dsi.c
index 083a4728654d..960b49ea2ee5 100644
--- a/drivers/gpu/drm/mcde/mcde_dsi.c
+++ b/drivers/gpu/drm/mcde/mcde_dsi.c
@@ -1122,7 +1122,6 @@ static void mcde_dsi_unbind(struct device *dev, struct device *master,
{
struct mcde_dsi *d = dev_get_drvdata(dev);
- drm_bridge_remove(d->bridge_out);
regmap_update_bits(d->prcmu, PRCM_DSI_SW_RESET,
PRCM_DSI_SW_RESET_DSI0_SW_RESETN, 0);
}
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] drm: bridge: mcde_dsi: Drop explicit bridge remove
2022-04-01 15:05 [PATCH] drm: bridge: mcde_dsi: Drop explicit bridge remove Jagan Teki
@ 2022-04-01 20:32 ` Linus Walleij
2022-04-04 9:15 ` Robert Foss
0 siblings, 1 reply; 3+ messages in thread
From: Linus Walleij @ 2022-04-01 20:32 UTC (permalink / raw)
To: Jagan Teki
Cc: Neil Armstrong, Robert Foss, dri-devel, Laurent Pinchart,
Andrzej Hajda, Sam Ravnborg, linux-amarula, Maxime Ripard
On Fri, Apr 1, 2022 at 5:05 PM Jagan Teki <jagan@amarulasolutions.com> wrote:
> This driver has been changed to use the resource managed
> devm_drm_of_get_bridge() to get bridge from ->bind(), it's
> unnecessary to call drm_of_panel_bridge_remove() to remove the
> bridge from ->unbind() as devm_drm_of_get_bridge()
> is automatically remove the bridge when @dev is unbound.
>
> Drop it the drm_bridge_remove().
>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Reported-by: Maxime Ripard <maxime@cerno.tech>
> Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-04-04 9:16 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-04-01 15:05 [PATCH] drm: bridge: mcde_dsi: Drop explicit bridge remove Jagan Teki
2022-04-01 20:32 ` Linus Walleij
2022-04-04 9:15 ` Robert Foss
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.