* + lib-remove-back_str-initialization.patch added to -mm tree
@ 2022-04-05 18:17 Andrew Morton
0 siblings, 0 replies; only message in thread
From: Andrew Morton @ 2022-04-05 18:17 UTC (permalink / raw)
To: mm-commits, ndesaulniers, nathan, trix, akpm
The patch titled
Subject: lib: remove back_str initialization
has been added to the -mm tree. Its filename is
lib-remove-back_str-initialization.patch
This patch should soon appear at
https://ozlabs.org/~akpm/mmots/broken-out/lib-remove-back_str-initialization.patch
and later at
https://ozlabs.org/~akpm/mmotm/broken-out/lib-remove-back_str-initialization.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/process/submit-checklist.rst when testing your code ***
The -mm tree is included into linux-next and is updated
there every 3-4 working days
------------------------------------------------------
From: Tom Rix <trix@redhat.com>
Subject: lib: remove back_str initialization
Clang static analysis reports this false positive
glob.c:48:32: warning: Assigned value is garbage
or undefined
char const *back_pat = NULL, *back_str = back_str;
^~~~~~~~ ~~~~~~~~
back_str is set after back_pat and it's use is protected by the !back_pat
check. It is not necessary to initialize back_str, so remove the
initialization.
Link: https://lkml.kernel.org/r/20220402131546.3383578-1-trix@redhat.com
Signed-off-by: Tom Rix <trix@redhat.com>
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
Cc: Nathan Chancellor <nathan@kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
lib/glob.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/lib/glob.c~lib-remove-back_str-initialization
+++ a/lib/glob.c
@@ -45,7 +45,7 @@ bool __pure glob_match(char const *pat,
* (no exception for /), it can be easily proved that there's
* never a need to backtrack multiple levels.
*/
- char const *back_pat = NULL, *back_str = back_str;
+ char const *back_pat = NULL, *back_str;
/*
* Loop over each token (character or class) in pat, matching
_
Patches currently in -mm which might be from trix@redhat.com are
lib-remove-back_str-initialization.patch
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2022-04-06 1:56 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-04-05 18:17 + lib-remove-back_str-initialization.patch added to -mm tree Andrew Morton
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.