* [Intel-gfx] [PATCH] drm/i915: Fix skl_pcode_try_request function
@ 2022-04-05 10:41 Stanislav Lisovskiy
2022-04-05 13:58 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
` (4 more replies)
0 siblings, 5 replies; 10+ messages in thread
From: Stanislav Lisovskiy @ 2022-04-05 10:41 UTC (permalink / raw)
To: intel-gfx
Currently skl_pcode_try_request function doesn't
properly handle return value it gets from
snb_pcode_rw, but treats status != 0 as success,
returning true, which basically doesn't allow
to use retry/timeout mechanisms if PCode happens
to be busy and returns EGAIN or some other status
code not equal to 0.
We saw this on real hw and also tried simulating this
by always returning -EAGAIN from snb_pcode_rw for 6 times, which
currently will just result in false success, while it should
have tried until timeout is reached:
[ 22.357729] i915 0000:00:02.0: [drm:intel_cdclk_dump_config [i915]] Changing CDCLK to
307200 kHz, VCO 614400 kHz, ref 38400 kHz, bypass 19200 kHz, voltage level 0
[ 22.357831] i915 0000:00:02.0: [drm:__snb_pcode_rw [i915]] Returning EAGAIN retry 1
[ 22.357892] i915 0000:00:02.0: [drm:skl_pcode_request [i915]] Success, exiting
[ 22.357936] i915 0000:00:02.0: [drm] ERROR Failed to inform PCU about cdclk change (err -11, freq 307200)
We see en error because higher level api, still notices that status was wrong,
however we still did try only once.
We fix it by requiring _both_ the status to be 0 and
request/reply match for success(true) and function
should return failure(false) if either status turns
out to be EAGAIN, EBUSY or whatever or reply/request
masks do not match.
So now we see this in the logs:
[ 22.318667] i915 0000:00:02.0: [drm:intel_cdclk_dump_config [i915]] Changing CDCLK to
307200 kHz, VCO 614400 kHz, ref 38400 kHz, bypass 19200 kHz, voltage level 0
[ 22.318782] i915 0000:00:02.0: [drm:__snb_pcode_rw [i915]] Returning EAGAIN retry 1
[ 22.318849] i915 0000:00:02.0: [drm:__snb_pcode_rw [i915]] Returning EAGAIN retry 2
[ 22.319006] i915 0000:00:02.0: [drm:__snb_pcode_rw [i915]] Returning EAGAIN retry 3
[ 22.319091] i915 0000:00:02.0: [drm:__snb_pcode_rw [i915]] Returning EAGAIN retry 4
[ 22.319158] i915 0000:00:02.0: [drm:__snb_pcode_rw [i915]] Returning EAGAIN retry 5
[ 22.319224] i915 0000:00:02.0: [drm:__snb_pcode_rw [i915]] Returning EAGAIN retry 6
Signed-off-by: Stanislav Lisovskiy <stanislav.lisovskiy@intel.com>
---
drivers/gpu/drm/i915/intel_pcode.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/intel_pcode.c b/drivers/gpu/drm/i915/intel_pcode.c
index 391a37492ce5..fb6c43e8a02f 100644
--- a/drivers/gpu/drm/i915/intel_pcode.c
+++ b/drivers/gpu/drm/i915/intel_pcode.c
@@ -136,7 +136,7 @@ static bool skl_pcode_try_request(struct drm_i915_private *i915, u32 mbox,
{
*status = __snb_pcode_rw(i915, mbox, &request, NULL, 500, 0, true);
- return *status || ((request & reply_mask) == reply);
+ return (*status == 0) && ((request & reply_mask) == reply);
}
/**
--
2.24.1.485.gad05a3d8e5
^ permalink raw reply related [flat|nested] 10+ messages in thread* [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Fix skl_pcode_try_request function 2022-04-05 10:41 [Intel-gfx] [PATCH] drm/i915: Fix skl_pcode_try_request function Stanislav Lisovskiy @ 2022-04-05 13:58 ` Patchwork 2022-04-05 14:03 ` [Intel-gfx] ✗ Fi.CI.DOCS: " Patchwork ` (3 subsequent siblings) 4 siblings, 0 replies; 10+ messages in thread From: Patchwork @ 2022-04-05 13:58 UTC (permalink / raw) To: Stanislav Lisovskiy; +Cc: intel-gfx == Series Details == Series: drm/i915: Fix skl_pcode_try_request function URL : https://patchwork.freedesktop.org/series/102186/ State : warning == Summary == $ dim checkpatch origin/drm-tip 0a861cc88f76 drm/i915: Fix skl_pcode_try_request function -:25: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line) #25: We see en error because higher level api, still notices that status was wrong, total: 0 errors, 1 warnings, 0 checks, 8 lines checked ^ permalink raw reply [flat|nested] 10+ messages in thread
* [Intel-gfx] ✗ Fi.CI.DOCS: warning for drm/i915: Fix skl_pcode_try_request function 2022-04-05 10:41 [Intel-gfx] [PATCH] drm/i915: Fix skl_pcode_try_request function Stanislav Lisovskiy 2022-04-05 13:58 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork @ 2022-04-05 14:03 ` Patchwork 2022-04-05 14:28 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork ` (2 subsequent siblings) 4 siblings, 0 replies; 10+ messages in thread From: Patchwork @ 2022-04-05 14:03 UTC (permalink / raw) To: Stanislav Lisovskiy; +Cc: intel-gfx == Series Details == Series: drm/i915: Fix skl_pcode_try_request function URL : https://patchwork.freedesktop.org/series/102186/ State : warning == Summary == $ make htmldocs 2>&1 > /dev/null | grep i915 ./drivers/gpu/drm/i915/gem/i915_gem_context_types.h:417: warning: Function parameter or member 'client_link' not described in 'i915_gem_context' ^ permalink raw reply [flat|nested] 10+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Fix skl_pcode_try_request function 2022-04-05 10:41 [Intel-gfx] [PATCH] drm/i915: Fix skl_pcode_try_request function Stanislav Lisovskiy 2022-04-05 13:58 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork 2022-04-05 14:03 ` [Intel-gfx] ✗ Fi.CI.DOCS: " Patchwork @ 2022-04-05 14:28 ` Patchwork 2022-04-05 18:39 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork 2022-04-05 21:51 ` [Intel-gfx] [PATCH] " Govindapillai, Vinod 4 siblings, 0 replies; 10+ messages in thread From: Patchwork @ 2022-04-05 14:28 UTC (permalink / raw) To: Stanislav Lisovskiy; +Cc: intel-gfx [-- Attachment #1: Type: text/plain, Size: 9238 bytes --] == Series Details == Series: drm/i915: Fix skl_pcode_try_request function URL : https://patchwork.freedesktop.org/series/102186/ State : success == Summary == CI Bug Log - changes from CI_DRM_11456 -> Patchwork_22780 ==================================================== Summary ------- **SUCCESS** No regressions found. External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22780/index.html Participating hosts (44 -> 44) ------------------------------ Additional (4): fi-kbl-soraka bat-rpls-1 fi-icl-u2 fi-tgl-u2 Missing (4): fi-bsw-cyan shard-tglu fi-bdw-samus fi-pnv-d510 Known issues ------------ Here are the changes found in Patchwork_22780 that come from known issues: ### IGT changes ### #### Issues hit #### * igt@amdgpu/amd_cs_nop@fork-gfx0: - fi-icl-u2: NOTRUN -> [SKIP][1] ([fdo#109315]) +17 similar issues [1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22780/fi-icl-u2/igt@amdgpu/amd_cs_nop@fork-gfx0.html * igt@gem_exec_fence@basic-busy@bcs0: - fi-kbl-soraka: NOTRUN -> [SKIP][2] ([fdo#109271]) +9 similar issues [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22780/fi-kbl-soraka/igt@gem_exec_fence@basic-busy@bcs0.html * igt@gem_huc_copy@huc-copy: - fi-tgl-u2: NOTRUN -> [SKIP][3] ([i915#2190]) [3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22780/fi-tgl-u2/igt@gem_huc_copy@huc-copy.html - fi-kbl-soraka: NOTRUN -> [SKIP][4] ([fdo#109271] / [i915#2190]) [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22780/fi-kbl-soraka/igt@gem_huc_copy@huc-copy.html - fi-icl-u2: NOTRUN -> [SKIP][5] ([i915#2190]) [5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22780/fi-icl-u2/igt@gem_huc_copy@huc-copy.html * igt@gem_lmem_swapping@parallel-random-engines: - fi-icl-u2: NOTRUN -> [SKIP][6] ([i915#4613]) +3 similar issues [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22780/fi-icl-u2/igt@gem_lmem_swapping@parallel-random-engines.html - fi-kbl-soraka: NOTRUN -> [SKIP][7] ([fdo#109271] / [i915#4613]) +3 similar issues [7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22780/fi-kbl-soraka/igt@gem_lmem_swapping@parallel-random-engines.html * igt@gem_lmem_swapping@verify-random: - fi-tgl-u2: NOTRUN -> [SKIP][8] ([i915#4613]) +3 similar issues [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22780/fi-tgl-u2/igt@gem_lmem_swapping@verify-random.html * igt@i915_selftest@live@gt_pm: - fi-kbl-soraka: NOTRUN -> [DMESG-FAIL][9] ([i915#1886]) [9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22780/fi-kbl-soraka/igt@i915_selftest@live@gt_pm.html * igt@i915_selftest@live@hangcheck: - fi-hsw-4770: [PASS][10] -> [INCOMPLETE][11] ([i915#4785]) [10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11456/fi-hsw-4770/igt@i915_selftest@live@hangcheck.html [11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22780/fi-hsw-4770/igt@i915_selftest@live@hangcheck.html * igt@kms_busy@basic@flip: - fi-tgl-u2: NOTRUN -> [DMESG-WARN][12] ([i915#402]) [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22780/fi-tgl-u2/igt@kms_busy@basic@flip.html * igt@kms_chamelium@common-hpd-after-suspend: - fi-tgl-u2: NOTRUN -> [SKIP][13] ([fdo#109284] / [fdo#111827]) +8 similar issues [13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22780/fi-tgl-u2/igt@kms_chamelium@common-hpd-after-suspend.html * igt@kms_chamelium@dp-edid-read: - fi-kbl-soraka: NOTRUN -> [SKIP][14] ([fdo#109271] / [fdo#111827]) +8 similar issues [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22780/fi-kbl-soraka/igt@kms_chamelium@dp-edid-read.html * igt@kms_chamelium@hdmi-hpd-fast: - fi-icl-u2: NOTRUN -> [SKIP][15] ([fdo#111827]) +8 similar issues [15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22780/fi-icl-u2/igt@kms_chamelium@hdmi-hpd-fast.html * igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic: - fi-tgl-u2: NOTRUN -> [SKIP][16] ([i915#4103]) +1 similar issue [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22780/fi-tgl-u2/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic.html - fi-icl-u2: NOTRUN -> [SKIP][17] ([fdo#109278]) +2 similar issues [17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22780/fi-icl-u2/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic.html * igt@kms_force_connector_basic@force-load-detect: - fi-tgl-u2: NOTRUN -> [SKIP][18] ([fdo#109285]) [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22780/fi-tgl-u2/igt@kms_force_connector_basic@force-load-detect.html - fi-icl-u2: NOTRUN -> [SKIP][19] ([fdo#109285]) [19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22780/fi-icl-u2/igt@kms_force_connector_basic@force-load-detect.html * igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d: - fi-kbl-soraka: NOTRUN -> [SKIP][20] ([fdo#109271] / [i915#533]) [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22780/fi-kbl-soraka/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d.html * igt@kms_setmode@basic-clone-single-crtc: - fi-tgl-u2: NOTRUN -> [SKIP][21] ([i915#3555]) [21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22780/fi-tgl-u2/igt@kms_setmode@basic-clone-single-crtc.html - fi-icl-u2: NOTRUN -> [SKIP][22] ([i915#3555]) [22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22780/fi-icl-u2/igt@kms_setmode@basic-clone-single-crtc.html * igt@prime_vgem@basic-userptr: - fi-icl-u2: NOTRUN -> [SKIP][23] ([i915#3301]) [23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22780/fi-icl-u2/igt@prime_vgem@basic-userptr.html * igt@runner@aborted: - fi-hsw-4770: NOTRUN -> [FAIL][24] ([fdo#109271] / [i915#1436] / [i915#2722] / [i915#4312]) [24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22780/fi-hsw-4770/igt@runner@aborted.html #### Possible fixes #### * igt@i915_selftest@live@gt_engines: - bat-dg1-6: [INCOMPLETE][25] ([i915#4418]) -> [PASS][26] [25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11456/bat-dg1-6/igt@i915_selftest@live@gt_engines.html [26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22780/bat-dg1-6/igt@i915_selftest@live@gt_engines.html * igt@i915_selftest@live@gt_pm: - fi-tgl-1115g4: [DMESG-FAIL][27] ([i915#3987]) -> [PASS][28] [27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11456/fi-tgl-1115g4/igt@i915_selftest@live@gt_pm.html [28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22780/fi-tgl-1115g4/igt@i915_selftest@live@gt_pm.html * igt@kms_busy@basic@flip: - {bat-adlp-6}: [DMESG-WARN][29] ([i915#3576]) -> [PASS][30] [29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11456/bat-adlp-6/igt@kms_busy@basic@flip.html [30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22780/bat-adlp-6/igt@kms_busy@basic@flip.html {name}: This element is suppressed. This means it is ignored when computing the status of the difference (SUCCESS, WARNING, or FAILURE). [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271 [fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278 [fdo#109284]: https://bugs.freedesktop.org/show_bug.cgi?id=109284 [fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285 [fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315 [fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827 [i915#1436]: https://gitlab.freedesktop.org/drm/intel/issues/1436 [i915#1886]: https://gitlab.freedesktop.org/drm/intel/issues/1886 [i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190 [i915#2722]: https://gitlab.freedesktop.org/drm/intel/issues/2722 [i915#3301]: https://gitlab.freedesktop.org/drm/intel/issues/3301 [i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555 [i915#3576]: https://gitlab.freedesktop.org/drm/intel/issues/3576 [i915#3987]: https://gitlab.freedesktop.org/drm/intel/issues/3987 [i915#402]: https://gitlab.freedesktop.org/drm/intel/issues/402 [i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103 [i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312 [i915#4418]: https://gitlab.freedesktop.org/drm/intel/issues/4418 [i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613 [i915#4785]: https://gitlab.freedesktop.org/drm/intel/issues/4785 [i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533 Build changes ------------- * Linux: CI_DRM_11456 -> Patchwork_22780 CI-20190529: 20190529 CI_DRM_11456: 0059060adfc9738fffdc0e03629d480579e3f7a2 @ git://anongit.freedesktop.org/gfx-ci/linux IGT_6410: cc359d5d2d3fc8be50340ba0379bacaf5c37bc5f @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git Patchwork_22780: 0a861cc88f762b8cf469cf7ac3bc0d585c40199e @ git://anongit.freedesktop.org/gfx-ci/linux == Linux commits == 0a861cc88f76 drm/i915: Fix skl_pcode_try_request function == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22780/index.html [-- Attachment #2: Type: text/html, Size: 11327 bytes --] ^ permalink raw reply [flat|nested] 10+ messages in thread
* [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Fix skl_pcode_try_request function 2022-04-05 10:41 [Intel-gfx] [PATCH] drm/i915: Fix skl_pcode_try_request function Stanislav Lisovskiy ` (2 preceding siblings ...) 2022-04-05 14:28 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork @ 2022-04-05 18:39 ` Patchwork 2022-04-05 21:51 ` [Intel-gfx] [PATCH] " Govindapillai, Vinod 4 siblings, 0 replies; 10+ messages in thread From: Patchwork @ 2022-04-05 18:39 UTC (permalink / raw) To: Stanislav Lisovskiy; +Cc: intel-gfx [-- Attachment #1: Type: text/plain, Size: 30268 bytes --] == Series Details == Series: drm/i915: Fix skl_pcode_try_request function URL : https://patchwork.freedesktop.org/series/102186/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11456_full -> Patchwork_22780_full ==================================================== Summary ------- **FAILURE** Serious unknown changes coming with Patchwork_22780_full absolutely need to be verified manually. If you think the reported changes have nothing to do with the changes introduced in Patchwork_22780_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI. Participating hosts (13 -> 12) ------------------------------ Missing (1): shard-dg1 Possible new issues ------------------- Here are the unknown changes that may have been introduced in Patchwork_22780_full: ### IGT changes ### #### Possible regressions #### * igt@kms_flip@busy-flip@c-edp1: - shard-skl: [PASS][1] -> [FAIL][2] [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11456/shard-skl6/igt@kms_flip@busy-flip@c-edp1.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22780/shard-skl5/igt@kms_flip@busy-flip@c-edp1.html * igt@sysfs_heartbeat_interval@mixed@bcs0: - shard-skl: NOTRUN -> [INCOMPLETE][3] [3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22780/shard-skl3/igt@sysfs_heartbeat_interval@mixed@bcs0.html #### Suppressed #### The following results come from untrusted machines, tests, or statuses. They do not affect the overall result. * igt@gem_exec_flush@basic-uc-pro-default: - {shard-rkl}: NOTRUN -> [INCOMPLETE][4] [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22780/shard-rkl-5/igt@gem_exec_flush@basic-uc-pro-default.html Known issues ------------ Here are the changes found in Patchwork_22780_full that come from known issues: ### CI changes ### #### Possible fixes #### * boot: - shard-skl: ([PASS][5], [PASS][6], [PASS][7], [PASS][8], [PASS][9], [PASS][10], [PASS][11], [PASS][12], [PASS][13], [PASS][14], [PASS][15], [PASS][16], [FAIL][17], [FAIL][18], [FAIL][19], [PASS][20], [PASS][21], [PASS][22], [PASS][23]) ([i915#5032]) -> ([PASS][24], [PASS][25], [PASS][26], [PASS][27], [PASS][28], [PASS][29], [PASS][30], [PASS][31], [PASS][32], [PASS][33], [PASS][34], [PASS][35], [PASS][36], [PASS][37], [PASS][38], [PASS][39], [PASS][40], [PASS][41], [PASS][42]) [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11456/shard-skl9/boot.html [6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11456/shard-skl9/boot.html [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11456/shard-skl8/boot.html [8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11456/shard-skl8/boot.html [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11456/shard-skl7/boot.html [10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11456/shard-skl7/boot.html [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11456/shard-skl6/boot.html [12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11456/shard-skl6/boot.html [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11456/shard-skl5/boot.html [14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11456/shard-skl5/boot.html [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11456/shard-skl4/boot.html [16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11456/shard-skl4/boot.html [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11456/shard-skl3/boot.html [18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11456/shard-skl3/boot.html [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11456/shard-skl3/boot.html [20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11456/shard-skl1/boot.html [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11456/shard-skl1/boot.html [22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11456/shard-skl10/boot.html [23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11456/shard-skl10/boot.html [24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22780/shard-skl9/boot.html [25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22780/shard-skl9/boot.html [26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22780/shard-skl8/boot.html [27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22780/shard-skl8/boot.html [28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22780/shard-skl7/boot.html [29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22780/shard-skl7/boot.html [30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22780/shard-skl6/boot.html [31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22780/shard-skl5/boot.html [32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22780/shard-skl5/boot.html [33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22780/shard-skl4/boot.html [34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22780/shard-skl4/boot.html [35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22780/shard-skl3/boot.html [36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22780/shard-skl3/boot.html [37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22780/shard-skl2/boot.html [38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22780/shard-skl2/boot.html [39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22780/shard-skl1/boot.html [40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22780/shard-skl1/boot.html [41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22780/shard-skl10/boot.html [42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22780/shard-skl10/boot.html ### IGT changes ### #### Issues hit #### * igt@drm_mm@all@replace: - shard-skl: [PASS][43] -> [INCOMPLETE][44] ([i915#1373]) [43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11456/shard-skl6/igt@drm_mm@all@replace.html [44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22780/shard-skl5/igt@drm_mm@all@replace.html * igt@gem_ccs@ctrl-surf-copy-new-ctx: - shard-iclb: NOTRUN -> [SKIP][45] ([i915#5327]) [45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22780/shard-iclb5/igt@gem_ccs@ctrl-surf-copy-new-ctx.html * igt@gem_create@create-massive: - shard-apl: NOTRUN -> [DMESG-WARN][46] ([i915#4991]) [46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22780/shard-apl4/igt@gem_create@create-massive.html * igt@gem_ctx_param@set-priority-not-supported: - shard-iclb: NOTRUN -> [SKIP][47] ([fdo#109314]) [47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22780/shard-iclb5/igt@gem_ctx_param@set-priority-not-supported.html * igt@gem_eio@in-flight-suspend: - shard-apl: NOTRUN -> [DMESG-WARN][48] ([i915#180]) [48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22780/shard-apl6/igt@gem_eio@in-flight-suspend.html * igt@gem_eio@kms: - shard-tglb: [PASS][49] -> [FAIL][50] ([i915#232]) [49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11456/shard-tglb7/igt@gem_eio@kms.html [50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22780/shard-tglb2/igt@gem_eio@kms.html * igt@gem_exec_capture@pi@vcs0: - shard-skl: [PASS][51] -> [INCOMPLETE][52] ([i915#4547]) [51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11456/shard-skl7/igt@gem_exec_capture@pi@vcs0.html [52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22780/shard-skl9/igt@gem_exec_capture@pi@vcs0.html * igt@gem_exec_fair@basic-none@vecs0: - shard-apl: NOTRUN -> [FAIL][53] ([i915#2842]) [53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22780/shard-apl4/igt@gem_exec_fair@basic-none@vecs0.html * igt@gem_exec_fair@basic-pace-share@rcs0: - shard-glk: [PASS][54] -> [FAIL][55] ([i915#2842]) [54]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11456/shard-glk1/igt@gem_exec_fair@basic-pace-share@rcs0.html [55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22780/shard-glk2/igt@gem_exec_fair@basic-pace-share@rcs0.html * igt@gem_exec_fair@basic-pace@vcs1: - shard-kbl: [PASS][56] -> [FAIL][57] ([i915#2842]) +2 similar issues [56]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11456/shard-kbl4/igt@gem_exec_fair@basic-pace@vcs1.html [57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22780/shard-kbl7/igt@gem_exec_fair@basic-pace@vcs1.html * igt@gem_exec_params@rsvd2-dirt: - shard-iclb: NOTRUN -> [SKIP][58] ([fdo#109283]) [58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22780/shard-iclb5/igt@gem_exec_params@rsvd2-dirt.html * igt@gem_huc_copy@huc-copy: - shard-tglb: [PASS][59] -> [SKIP][60] ([i915#2190]) [59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11456/shard-tglb2/igt@gem_huc_copy@huc-copy.html [60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22780/shard-tglb7/igt@gem_huc_copy@huc-copy.html * igt@gem_lmem_swapping@heavy-random: - shard-iclb: NOTRUN -> [SKIP][61] ([i915#4613]) +1 similar issue [61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22780/shard-iclb6/igt@gem_lmem_swapping@heavy-random.html * igt@gem_lmem_swapping@heavy-verify-multi: - shard-skl: NOTRUN -> [SKIP][62] ([fdo#109271] / [i915#4613]) +2 similar issues [62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22780/shard-skl4/igt@gem_lmem_swapping@heavy-verify-multi.html * igt@gem_pxp@create-protected-buffer: - shard-iclb: NOTRUN -> [SKIP][63] ([i915#4270]) +2 similar issues [63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22780/shard-iclb6/igt@gem_pxp@create-protected-buffer.html * igt@gem_render_copy@yf-tiled-to-vebox-linear: - shard-iclb: NOTRUN -> [SKIP][64] ([i915#768]) +1 similar issue [64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22780/shard-iclb5/igt@gem_render_copy@yf-tiled-to-vebox-linear.html * igt@gem_set_tiling_vs_gtt: - shard-skl: [PASS][65] -> [DMESG-WARN][66] ([i915#1982]) [65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11456/shard-skl5/igt@gem_set_tiling_vs_gtt.html [66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22780/shard-skl9/igt@gem_set_tiling_vs_gtt.html * igt@gem_spin_batch@legacy@default: - shard-apl: [PASS][67] -> [FAIL][68] ([i915#2898]) [67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11456/shard-apl1/igt@gem_spin_batch@legacy@default.html [68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22780/shard-apl8/igt@gem_spin_batch@legacy@default.html * igt@gen7_exec_parse@chained-batch: - shard-iclb: NOTRUN -> [SKIP][69] ([fdo#109289]) +2 similar issues [69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22780/shard-iclb6/igt@gen7_exec_parse@chained-batch.html * igt@gen9_exec_parse@valid-registers: - shard-iclb: NOTRUN -> [SKIP][70] ([i915#2856]) +1 similar issue [70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22780/shard-iclb5/igt@gen9_exec_parse@valid-registers.html * igt@i915_pm_rc6_residency@rc6-idle: - shard-iclb: NOTRUN -> [WARN][71] ([i915#2684]) [71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22780/shard-iclb5/igt@i915_pm_rc6_residency@rc6-idle.html * igt@i915_pm_rpm@gem-mmap-type@gtt: - shard-iclb: [PASS][72] -> [INCOMPLETE][73] ([i915#5096]) [72]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11456/shard-iclb3/igt@i915_pm_rpm@gem-mmap-type@gtt.html [73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22780/shard-iclb4/igt@i915_pm_rpm@gem-mmap-type@gtt.html * igt@i915_selftest@live@gt_pm: - shard-skl: NOTRUN -> [DMESG-FAIL][74] ([i915#1886]) [74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22780/shard-skl3/igt@i915_selftest@live@gt_pm.html * igt@i915_selftest@live@hangcheck: - shard-snb: [PASS][75] -> [INCOMPLETE][76] ([i915#3921]) [75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11456/shard-snb5/igt@i915_selftest@live@hangcheck.html [76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22780/shard-snb4/igt@i915_selftest@live@hangcheck.html * igt@kms_big_fb@4-tiled-32bpp-rotate-0: - shard-iclb: NOTRUN -> [SKIP][77] ([i915#5286]) [77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22780/shard-iclb6/igt@kms_big_fb@4-tiled-32bpp-rotate-0.html * igt@kms_big_fb@linear-64bpp-rotate-90: - shard-skl: NOTRUN -> [SKIP][78] ([fdo#109271]) +265 similar issues [78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22780/shard-skl5/igt@kms_big_fb@linear-64bpp-rotate-90.html * igt@kms_big_fb@linear-8bpp-rotate-90: - shard-iclb: NOTRUN -> [SKIP][79] ([fdo#110725] / [fdo#111614]) +2 similar issues [79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22780/shard-iclb5/igt@kms_big_fb@linear-8bpp-rotate-90.html * igt@kms_big_fb@x-tiled-max-hw-stride-32bpp-rotate-0-async-flip: - shard-skl: NOTRUN -> [FAIL][80] ([i915#3743]) +1 similar issue [80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22780/shard-skl2/igt@kms_big_fb@x-tiled-max-hw-stride-32bpp-rotate-0-async-flip.html * igt@kms_big_fb@yf-tiled-64bpp-rotate-0: - shard-iclb: NOTRUN -> [SKIP][81] ([fdo#110723]) [81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22780/shard-iclb5/igt@kms_big_fb@yf-tiled-64bpp-rotate-0.html * igt@kms_big_fb@yf-tiled-max-hw-stride-32bpp-rotate-0-hflip-async-flip: - shard-skl: NOTRUN -> [SKIP][82] ([fdo#109271] / [i915#3777]) +5 similar issues [82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22780/shard-skl3/igt@kms_big_fb@yf-tiled-max-hw-stride-32bpp-rotate-0-hflip-async-flip.html * igt@kms_ccs@pipe-a-crc-sprite-planes-basic-y_tiled_gen12_mc_ccs: - shard-apl: NOTRUN -> [SKIP][83] ([fdo#109271] / [i915#3886]) +5 similar issues [83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22780/shard-apl6/igt@kms_ccs@pipe-a-crc-sprite-planes-basic-y_tiled_gen12_mc_ccs.html * igt@kms_ccs@pipe-a-random-ccs-data-y_tiled_gen12_mc_ccs: - shard-iclb: NOTRUN -> [SKIP][84] ([fdo#109278] / [i915#3886]) +3 similar issues [84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22780/shard-iclb5/igt@kms_ccs@pipe-a-random-ccs-data-y_tiled_gen12_mc_ccs.html * igt@kms_ccs@pipe-b-ccs-on-another-bo-y_tiled_gen12_mc_ccs: - shard-skl: NOTRUN -> [SKIP][85] ([fdo#109271] / [i915#3886]) +16 similar issues [85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22780/shard-skl2/igt@kms_ccs@pipe-b-ccs-on-another-bo-y_tiled_gen12_mc_ccs.html * igt@kms_ccs@pipe-c-crc-primary-rotation-180-yf_tiled_ccs: - shard-tglb: NOTRUN -> [SKIP][86] ([fdo#111615] / [i915#3689]) [86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22780/shard-tglb1/igt@kms_ccs@pipe-c-crc-primary-rotation-180-yf_tiled_ccs.html * igt@kms_chamelium@dp-frame-dump: - shard-iclb: NOTRUN -> [SKIP][87] ([fdo#109284] / [fdo#111827]) +8 similar issues [87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22780/shard-iclb5/igt@kms_chamelium@dp-frame-dump.html * igt@kms_chamelium@hdmi-hpd-storm-disable: - shard-skl: NOTRUN -> [SKIP][88] ([fdo#109271] / [fdo#111827]) +18 similar issues [88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22780/shard-skl7/igt@kms_chamelium@hdmi-hpd-storm-disable.html * igt@kms_chamelium@vga-hpd-for-each-pipe: - shard-apl: NOTRUN -> [SKIP][89] ([fdo#109271] / [fdo#111827]) +5 similar issues [89]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22780/shard-apl4/igt@kms_chamelium@vga-hpd-for-each-pipe.html * igt@kms_color@pipe-d-degamma: - shard-iclb: NOTRUN -> [SKIP][90] ([fdo#109278] / [i915#1149]) +1 similar issue [90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22780/shard-iclb5/igt@kms_color@pipe-d-degamma.html * igt@kms_color_chamelium@pipe-b-gamma: - shard-tglb: NOTRUN -> [SKIP][91] ([fdo#109284] / [fdo#111827]) [91]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22780/shard-tglb1/igt@kms_color_chamelium@pipe-b-gamma.html * igt@kms_cursor_crc@pipe-b-cursor-512x170-offscreen: - shard-iclb: NOTRUN -> [SKIP][92] ([fdo#109278] / [fdo#109279]) [92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22780/shard-iclb6/igt@kms_cursor_crc@pipe-b-cursor-512x170-offscreen.html * igt@kms_cursor_crc@pipe-b-cursor-max-size-onscreen: - shard-tglb: NOTRUN -> [SKIP][93] ([i915#3359]) [93]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22780/shard-tglb1/igt@kms_cursor_crc@pipe-b-cursor-max-size-onscreen.html * igt@kms_cursor_edge_walk@pipe-d-256x256-left-edge: - shard-iclb: NOTRUN -> [SKIP][94] ([fdo#109278]) +24 similar issues [94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22780/shard-iclb5/igt@kms_cursor_edge_walk@pipe-d-256x256-left-edge.html * igt@kms_cursor_legacy@cursorb-vs-flipb-atomic-transitions-varying-size: - shard-iclb: NOTRUN -> [SKIP][95] ([fdo#109274] / [fdo#109278]) +1 similar issue [95]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22780/shard-iclb6/igt@kms_cursor_legacy@cursorb-vs-flipb-atomic-transitions-varying-size.html * igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions: - shard-apl: [PASS][96] -> [FAIL][97] ([i915#2346]) [96]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11456/shard-apl7/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html [97]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22780/shard-apl8/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html * igt@kms_dp_tiled_display@basic-test-pattern-with-chamelium: - shard-glk: NOTRUN -> [SKIP][98] ([fdo#109271]) +1 similar issue [98]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22780/shard-glk3/igt@kms_dp_tiled_display@basic-test-pattern-with-chamelium.html * igt@kms_draw_crc@draw-method-xrgb8888-mmap-wc-4tiled: - shard-iclb: NOTRUN -> [SKIP][99] ([i915#5287]) +1 similar issue [99]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22780/shard-iclb6/igt@kms_draw_crc@draw-method-xrgb8888-mmap-wc-4tiled.html * igt@kms_flip@2x-flip-vs-panning-interruptible: - shard-iclb: NOTRUN -> [SKIP][100] ([fdo#109274]) +2 similar issues [100]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22780/shard-iclb5/igt@kms_flip@2x-flip-vs-panning-interruptible.html * igt@kms_flip@flip-vs-suspend-interruptible@b-edp1: - shard-tglb: [PASS][101] -> [DMESG-WARN][102] ([i915#2411] / [i915#2867]) [101]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11456/shard-tglb2/igt@kms_flip@flip-vs-suspend-interruptible@b-edp1.html [102]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22780/shard-tglb2/igt@kms_flip@flip-vs-suspend-interruptible@b-edp1.html * igt@kms_flip@flip-vs-suspend-interruptible@c-edp1: - shard-skl: NOTRUN -> [INCOMPLETE][103] ([i915#4939]) [103]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22780/shard-skl9/igt@kms_flip@flip-vs-suspend-interruptible@c-edp1.html * igt@kms_flip@flip-vs-wf_vblank-interruptible@b-edp1: - shard-skl: NOTRUN -> [FAIL][104] ([i915#2122]) [104]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22780/shard-skl3/igt@kms_flip@flip-vs-wf_vblank-interruptible@b-edp1.html * igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytilercccs-upscaling: - shard-iclb: NOTRUN -> [SKIP][105] ([i915#2587]) [105]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22780/shard-iclb5/igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytilercccs-upscaling.html * igt@kms_frontbuffer_tracking@fbc-2p-primscrn-cur-indfb-draw-blt: - shard-iclb: NOTRUN -> [SKIP][106] ([fdo#109280]) +15 similar issues [106]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22780/shard-iclb1/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-cur-indfb-draw-blt.html * igt@kms_frontbuffer_tracking@fbc-2p-primscrn-pri-indfb-draw-mmap-cpu: - shard-tglb: NOTRUN -> [SKIP][107] ([fdo#109280] / [fdo#111825]) +1 similar issue [107]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22780/shard-tglb1/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-pri-indfb-draw-mmap-cpu.html * igt@kms_frontbuffer_tracking@fbc-suspend: - shard-apl: [PASS][108] -> [DMESG-WARN][109] ([i915#180]) +1 similar issue [108]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11456/shard-apl2/igt@kms_frontbuffer_tracking@fbc-suspend.html [109]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22780/shard-apl1/igt@kms_frontbuffer_tracking@fbc-suspend.html * igt@kms_frontbuffer_tracking@psr-2p-scndscrn-cur-indfb-draw-pwrite: - shard-apl: NOTRUN -> [SKIP][110] ([fdo#109271]) +64 similar issues [110]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22780/shard-apl4/igt@kms_frontbuffer_tracking@psr-2p-scndscrn-cur-indfb-draw-pwrite.html * igt@kms_hdr@bpc-switch@bpc-switch-edp-1-pipe-a: - shard-skl: NOTRUN -> [FAIL][111] ([i915#1188]) [111]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22780/shard-skl7/igt@kms_hdr@bpc-switch@bpc-switch-edp-1-pipe-a.html * igt@kms_pipe_crc_basic@suspend-read-crc-pipe-d: - shard-skl: NOTRUN -> [SKIP][112] ([fdo#109271] / [i915#533]) +3 similar issues [112]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22780/shard-skl7/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-d.html * igt@kms_plane_alpha_blend@pipe-a-alpha-transparent-fb: - shard-skl: NOTRUN -> [FAIL][113] ([i915#265]) [113]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22780/shard-skl4/igt@kms_plane_alpha_blend@pipe-a-alpha-transparent-fb.html * igt@kms_plane_alpha_blend@pipe-c-alpha-opaque-fb: - shard-skl: NOTRUN -> [FAIL][114] ([fdo#108145] / [i915#265]) +2 similar issues [114]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22780/shard-skl7/igt@kms_plane_alpha_blend@pipe-c-alpha-opaque-fb.html * igt@kms_psr2_sf@primary-plane-update-sf-dmg-area: - shard-skl: NOTRUN -> [SKIP][115] ([fdo#109271] / [i915#658]) +4 similar issues [115]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22780/shard-skl2/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area.html * igt@kms_psr2_su@frontbuffer-xrgb8888: - shard-iclb: [PASS][116] -> [SKIP][117] ([fdo#109642] / [fdo#111068] / [i915#658]) [116]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11456/shard-iclb2/igt@kms_psr2_su@frontbuffer-xrgb8888.html [117]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22780/shard-iclb1/igt@kms_psr2_su@frontbuffer-xrgb8888.html * igt@kms_psr@psr2_cursor_render: - shard-iclb: NOTRUN -> [SKIP][118] ([fdo#109441]) +1 similar issue [118]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22780/shard-iclb6/igt@kms_psr@psr2_cursor_render.html * igt@kms_scaling_modes@scaling-mode-none@edp-1-pipe-c: - shard-iclb: NOTRUN -> [SKIP][119] ([i915#5030]) +2 similar issues [119]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22780/shard-iclb6/igt@kms_scaling_modes@scaling-mode-none@edp-1-pipe-c.html * igt@kms_tv_load_detect@load-detect: - shard-iclb: NOTRUN -> [SKIP][120] ([fdo#109309]) [120]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22780/shard-iclb6/igt@kms_tv_load_detect@load-detect.html * igt@kms_vrr@flip-dpms: - shard-iclb: NOTRUN -> [SKIP][121] ([fdo#109502]) [121]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22780/shard-iclb1/igt@kms_vrr@flip-dpms.html * igt@kms_writeback@writeback-invalid-parameters: - shard-skl: NOTRUN -> [SKIP][122] ([fdo#109271] / [i915#2437]) [122]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22780/shard-skl4/igt@kms_writeback@writeback-invalid-parameters.html * igt@kms_writeback@writeback-pixel-formats: - shard-apl: NOTRUN -> [SKIP][123] ([fdo#109271] / [i915#2437]) [123]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22780/shard-apl4/igt@kms_writeback@writeback-pixel-formats.html * igt@nouveau_crc@pipe-b-source-rg: - shard-iclb: NOTRUN -> [SKIP][124] ([i915#2530]) +2 similar issues [124]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22780/shard-iclb5/igt@nouveau_crc@pipe-b-source-rg.html * igt@perf@polling-parameterized: - shard-skl: [PASS][125] -> [FAIL][126] ([i915#1542]) [125]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11456/shard-skl7/igt@perf@polling-parameterized.html [126]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22780/shard-skl9/igt@perf@polling-parameterized.html * igt@perf_pmu@module-unload: - shard-iclb: [PASS][127] -> [DMESG-WARN][128] ([i915#262] / [i915#2867]) [127]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11456/shard-iclb5/igt@perf_pmu@module-unload.html [128]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22780/shard-iclb6/igt@perf_pmu@module-unload.html * igt@prime_nv_pcopy@test3_5: - shard-iclb: NOTRUN -> [SKIP][129] ([fdo#109291]) [129]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22780/shard-iclb5/igt@prime_nv_pcopy@test3_5.html * igt@prime_vgem@basic-userptr: - shard-iclb: NOTRUN -> [SKIP][130] ([i915#3301]) [130]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22780/shard-iclb6/igt@prime_vgem@basic-userptr.html * igt@syncobj_timeline@transfer-timeline-point: - shard-skl: NOTRUN -> [DMESG-FAIL][131] ([i915#5098]) [131]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22780/shard-skl10/igt@syncobj_timeline@transfer-timeline-point.html * igt@sysfs_clients@split-10: - shard-iclb: NOTRUN -> [SKIP][132] ([i915#2994]) [132]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22780/shard-iclb5/igt@sysfs_clients@split-10.html * igt@sysfs_clients@split-25: - shard-skl: NOTRUN -> [SKIP][133] ([fdo#109271] / [i915#2994]) +2 similar issues [133]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22780/shard-skl10/igt@sysfs_clients@split-25.html * igt@sysfs_heartbeat_interval@mixed@vcs0: - shard-skl: NOTRUN -> [WARN][134] ([i915#4055]) [134]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22780/shard-skl3/igt@sysfs_heartbeat_interval@mixed@vcs0.html * igt@sysfs_heartbeat_interval@mixed@vecs0: - shard-skl: NOTRUN -> [FAIL][135] ([i915#1731]) [135]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22780/shard-skl3/igt@sysfs_heartbeat_interval@mixed@vecs0.html * igt@sysfs_timeslice_duration@timeout@vecs0: - shard-kbl: [PASS][136] -> [FAIL][137] ([i915#1755]) [136]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11456/shard-kbl3/igt@sysfs_timeslice_duration@timeout@vecs0.html [137]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22780/shard-kbl6/igt@sysfs_timeslice_duration@timeout@vecs0.html - shard-tglb: [PASS][138] -> [FAIL][139] ([i915#1755]) [138]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11456/shard-tglb3/igt@sysfs_timeslice_duration@timeout@vecs0.html [139]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22780/shard-tglb5/igt@sysfs_timeslice_duration@timeout@vecs0.html #### Possible fixes #### * igt@gem_eio@in-flight-contexts-1us: - shard-iclb: [TIMEOUT][140] ([i915#3070]) -> [PASS][141] [140]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11456/shard-iclb5/igt@gem_eio@in-flight-contexts-1us.html [141]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22780/shard-iclb8/igt@gem_eio@in-flight-contexts-1us.html * igt@gem_exec_balancer@parallel-balancer: - shard-iclb: [SKIP][142] ([i915#4525]) -> [PASS][143] [142]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11456/shard-iclb3/igt@gem_exec_balancer@parallel-balancer.html [143]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22780/shard-iclb4/igt@gem_exec_balancer@parallel-balancer.html * igt@gem_exec_fair@basic-flow@rcs0: - shard-tglb: [FAIL][144] ([i915#2842]) -> [PASS][145] [144]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11456/shard-tglb1/igt@gem_exec_fair@basic-flow@rcs0.html [145]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22780/shard-tglb1/igt@gem_exec_fair@basic-flow@rcs0.html * igt@gem_exec_fair@basic-none-share@rcs0: - shard-iclb: [FAIL][146] ([i915#2842]) -> [PASS][147] [146]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11456/shard-iclb4/igt@gem_exec_fair@basic-none-share@rcs0.html [147]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22780/shard-iclb2/igt@gem_exec_fair@basic-none-share@rcs0.html * igt@gem_exec_fair@basic-pace@vcs0: - shard-kbl: [FAIL][148] ([i915#2842]) -> [PASS][149] [148]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11456/shard-kbl4/igt@gem_exec_fair@basic-pace@vcs0.html [149]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22780/shard-kbl7/igt@gem_exec_fair@basic-pace@vcs0.html * igt@gem_softpin@noreloc-s3: - shard-snb: [SKIP][150] ([fdo#109271]) -> [PASS][151] [150]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11456/shard-snb5/igt@gem_softpin@noreloc-s3.html [151]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22780/shard-snb5/igt@gem_softpin@noreloc-s3.html * igt@gen9_exec_parse@allowed-single: - shard-skl: [DMESG-WARN][152] ([i915#5566] / [i915#716]) -> [PASS][153] [152]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11456/shard-skl4/igt@gen9_exec_parse@allowed-single.html [153]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22780/shard-skl5/igt@gen9_exec_parse@allowed-single.html * igt@i915_pm_rpm@i2c: - shard-glk: [FAIL][154] ([i915#5466]) -> [PASS][155] [154]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11456/shard-glk6/igt@i915_pm_rpm@i2c.html [155]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22780/shard == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22780/index.html [-- Attachment #2: Type: text/html, Size: 33898 bytes --] ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915: Fix skl_pcode_try_request function 2022-04-05 10:41 [Intel-gfx] [PATCH] drm/i915: Fix skl_pcode_try_request function Stanislav Lisovskiy ` (3 preceding siblings ...) 2022-04-05 18:39 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork @ 2022-04-05 21:51 ` Govindapillai, Vinod 2022-04-06 7:48 ` Lisovskiy, Stanislav 4 siblings, 1 reply; 10+ messages in thread From: Govindapillai, Vinod @ 2022-04-05 21:51 UTC (permalink / raw) To: Lisovskiy, Stanislav, intel-gfx@lists.freedesktop.org Hi Stan Nice Find! Couple of clarifications, please check inline... On Tue, 2022-04-05 at 13:41 +0300, Stanislav Lisovskiy wrote: > Currently skl_pcode_try_request function doesn't > properly handle return value it gets from > snb_pcode_rw, but treats status != 0 as success, > returning true, which basically doesn't allow > to use retry/timeout mechanisms if PCode happens > to be busy and returns EGAIN or some other status > code not equal to 0. > > We saw this on real hw and also tried simulating this > by always returning -EAGAIN from snb_pcode_rw for 6 times, which > currently will just result in false success, while it should > have tried until timeout is reached: > > [ 22.357729] i915 0000:00:02.0: [drm:intel_cdclk_dump_config [i915]] Changing CDCLK to > 307200 kHz, VCO 614400 kHz, ref 38400 kHz, bypass 19200 kHz, voltage level 0 > [ 22.357831] i915 0000:00:02.0: [drm:__snb_pcode_rw [i915]] Returning EAGAIN retry 1 > [ 22.357892] i915 0000:00:02.0: [drm:skl_pcode_request [i915]] Success, exiting > [ 22.357936] i915 0000:00:02.0: [drm] ERROR Failed to inform PCU about cdclk change (err -11, > freq 307200) > > We see en error because higher level api, still notices that status was wrong, > however we still did try only once. > > We fix it by requiring _both_ the status to be 0 and > request/reply match for success(true) and function > should return failure(false) if either status turns > out to be EAGAIN, EBUSY or whatever or reply/request > masks do not match. > > So now we see this in the logs: > > [ 22.318667] i915 0000:00:02.0: [drm:intel_cdclk_dump_config [i915]] Changing CDCLK to > 307200 kHz, VCO 614400 kHz, ref 38400 kHz, bypass 19200 kHz, voltage level 0 > [ 22.318782] i915 0000:00:02.0: [drm:__snb_pcode_rw [i915]] Returning EAGAIN retry 1 > [ 22.318849] i915 0000:00:02.0: [drm:__snb_pcode_rw [i915]] Returning EAGAIN retry 2 > [ 22.319006] i915 0000:00:02.0: [drm:__snb_pcode_rw [i915]] Returning EAGAIN retry 3 > [ 22.319091] i915 0000:00:02.0: [drm:__snb_pcode_rw [i915]] Returning EAGAIN retry 4 > [ 22.319158] i915 0000:00:02.0: [drm:__snb_pcode_rw [i915]] Returning EAGAIN retry 5 > [ 22.319224] i915 0000:00:02.0: [drm:__snb_pcode_rw [i915]] Returning EAGAIN retry 6 > > Signed-off-by: Stanislav Lisovskiy <stanislav.lisovskiy@intel.com> > --- > drivers/gpu/drm/i915/intel_pcode.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/intel_pcode.c b/drivers/gpu/drm/i915/intel_pcode.c > index 391a37492ce5..fb6c43e8a02f 100644 > --- a/drivers/gpu/drm/i915/intel_pcode.c > +++ b/drivers/gpu/drm/i915/intel_pcode.c > @@ -136,7 +136,7 @@ static bool skl_pcode_try_request(struct drm_i915_private *i915, u32 mbox, > { > *status = __snb_pcode_rw(i915, mbox, &request, NULL, 500, 0, true); > > - return *status || ((request & reply_mask) == reply); > + return (*status == 0) && ((request & reply_mask) == reply); Here I wonder whether you need to check what sort of __snb_pcode_rw return values need the retry! Isn't only ETIMEDOUT need the retry? Other return error codes can be probably be ignored from retry? And should the, "return ret ? ret : status;" in "skl_pcode_request" be change to "return ret ? status : ret;" to reflect the correct error code to calling functions after this change? > } > > /** ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915: Fix skl_pcode_try_request function 2022-04-05 21:51 ` [Intel-gfx] [PATCH] " Govindapillai, Vinod @ 2022-04-06 7:48 ` Lisovskiy, Stanislav 2022-04-06 9:19 ` Govindapillai, Vinod 0 siblings, 1 reply; 10+ messages in thread From: Lisovskiy, Stanislav @ 2022-04-06 7:48 UTC (permalink / raw) To: Govindapillai, Vinod; +Cc: intel-gfx@lists.freedesktop.org On Wed, Apr 06, 2022 at 12:51:29AM +0300, Govindapillai, Vinod wrote: > Hi Stan > > Nice Find! Couple of clarifications, please check inline... > > On Tue, 2022-04-05 at 13:41 +0300, Stanislav Lisovskiy wrote: > > Currently skl_pcode_try_request function doesn't > > properly handle return value it gets from > > snb_pcode_rw, but treats status != 0 as success, > > returning true, which basically doesn't allow > > to use retry/timeout mechanisms if PCode happens > > to be busy and returns EGAIN or some other status > > code not equal to 0. > > > > We saw this on real hw and also tried simulating this > > by always returning -EAGAIN from snb_pcode_rw for 6 times, which > > currently will just result in false success, while it should > > have tried until timeout is reached: > > > > [ 22.357729] i915 0000:00:02.0: [drm:intel_cdclk_dump_config [i915]] Changing CDCLK to > > 307200 kHz, VCO 614400 kHz, ref 38400 kHz, bypass 19200 kHz, voltage level 0 > > [ 22.357831] i915 0000:00:02.0: [drm:__snb_pcode_rw [i915]] Returning EAGAIN retry 1 > > [ 22.357892] i915 0000:00:02.0: [drm:skl_pcode_request [i915]] Success, exiting > > [ 22.357936] i915 0000:00:02.0: [drm] ERROR Failed to inform PCU about cdclk change (err -11, > > freq 307200) > > > > We see en error because higher level api, still notices that status was wrong, > > however we still did try only once. > > > > We fix it by requiring _both_ the status to be 0 and > > request/reply match for success(true) and function > > should return failure(false) if either status turns > > out to be EAGAIN, EBUSY or whatever or reply/request > > masks do not match. > > > > So now we see this in the logs: > > > > [ 22.318667] i915 0000:00:02.0: [drm:intel_cdclk_dump_config [i915]] Changing CDCLK to > > 307200 kHz, VCO 614400 kHz, ref 38400 kHz, bypass 19200 kHz, voltage level 0 > > [ 22.318782] i915 0000:00:02.0: [drm:__snb_pcode_rw [i915]] Returning EAGAIN retry 1 > > [ 22.318849] i915 0000:00:02.0: [drm:__snb_pcode_rw [i915]] Returning EAGAIN retry 2 > > [ 22.319006] i915 0000:00:02.0: [drm:__snb_pcode_rw [i915]] Returning EAGAIN retry 3 > > [ 22.319091] i915 0000:00:02.0: [drm:__snb_pcode_rw [i915]] Returning EAGAIN retry 4 > > [ 22.319158] i915 0000:00:02.0: [drm:__snb_pcode_rw [i915]] Returning EAGAIN retry 5 > > [ 22.319224] i915 0000:00:02.0: [drm:__snb_pcode_rw [i915]] Returning EAGAIN retry 6 > > > > Signed-off-by: Stanislav Lisovskiy <stanislav.lisovskiy@intel.com> > > > --- > > drivers/gpu/drm/i915/intel_pcode.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/i915/intel_pcode.c b/drivers/gpu/drm/i915/intel_pcode.c > > index 391a37492ce5..fb6c43e8a02f 100644 > > --- a/drivers/gpu/drm/i915/intel_pcode.c > > +++ b/drivers/gpu/drm/i915/intel_pcode.c > > @@ -136,7 +136,7 @@ static bool skl_pcode_try_request(struct drm_i915_private *i915, u32 mbox, > > { > > *status = __snb_pcode_rw(i915, mbox, &request, NULL, 500, 0, true); > > > > - return *status || ((request & reply_mask) == reply); > > + return (*status == 0) && ((request & reply_mask) == reply); > > Here I wonder whether you need to check what sort of __snb_pcode_rw return values need the retry! > Isn't only ETIMEDOUT need the retry? Other return error codes can be probably be ignored from retry? Hi Vinod! Thanks for comments. Well theoretically yes, but in practice I think we would prefer to retry in almost all of the cases. There are also multiple error codes when you need to retry, such as "EAGAIN", "EBUSY" and probably some others. Thats is probably why original code also doesn't make a difference. > > And should the, "return ret ? ret : status;" in "skl_pcode_request" be change to "return ret ? > status : ret;" to reflect the correct error code to calling functions after this change? I think the logic here is such that ret value is somewhat more important than the status, so if ret is something not zero - we always prefer returning ret, for the enduser to know what was the ret ERROR code. If ret is 0, then we can "afford" to let the enduser know, what was actually the status. To me it actually sounds a bit wrong, I think we should get status pointer, like "&status" and modify it, so that calling site _always_ knows both status and ret, mixing those two is a dangerous strategy which exactly caused some coder confusion and probably the bug, that this patch is fixing. Stan > > > > } > > > > /** ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915: Fix skl_pcode_try_request function 2022-04-06 7:48 ` Lisovskiy, Stanislav @ 2022-04-06 9:19 ` Govindapillai, Vinod 2022-04-06 9:58 ` Lisovskiy, Stanislav 0 siblings, 1 reply; 10+ messages in thread From: Govindapillai, Vinod @ 2022-04-06 9:19 UTC (permalink / raw) To: Lisovskiy, Stanislav; +Cc: intel-gfx@lists.freedesktop.org Hi, On Wed, 2022-04-06 at 10:48 +0300, Lisovskiy, Stanislav wrote: > On Wed, Apr 06, 2022 at 12:51:29AM +0300, Govindapillai, Vinod wrote: > > Hi Stan > > > > Nice Find! Couple of clarifications, please check inline... > > > > On Tue, 2022-04-05 at 13:41 +0300, Stanislav Lisovskiy wrote: > > > Currently skl_pcode_try_request function doesn't > > > properly handle return value it gets from > > > snb_pcode_rw, but treats status != 0 as success, > > > returning true, which basically doesn't allow > > > to use retry/timeout mechanisms if PCode happens > > > to be busy and returns EGAIN or some other status > > > code not equal to 0. > > > > > > We saw this on real hw and also tried simulating this > > > by always returning -EAGAIN from snb_pcode_rw for 6 times, which > > > currently will just result in false success, while it should > > > have tried until timeout is reached: > > > > > > [ 22.357729] i915 0000:00:02.0: [drm:intel_cdclk_dump_config [i915]] Changing CDCLK to > > > 307200 kHz, VCO 614400 kHz, ref 38400 kHz, bypass 19200 kHz, voltage level 0 > > > [ 22.357831] i915 0000:00:02.0: [drm:__snb_pcode_rw [i915]] Returning EAGAIN retry 1 > > > [ 22.357892] i915 0000:00:02.0: [drm:skl_pcode_request [i915]] Success, exiting > > > [ 22.357936] i915 0000:00:02.0: [drm] ERROR Failed to inform PCU about cdclk change (err > > > -11, > > > freq 307200) > > > > > > We see en error because higher level api, still notices that status was wrong, > > > however we still did try only once. > > > > > > We fix it by requiring _both_ the status to be 0 and > > > request/reply match for success(true) and function > > > should return failure(false) if either status turns > > > out to be EAGAIN, EBUSY or whatever or reply/request > > > masks do not match. > > > > > > So now we see this in the logs: > > > > > > [ 22.318667] i915 0000:00:02.0: [drm:intel_cdclk_dump_config [i915]] Changing CDCLK to > > > 307200 kHz, VCO 614400 kHz, ref 38400 kHz, bypass 19200 kHz, voltage level 0 > > > [ 22.318782] i915 0000:00:02.0: [drm:__snb_pcode_rw [i915]] Returning EAGAIN retry 1 > > > [ 22.318849] i915 0000:00:02.0: [drm:__snb_pcode_rw [i915]] Returning EAGAIN retry 2 > > > [ 22.319006] i915 0000:00:02.0: [drm:__snb_pcode_rw [i915]] Returning EAGAIN retry 3 > > > [ 22.319091] i915 0000:00:02.0: [drm:__snb_pcode_rw [i915]] Returning EAGAIN retry 4 > > > [ 22.319158] i915 0000:00:02.0: [drm:__snb_pcode_rw [i915]] Returning EAGAIN retry 5 > > > [ 22.319224] i915 0000:00:02.0: [drm:__snb_pcode_rw [i915]] Returning EAGAIN retry 6 > > > > > > Signed-off-by: Stanislav Lisovskiy <stanislav.lisovskiy@intel.com> > > > --- > > > drivers/gpu/drm/i915/intel_pcode.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/drivers/gpu/drm/i915/intel_pcode.c b/drivers/gpu/drm/i915/intel_pcode.c > > > index 391a37492ce5..fb6c43e8a02f 100644 > > > --- a/drivers/gpu/drm/i915/intel_pcode.c > > > +++ b/drivers/gpu/drm/i915/intel_pcode.c > > > @@ -136,7 +136,7 @@ static bool skl_pcode_try_request(struct drm_i915_private *i915, u32 mbox, > > > { > > > *status = __snb_pcode_rw(i915, mbox, &request, NULL, 500, 0, true); > > > > > > - return *status || ((request & reply_mask) == reply); > > > + return (*status == 0) && ((request & reply_mask) == reply); > > > > Here I wonder whether you need to check what sort of __snb_pcode_rw return values need the > > retry! > > Isn't only ETIMEDOUT need the retry? Other return error codes can be probably be ignored from > > retry? > > Hi Vinod! Thanks for comments. > > Well theoretically yes, but in practice I think we would prefer to retry in almost all of the > cases. > There are also multiple error codes when you need to retry, such as "EAGAIN", "EBUSY" and probably > some others. Thats is probably why original code also doesn't make a difference. Ack > > > And should the, "return ret ? ret : status;" in "skl_pcode_request" be change to "return ret ? > > status : ret;" to reflect the correct error code to calling functions after this change? > > I think the logic here is such that ret value is somewhat more important than the status, so > if ret is something not zero - we always prefer returning ret, for the enduser to know what > was the ret ERROR code. > If ret is 0, then we can "afford" to let the enduser know, what was actually the status. > > To me it actually sounds a bit wrong, I think we should get status pointer, like "&status" > and modify it, so that calling site _always_ knows both status and ret, mixing those two > is a dangerous strategy which exactly caused some coder confusion and probably the bug, that > this patch is fixing. > > Stan Agreed, the original code was indeed bit complicated! But what I meant was, after your patch, "ret" will be either "0" or "ETIMEDOUT". If ret = 0, then "status" would had been 0 too based on your change in this patch. If ret != 0, then "status" might have values other than ETIMEDOUT. So, "return ret ? status : ret;" might be better instead of the original "return ret ? ret : status;" especially after your patch. Anyway, not sure if the calling functions care about the return value much other than just logging. It was indeed a quite good fix! Reviewd-By: Vinod Govindapillai <vinod.govindapillai@intel.com> > > > > > > } > > > > > > /** ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915: Fix skl_pcode_try_request function 2022-04-06 9:19 ` Govindapillai, Vinod @ 2022-04-06 9:58 ` Lisovskiy, Stanislav 2022-04-06 10:15 ` Govindapillai, Vinod 0 siblings, 1 reply; 10+ messages in thread From: Lisovskiy, Stanislav @ 2022-04-06 9:58 UTC (permalink / raw) To: Govindapillai, Vinod; +Cc: intel-gfx@lists.freedesktop.org On Wed, Apr 06, 2022 at 12:19:19PM +0300, Govindapillai, Vinod wrote: > Hi, > > On Wed, 2022-04-06 at 10:48 +0300, Lisovskiy, Stanislav wrote: > > On Wed, Apr 06, 2022 at 12:51:29AM +0300, Govindapillai, Vinod wrote: > > > Hi Stan > > > > > > Nice Find! Couple of clarifications, please check inline... > > > > > > On Tue, 2022-04-05 at 13:41 +0300, Stanislav Lisovskiy wrote: > > > > Currently skl_pcode_try_request function doesn't > > > > properly handle return value it gets from > > > > snb_pcode_rw, but treats status != 0 as success, > > > > returning true, which basically doesn't allow > > > > to use retry/timeout mechanisms if PCode happens > > > > to be busy and returns EGAIN or some other status > > > > code not equal to 0. > > > > > > > > We saw this on real hw and also tried simulating this > > > > by always returning -EAGAIN from snb_pcode_rw for 6 times, which > > > > currently will just result in false success, while it should > > > > have tried until timeout is reached: > > > > > > > > [ 22.357729] i915 0000:00:02.0: [drm:intel_cdclk_dump_config [i915]] Changing CDCLK to > > > > 307200 kHz, VCO 614400 kHz, ref 38400 kHz, bypass 19200 kHz, voltage level 0 > > > > [ 22.357831] i915 0000:00:02.0: [drm:__snb_pcode_rw [i915]] Returning EAGAIN retry 1 > > > > [ 22.357892] i915 0000:00:02.0: [drm:skl_pcode_request [i915]] Success, exiting > > > > [ 22.357936] i915 0000:00:02.0: [drm] ERROR Failed to inform PCU about cdclk change (err > > > > -11, > > > > freq 307200) > > > > > > > > We see en error because higher level api, still notices that status was wrong, > > > > however we still did try only once. > > > > > > > > We fix it by requiring _both_ the status to be 0 and > > > > request/reply match for success(true) and function > > > > should return failure(false) if either status turns > > > > out to be EAGAIN, EBUSY or whatever or reply/request > > > > masks do not match. > > > > > > > > So now we see this in the logs: > > > > > > > > [ 22.318667] i915 0000:00:02.0: [drm:intel_cdclk_dump_config [i915]] Changing CDCLK to > > > > 307200 kHz, VCO 614400 kHz, ref 38400 kHz, bypass 19200 kHz, voltage level 0 > > > > [ 22.318782] i915 0000:00:02.0: [drm:__snb_pcode_rw [i915]] Returning EAGAIN retry 1 > > > > [ 22.318849] i915 0000:00:02.0: [drm:__snb_pcode_rw [i915]] Returning EAGAIN retry 2 > > > > [ 22.319006] i915 0000:00:02.0: [drm:__snb_pcode_rw [i915]] Returning EAGAIN retry 3 > > > > [ 22.319091] i915 0000:00:02.0: [drm:__snb_pcode_rw [i915]] Returning EAGAIN retry 4 > > > > [ 22.319158] i915 0000:00:02.0: [drm:__snb_pcode_rw [i915]] Returning EAGAIN retry 5 > > > > [ 22.319224] i915 0000:00:02.0: [drm:__snb_pcode_rw [i915]] Returning EAGAIN retry 6 > > > > > > > > Signed-off-by: Stanislav Lisovskiy <stanislav.lisovskiy@intel.com> > > > > --- > > > > drivers/gpu/drm/i915/intel_pcode.c | 2 +- > > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > > > diff --git a/drivers/gpu/drm/i915/intel_pcode.c b/drivers/gpu/drm/i915/intel_pcode.c > > > > index 391a37492ce5..fb6c43e8a02f 100644 > > > > --- a/drivers/gpu/drm/i915/intel_pcode.c > > > > +++ b/drivers/gpu/drm/i915/intel_pcode.c > > > > @@ -136,7 +136,7 @@ static bool skl_pcode_try_request(struct drm_i915_private *i915, u32 mbox, > > > > { > > > > *status = __snb_pcode_rw(i915, mbox, &request, NULL, 500, 0, true); > > > > > > > > - return *status || ((request & reply_mask) == reply); > > > > + return (*status == 0) && ((request & reply_mask) == reply); > > > > > > Here I wonder whether you need to check what sort of __snb_pcode_rw return values need the > > > retry! > > > Isn't only ETIMEDOUT need the retry? Other return error codes can be probably be ignored from > > > retry? > > > > Hi Vinod! Thanks for comments. > > > > Well theoretically yes, but in practice I think we would prefer to retry in almost all of the > > cases. > > There are also multiple error codes when you need to retry, such as "EAGAIN", "EBUSY" and probably > > some others. Thats is probably why original code also doesn't make a difference. > > Ack > > > > > > And should the, "return ret ? ret : status;" in "skl_pcode_request" be change to "return ret ? > > > status : ret;" to reflect the correct error code to calling functions after this change? > > > > I think the logic here is such that ret value is somewhat more important than the status, so > > if ret is something not zero - we always prefer returning ret, for the enduser to know what > > was the ret ERROR code. > > If ret is 0, then we can "afford" to let the enduser know, what was actually the status. > > > > To me it actually sounds a bit wrong, I think we should get status pointer, like "&status" > > and modify it, so that calling site _always_ knows both status and ret, mixing those two > > is a dangerous strategy which exactly caused some coder confusion and probably the bug, that > > this patch is fixing. > > > > Stan > > Agreed, the original code was indeed bit complicated! > > But what I meant was, after your patch, "ret" will be either "0" or "ETIMEDOUT". > If ret = 0, then "status" would had been 0 too based on your change in this patch. > If ret != 0, then "status" might have values other than ETIMEDOUT. > > So, > "return ret ? status : ret;" might be better instead of the original "return ret ? ret : status;" > especially after your patch. > > Anyway, not sure if the calling functions care about the return value much other than just logging. > It was indeed a quite good fix! Yes, your proposal actually makes more sense than current code anyway, however I'm still thinking if we should may be propagate &status to call site always, need to think a bit. Would be nice to get Ville's perspective on this. > > Reviewd-By: Vinod Govindapillai <vinod.govindapillai@intel.com> Thanks, Stan > > > > > > > > > > } > > > > > > > > /** ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915: Fix skl_pcode_try_request function 2022-04-06 9:58 ` Lisovskiy, Stanislav @ 2022-04-06 10:15 ` Govindapillai, Vinod 0 siblings, 0 replies; 10+ messages in thread From: Govindapillai, Vinod @ 2022-04-06 10:15 UTC (permalink / raw) To: Lisovskiy, Stanislav; +Cc: intel-gfx@lists.freedesktop.org On Wed, 2022-04-06 at 12:58 +0300, Lisovskiy, Stanislav wrote: > On Wed, Apr 06, 2022 at 12:19:19PM +0300, Govindapillai, Vinod wrote: > > Hi, > > > > On Wed, 2022-04-06 at 10:48 +0300, Lisovskiy, Stanislav wrote: > > > On Wed, Apr 06, 2022 at 12:51:29AM +0300, Govindapillai, Vinod wrote: > > > > Hi Stan > > > > > > > > Nice Find! Couple of clarifications, please check inline... > > > > > > > > On Tue, 2022-04-05 at 13:41 +0300, Stanislav Lisovskiy wrote: > > > > > Currently skl_pcode_try_request function doesn't > > > > > properly handle return value it gets from > > > > > snb_pcode_rw, but treats status != 0 as success, > > > > > returning true, which basically doesn't allow > > > > > to use retry/timeout mechanisms if PCode happens > > > > > to be busy and returns EGAIN or some other status > > > > > code not equal to 0. > > > > > > > > > > We saw this on real hw and also tried simulating this > > > > > by always returning -EAGAIN from snb_pcode_rw for 6 times, which > > > > > currently will just result in false success, while it should > > > > > have tried until timeout is reached: > > > > > > > > > > [ 22.357729] i915 0000:00:02.0: [drm:intel_cdclk_dump_config [i915]] Changing CDCLK to > > > > > 307200 kHz, VCO 614400 kHz, ref 38400 kHz, bypass 19200 kHz, voltage level 0 > > > > > [ 22.357831] i915 0000:00:02.0: [drm:__snb_pcode_rw [i915]] Returning EAGAIN retry 1 > > > > > [ 22.357892] i915 0000:00:02.0: [drm:skl_pcode_request [i915]] Success, exiting > > > > > [ 22.357936] i915 0000:00:02.0: [drm] ERROR Failed to inform PCU about cdclk change (err > > > > > -11, > > > > > freq 307200) > > > > > > > > > > We see en error because higher level api, still notices that status was wrong, > > > > > however we still did try only once. > > > > > > > > > > We fix it by requiring _both_ the status to be 0 and > > > > > request/reply match for success(true) and function > > > > > should return failure(false) if either status turns > > > > > out to be EAGAIN, EBUSY or whatever or reply/request > > > > > masks do not match. > > > > > > > > > > So now we see this in the logs: > > > > > > > > > > [ 22.318667] i915 0000:00:02.0: [drm:intel_cdclk_dump_config [i915]] Changing CDCLK to > > > > > 307200 kHz, VCO 614400 kHz, ref 38400 kHz, bypass 19200 kHz, voltage level 0 > > > > > [ 22.318782] i915 0000:00:02.0: [drm:__snb_pcode_rw [i915]] Returning EAGAIN retry 1 > > > > > [ 22.318849] i915 0000:00:02.0: [drm:__snb_pcode_rw [i915]] Returning EAGAIN retry 2 > > > > > [ 22.319006] i915 0000:00:02.0: [drm:__snb_pcode_rw [i915]] Returning EAGAIN retry 3 > > > > > [ 22.319091] i915 0000:00:02.0: [drm:__snb_pcode_rw [i915]] Returning EAGAIN retry 4 > > > > > [ 22.319158] i915 0000:00:02.0: [drm:__snb_pcode_rw [i915]] Returning EAGAIN retry 5 > > > > > [ 22.319224] i915 0000:00:02.0: [drm:__snb_pcode_rw [i915]] Returning EAGAIN retry 6 > > > > > > > > > > Signed-off-by: Stanislav Lisovskiy <stanislav.lisovskiy@intel.com> > > > > > --- > > > > > drivers/gpu/drm/i915/intel_pcode.c | 2 +- > > > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > > > > > diff --git a/drivers/gpu/drm/i915/intel_pcode.c b/drivers/gpu/drm/i915/intel_pcode.c > > > > > index 391a37492ce5..fb6c43e8a02f 100644 > > > > > --- a/drivers/gpu/drm/i915/intel_pcode.c > > > > > +++ b/drivers/gpu/drm/i915/intel_pcode.c > > > > > @@ -136,7 +136,7 @@ static bool skl_pcode_try_request(struct drm_i915_private *i915, u32 > > > > > mbox, > > > > > { > > > > > *status = __snb_pcode_rw(i915, mbox, &request, NULL, 500, 0, true); > > > > > > > > > > - return *status || ((request & reply_mask) == reply); > > > > > + return (*status == 0) && ((request & reply_mask) == reply); > > > > > > > > Here I wonder whether you need to check what sort of __snb_pcode_rw return values need the > > > > retry! > > > > Isn't only ETIMEDOUT need the retry? Other return error codes can be probably be ignored > > > > from > > > > retry? > > > > > > Hi Vinod! Thanks for comments. > > > > > > Well theoretically yes, but in practice I think we would prefer to retry in almost all of the > > > cases. > > > There are also multiple error codes when you need to retry, such as "EAGAIN", "EBUSY" and > > > probably > > > some others. Thats is probably why original code also doesn't make a difference. > > > > Ack > > > > > > And should the, "return ret ? ret : status;" in "skl_pcode_request" be change to "return ret > > > > ? > > > > status : ret;" to reflect the correct error code to calling functions after this change? > > > > > > I think the logic here is such that ret value is somewhat more important than the status, so > > > if ret is something not zero - we always prefer returning ret, for the enduser to know what > > > was the ret ERROR code. > > > If ret is 0, then we can "afford" to let the enduser know, what was actually the status. > > > > > > To me it actually sounds a bit wrong, I think we should get status pointer, like "&status" > > > and modify it, so that calling site _always_ knows both status and ret, mixing those two > > > is a dangerous strategy which exactly caused some coder confusion and probably the bug, that > > > this patch is fixing. > > > > > > Stan > > > > Agreed, the original code was indeed bit complicated! > > > > But what I meant was, after your patch, "ret" will be either "0" or "ETIMEDOUT". > > If ret = 0, then "status" would had been 0 too based on your change in this patch. > > If ret != 0, then "status" might have values other than ETIMEDOUT. > > > > So, > > "return ret ? status : ret;" might be better instead of the original "return ret ? ret : > > status;" > > especially after your patch. > > > > Anyway, not sure if the calling functions care about the return value much other than just > > logging. > > It was indeed a quite good fix! > > Yes, your proposal actually makes more sense than current code anyway, however I'm still thinking > if we should may be propagate &status to call site always, Yes! my bad :) actually "return ret ? status : ret" is indeed "return status"! > need to think a bit. > Would be nice to get Ville's perspective on this. > > > Reviewd-By: Vinod Govindapillai <vinod.govindapillai@intel.com> > > Thanks, > > Stan > > > > > > } > > > > > > > > > > /** ^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2022-04-06 10:15 UTC | newest] Thread overview: 10+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2022-04-05 10:41 [Intel-gfx] [PATCH] drm/i915: Fix skl_pcode_try_request function Stanislav Lisovskiy 2022-04-05 13:58 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork 2022-04-05 14:03 ` [Intel-gfx] ✗ Fi.CI.DOCS: " Patchwork 2022-04-05 14:28 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork 2022-04-05 18:39 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork 2022-04-05 21:51 ` [Intel-gfx] [PATCH] " Govindapillai, Vinod 2022-04-06 7:48 ` Lisovskiy, Stanislav 2022-04-06 9:19 ` Govindapillai, Vinod 2022-04-06 9:58 ` Lisovskiy, Stanislav 2022-04-06 10:15 ` Govindapillai, Vinod
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.