From: Jakub Kicinski <kuba@kernel.org>
To: Nikolay Aleksandrov <razor@blackwall.org>
Cc: idosch@idosch.org, netdev@vger.kernel.org,
bridge@lists.linux-foundation.org, davem@davemloft.net,
Roopa Prabhu <roopa@nvidia.com>
Subject: Re: [Bridge] [PATCH net-next v2 0/8] net: bridge: add flush filtering support
Date: Mon, 11 Apr 2022 14:35:08 -0700 [thread overview]
Message-ID: <20220411143508.0592f60e@kernel.org> (raw)
In-Reply-To: <d47fe5e3-2820-196d-b375-2bf98cd784d3@blackwall.org>
On Tue, 12 Apr 2022 00:17:14 +0300 Nikolay Aleksandrov wrote:
> > Yup, basically the policy is defined in the core, so the types are
> > known. We can extract the fields from the message there, even if
> > the exact meaning of the fields gets established in the callback.
>
> That sounds nice, but there are a few catches, f.e. some ndo_fdb implementations
> check if attributes were set, i.e. they can also interpret 0, so it will require
> additional state (either special value, bitfield or some other way of telling them
> it was actually present but 0).
> Anyway I think that is orthogonal to adding the flush support, it's a nice cleanup but can
> be done separately because it will have to be done for all ndo_fdb callbacks and I
> suspect the change will grow considerably.
> OTOH the flush implementation via delneigh doesn't require a new ndo_fdb call way,
> would you mind if I finish that up without the struct conversion?
Not terribly, go ahead.
WARNING: multiple messages have this Message-ID (diff)
From: Jakub Kicinski <kuba@kernel.org>
To: Nikolay Aleksandrov <razor@blackwall.org>
Cc: Roopa Prabhu <roopa@nvidia.com>,
netdev@vger.kernel.org, idosch@idosch.org, davem@davemloft.net,
bridge@lists.linux-foundation.org
Subject: Re: [PATCH net-next v2 0/8] net: bridge: add flush filtering support
Date: Mon, 11 Apr 2022 14:35:08 -0700 [thread overview]
Message-ID: <20220411143508.0592f60e@kernel.org> (raw)
In-Reply-To: <d47fe5e3-2820-196d-b375-2bf98cd784d3@blackwall.org>
On Tue, 12 Apr 2022 00:17:14 +0300 Nikolay Aleksandrov wrote:
> > Yup, basically the policy is defined in the core, so the types are
> > known. We can extract the fields from the message there, even if
> > the exact meaning of the fields gets established in the callback.
>
> That sounds nice, but there are a few catches, f.e. some ndo_fdb implementations
> check if attributes were set, i.e. they can also interpret 0, so it will require
> additional state (either special value, bitfield or some other way of telling them
> it was actually present but 0).
> Anyway I think that is orthogonal to adding the flush support, it's a nice cleanup but can
> be done separately because it will have to be done for all ndo_fdb callbacks and I
> suspect the change will grow considerably.
> OTOH the flush implementation via delneigh doesn't require a new ndo_fdb call way,
> would you mind if I finish that up without the struct conversion?
Not terribly, go ahead.
next prev parent reply other threads:[~2022-04-11 21:35 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-11 17:29 [Bridge] [PATCH net-next v2 0/8] net: bridge: add flush filtering support Nikolay Aleksandrov
2022-04-11 17:29 ` Nikolay Aleksandrov
2022-04-11 17:29 ` [Bridge] [PATCH net-next v2 1/8] net: rtnetlink: add RTM_FLUSHNEIGH Nikolay Aleksandrov
2022-04-11 17:29 ` Nikolay Aleksandrov
2022-04-11 22:57 ` [Bridge] " David Ahern
2022-04-11 22:57 ` David Ahern
2022-04-11 17:29 ` [Bridge] [PATCH net-next v2 2/8] net: add ndo_fdb_flush op Nikolay Aleksandrov
2022-04-11 17:29 ` Nikolay Aleksandrov
2022-04-11 17:29 ` [Bridge] [PATCH net-next v2 3/8] net: bridge: fdb: " Nikolay Aleksandrov
2022-04-11 17:29 ` Nikolay Aleksandrov
2022-04-11 17:29 ` [Bridge] [PATCH net-next v2 4/8] net: rtnetlink: register a generic rtnl_fdb_flush call Nikolay Aleksandrov
2022-04-11 17:29 ` Nikolay Aleksandrov
2022-04-11 17:29 ` [Bridge] [PATCH net-next v2 5/8] net: rtnetlink: add common flush attributes Nikolay Aleksandrov
2022-04-11 17:29 ` Nikolay Aleksandrov
2022-04-11 17:29 ` [Bridge] [PATCH net-next v2 6/8] net: bridge: fdb: add support for fine-grained flushing Nikolay Aleksandrov
2022-04-11 17:29 ` Nikolay Aleksandrov
2022-04-11 17:29 ` [Bridge] [PATCH net-next v2 7/8] net: bridge: fdb: add support for flush filtering based on ndm flags and state Nikolay Aleksandrov
2022-04-11 17:29 ` Nikolay Aleksandrov
2022-04-11 17:29 ` [Bridge] [PATCH net-next v2 8/8] net: bridge: fdb: add support for flush filtering based on ifindex and vlan Nikolay Aleksandrov
2022-04-11 17:29 ` Nikolay Aleksandrov
2022-04-11 17:42 ` [Bridge] [PATCH net-next v2 0/8] net: bridge: add flush filtering support Nikolay Aleksandrov
2022-04-11 17:42 ` Nikolay Aleksandrov
2022-04-11 18:08 ` [Bridge] " Roopa Prabhu
2022-04-11 18:08 ` Roopa Prabhu
2022-04-11 18:18 ` [Bridge] " Nikolay Aleksandrov
2022-04-11 18:18 ` Nikolay Aleksandrov
2022-04-11 18:31 ` [Bridge] " Nikolay Aleksandrov
2022-04-11 18:31 ` Nikolay Aleksandrov
2022-04-11 19:22 ` [Bridge] " Roopa Prabhu
2022-04-11 19:22 ` Roopa Prabhu
2022-04-11 19:49 ` [Bridge] " Jakub Kicinski
2022-04-11 19:49 ` Jakub Kicinski
2022-04-11 20:34 ` [Bridge] " Nikolay Aleksandrov
2022-04-11 20:34 ` Nikolay Aleksandrov
2022-04-11 20:48 ` [Bridge] " Jakub Kicinski
2022-04-11 20:48 ` Jakub Kicinski
2022-04-11 21:17 ` [Bridge] " Nikolay Aleksandrov
2022-04-11 21:17 ` Nikolay Aleksandrov
2022-04-11 21:35 ` Jakub Kicinski [this message]
2022-04-11 21:35 ` Jakub Kicinski
2022-04-11 23:03 ` [Bridge] " David Ahern
2022-04-11 23:03 ` David Ahern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220411143508.0592f60e@kernel.org \
--to=kuba@kernel.org \
--cc=bridge@lists.linux-foundation.org \
--cc=davem@davemloft.net \
--cc=idosch@idosch.org \
--cc=netdev@vger.kernel.org \
--cc=razor@blackwall.org \
--cc=roopa@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.