From: Christoph Hellwig <hch@lst.de>
To: Ming Lei <ming.lei@redhat.com>
Cc: Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org, linux-mm@kvack.org,
linux-xfs@vger.kernel.org, Changhui Zhong <czhong@redhat.com>
Subject: Re: [PATCH V2] block: avoid io timeout in case of sync polled dio
Date: Tue, 19 Apr 2022 10:15:17 +0200 [thread overview]
Message-ID: <20220419081517.GA6427@lst.de> (raw)
In-Reply-To: <Yl5pDrgglwv00caD@T590>
On Tue, Apr 19, 2022 at 03:47:26PM +0800, Ming Lei wrote:
> I agree to remove it because it is legacy poll interface, and very likely
> no one use it since the problem to be addressed can easily be exposed by
> sync polled dio sanity test or 'blktests block/007'.
>
> I'd suggest to switch sync polled dio into non-polled silently, just with
> logging sort of 'sync polled io is obsolete, please use io_uring for io
> polling', or any other idea?
We've carefully define RWF_HIPRI to just be a hint. So I don't think
logging an error would be all that useful.
prev parent reply other threads:[~2022-04-19 8:16 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-15 3:47 [PATCH V2] block: avoid io timeout in case of sync polled dio Ming Lei
2022-04-15 5:18 ` Christoph Hellwig
2022-04-15 11:00 ` Ming Lei
2022-04-16 5:49 ` Christoph Hellwig
2022-04-16 9:03 ` Ming Lei
2022-04-18 5:12 ` Christoph Hellwig
2022-04-18 8:19 ` Ming Lei
2022-04-19 5:39 ` Christoph Hellwig
2022-04-19 7:47 ` Ming Lei
2022-04-19 8:15 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220419081517.GA6427@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=czhong@redhat.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-xfs@vger.kernel.org \
--cc=ming.lei@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.