All of lore.kernel.org
 help / color / mirror / Atom feed
From: Patrick Rudolph <patrick.rudolph@9elements.com>
To: joel@jms.id.au, openbmc@lists.ozlabs.org
Cc: christian.walter@9elements.com, takken@us.ibm.com,
	Patrick Rudolph <patrick.rudolph@9elements.com>
Subject: [PATCH u-boot v2019.04-aspeed-openbmc 3/4] arm/mach-aspeed: Allow to disable WDT2
Date: Wed, 20 Apr 2022 12:25:01 +0200	[thread overview]
Message-ID: <20220420102502.1791566-3-patrick.rudolph@9elements.com> (raw)
In-Reply-To: <20220420102502.1791566-1-patrick.rudolph@9elements.com>

There's no working code to poke the WDT2 and it takes too long for the
kernel to load to poke the watchdog. Selecting this Kconfig disables
the WDT2 and prevents 2nd firmware from being launched during normal boot.

Signed-off-by: Patrick Rudolph <patrick.rudolph@9elements.com>
---
 arch/arm/mach-aspeed/ast2500/Kconfig    | 6 ++++++
 arch/arm/mach-aspeed/ast2500/platform.S | 6 ++----
 2 files changed, 8 insertions(+), 4 deletions(-)

diff --git a/arch/arm/mach-aspeed/ast2500/Kconfig b/arch/arm/mach-aspeed/ast2500/Kconfig
index 232117b43c..a9d880e557 100644
--- a/arch/arm/mach-aspeed/ast2500/Kconfig
+++ b/arch/arm/mach-aspeed/ast2500/Kconfig
@@ -33,6 +33,12 @@ config DRAM_UART_TO_UART1
 	help
 	  Route debug UART to TXD1/RXD1 pins.
 
+config FIRMWARE_DISABLE_2ND_BOOT
+	bool
+	prompt "Do not disable WDT2 for 2nd boot function"
+	help
+	  Do not disable WDT2 for 2nd boot function.
+
 source "board/aspeed/evb_ast2500/Kconfig"
 source "board/ibm/genesis3/Kconfig"
 
diff --git a/arch/arm/mach-aspeed/ast2500/platform.S b/arch/arm/mach-aspeed/ast2500/platform.S
index aef55c4a0a..3eb9ee9419 100644
--- a/arch/arm/mach-aspeed/ast2500/platform.S
+++ b/arch/arm/mach-aspeed/ast2500/platform.S
@@ -95,7 +95,7 @@
  *    CONFIG_DDR3_8GSTACK         // DDR3 8Gbit Stack die
  *    CONFIG_DDR4_4GX8            // DDR4 4Gbit X8 dual part
  * 5. Firmware 2nd boot flash
- *    CONFIG_FIRMWARE_2ND_BOOT (Removed)
+ *    CONFIG_FIRMWARE_DISABLE_2ND_BOOT
  * 6. Enable DRAM extended temperature range mode
  *    CONFIG_DRAM_EXT_TEMP
  * 7. Select WDT_Full mode for power up initial reset
@@ -642,13 +642,11 @@ bypass_USB_init:
 /******************************************************************************
  Disable WDT2 for 2nd boot function
  ******************************************************************************/
-/*
-#ifndef CONFIG_FIRMWARE_2ND_BOOT
+#if CONFIG_FIRMWARE_DISABLE_2ND_BOOT
     ldr   r0, =0x1e78502c
     mov   r1, #0
     str   r1, [r0]
 #endif
-*/
 /******************************************************************************
  Disable WDT3 for SPI Address mode (3 or 4 bytes) detection function
  ******************************************************************************/
-- 
2.35.1


  parent reply	other threads:[~2022-04-21  4:26 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-20 10:24 [PATCH u-boot v2019.04-aspeed-openbmc 1/4] arm/dts: Add Genesis3 board Patrick Rudolph
2022-04-20 10:25 ` [PATCH u-boot v2019.04-aspeed-openbmc 2/4] arm/mach-aspeed: Add support for CONFIG_DRAM_UART_TO_UART1 Patrick Rudolph
2022-04-21  5:42   ` Zev Weiss
2022-04-20 10:25 ` Patrick Rudolph [this message]
2022-04-21  5:42   ` [PATCH u-boot v2019.04-aspeed-openbmc 3/4] arm/mach-aspeed: Allow to disable WDT2 Zev Weiss
2022-04-21  5:54     ` Joel Stanley
2022-04-21  8:39       ` Patrick Rudolph
2022-04-20 10:25 ` [PATCH u-boot v2019.04-aspeed-openbmc 4/4] configs: Add IBM Genesis3 defconfig Patrick Rudolph
2022-04-21  5:41 ` [PATCH u-boot v2019.04-aspeed-openbmc 1/4] arm/dts: Add Genesis3 board Zev Weiss
2022-04-21  5:52 ` Joel Stanley
2022-04-21  8:34   ` Patrick Rudolph

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220420102502.1791566-3-patrick.rudolph@9elements.com \
    --to=patrick.rudolph@9elements.com \
    --cc=christian.walter@9elements.com \
    --cc=joel@jms.id.au \
    --cc=openbmc@lists.ozlabs.org \
    --cc=takken@us.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.