All of lore.kernel.org
 help / color / mirror / Atom feed
From: Zev Weiss <zweiss@equinix.com>
To: Patrick Rudolph <patrick.rudolph@9elements.com>
Cc: "christian.walter@9elements.com" <christian.walter@9elements.com>,
	"openbmc@lists.ozlabs.org" <openbmc@lists.ozlabs.org>,
	"takken@us.ibm.com" <takken@us.ibm.com>,
	"joel@jms.id.au" <joel@jms.id.au>
Subject: Re: [PATCH u-boot v2019.04-aspeed-openbmc 2/4] arm/mach-aspeed: Add support for CONFIG_DRAM_UART_TO_UART1
Date: Thu, 21 Apr 2022 05:42:04 +0000	[thread overview]
Message-ID: <20220421054204.GB11809@packtop> (raw)
In-Reply-To: <20220420102502.1791566-2-patrick.rudolph@9elements.com>

On Wed, Apr 20, 2022 at 03:25:00AM PDT, Patrick Rudolph wrote:
>Update the Kconfig and allow a board to use CONFIG_DRAM_UART_TO_UART1.
>This is required on IBM/Genesis3 as it uses RDX1/TDX1 as debug uart.
>

Since I was a bit confused at first at seeing a new Kconfig symbol with
no accompanying code to implement its functionality (until I grepped
around a bit and saw why), it might be nice to note in the commit
message that the logic to support this already exists in the ast2500
platform code and just didn't have an accompanying Kconfig option until
now.

>Signed-off-by: Patrick Rudolph <patrick.rudolph@9elements.com>
>---
> arch/arm/mach-aspeed/ast2500/Kconfig | 6 ++++++
> 1 file changed, 6 insertions(+)
>
>diff --git a/arch/arm/mach-aspeed/ast2500/Kconfig b/arch/arm/mach-aspeed/ast2500/Kconfig
>index 81c4fd0c2f..232117b43c 100644
>--- a/arch/arm/mach-aspeed/ast2500/Kconfig
>+++ b/arch/arm/mach-aspeed/ast2500/Kconfig
>@@ -27,6 +27,12 @@ config TARGET_IBM_GENESIS3
>
> endchoice
>
>+config DRAM_UART_TO_UART1
>+	bool
>+	prompt "Route debug UART to UART1"
>+	help
>+	  Route debug UART to TXD1/RXD1 pins.
>+
> source "board/aspeed/evb_ast2500/Kconfig"
> source "board/ibm/genesis3/Kconfig"
>
>-- 
>2.35.1
>

  reply	other threads:[~2022-04-21  5:43 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-20 10:24 [PATCH u-boot v2019.04-aspeed-openbmc 1/4] arm/dts: Add Genesis3 board Patrick Rudolph
2022-04-20 10:25 ` [PATCH u-boot v2019.04-aspeed-openbmc 2/4] arm/mach-aspeed: Add support for CONFIG_DRAM_UART_TO_UART1 Patrick Rudolph
2022-04-21  5:42   ` Zev Weiss [this message]
2022-04-20 10:25 ` [PATCH u-boot v2019.04-aspeed-openbmc 3/4] arm/mach-aspeed: Allow to disable WDT2 Patrick Rudolph
2022-04-21  5:42   ` Zev Weiss
2022-04-21  5:54     ` Joel Stanley
2022-04-21  8:39       ` Patrick Rudolph
2022-04-20 10:25 ` [PATCH u-boot v2019.04-aspeed-openbmc 4/4] configs: Add IBM Genesis3 defconfig Patrick Rudolph
2022-04-21  5:41 ` [PATCH u-boot v2019.04-aspeed-openbmc 1/4] arm/dts: Add Genesis3 board Zev Weiss
2022-04-21  5:52 ` Joel Stanley
2022-04-21  8:34   ` Patrick Rudolph

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220421054204.GB11809@packtop \
    --to=zweiss@equinix.com \
    --cc=christian.walter@9elements.com \
    --cc=joel@jms.id.au \
    --cc=openbmc@lists.ozlabs.org \
    --cc=patrick.rudolph@9elements.com \
    --cc=takken@us.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.