From: Jason Gunthorpe <jgg@nvidia.com>
To: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Cc: "intel-gfx@lists.freedesktop.org"
<intel-gfx@lists.freedesktop.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
"Vivi, Rodrigo" <rodrigo.vivi@intel.com>,
"intel-gvt-dev@lists.freedesktop.org"
<intel-gvt-dev@lists.freedesktop.org>,
Christoph Hellwig <hch@lst.de>
Subject: Re: [Intel-gfx] [PULL v2] gvt-next
Date: Thu, 21 Apr 2022 10:14:03 -0300 [thread overview]
Message-ID: <20220421131403.GF2120790@nvidia.com> (raw)
In-Reply-To: <165052329083.6597.933445971686511585@jlahtine-mobl.ger.corp.intel.com>
On Thu, Apr 21, 2022 at 09:41:30AM +0300, Joonas Lahtinen wrote:
> + Tvrtko
>
> Quoting Christoph Hellwig (2022-04-21 08:47:38)
> > On Thu, Apr 21, 2022 at 04:57:34AM +0000, Wang, Zhi A wrote:
> > > Is it possible that I can send two different pull based on the same branch?
> > > I was thinking I can remove this line in the original patch and then add a
> > > small patch to add this line back on the top. Then make two different tags
> > > before and after that small patch, send one pull with tag that includes that
> > > small patch to i915 and the other pull with tag that doesn't includes it to
> > > VFIO?
> >
> > Yes, you can do that as long as the small fixup commit is the very last
> > one.
Keep in mind when doing this that best practice is for every commit to
compile.
So if you add a commit with a new #include to this topic branch that
commit will not compile.
Best practice is to fix the compilation breakage in a merge commit,
either created by you or created by your upstream.
Jason
WARNING: multiple messages have this Message-ID (diff)
From: Jason Gunthorpe <jgg@nvidia.com>
To: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>,
"intel-gfx@lists.freedesktop.org"
<intel-gfx@lists.freedesktop.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Alex Williamson <alex.williamson@redhat.com>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
"Vivi, Rodrigo" <rodrigo.vivi@intel.com>,
"intel-gvt-dev@lists.freedesktop.org"
<intel-gvt-dev@lists.freedesktop.org>,
Christoph Hellwig <hch@lst.de>,
"Wang, Zhi A" <zhi.a.wang@intel.com>
Subject: Re: [PULL v2] gvt-next
Date: Thu, 21 Apr 2022 10:14:03 -0300 [thread overview]
Message-ID: <20220421131403.GF2120790@nvidia.com> (raw)
In-Reply-To: <165052329083.6597.933445971686511585@jlahtine-mobl.ger.corp.intel.com>
On Thu, Apr 21, 2022 at 09:41:30AM +0300, Joonas Lahtinen wrote:
> + Tvrtko
>
> Quoting Christoph Hellwig (2022-04-21 08:47:38)
> > On Thu, Apr 21, 2022 at 04:57:34AM +0000, Wang, Zhi A wrote:
> > > Is it possible that I can send two different pull based on the same branch?
> > > I was thinking I can remove this line in the original patch and then add a
> > > small patch to add this line back on the top. Then make two different tags
> > > before and after that small patch, send one pull with tag that includes that
> > > small patch to i915 and the other pull with tag that doesn't includes it to
> > > VFIO?
> >
> > Yes, you can do that as long as the small fixup commit is the very last
> > one.
Keep in mind when doing this that best practice is for every commit to
compile.
So if you add a commit with a new #include to this topic branch that
commit will not compile.
Best practice is to fix the compilation breakage in a merge commit,
either created by you or created by your upstream.
Jason
WARNING: multiple messages have this Message-ID (diff)
From: Jason Gunthorpe <jgg@nvidia.com>
To: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Cc: "Wang, Zhi A" <zhi.a.wang@intel.com>,
Christoph Hellwig <hch@lst.de>,
Alex Williamson <alex.williamson@redhat.com>,
Jani Nikula <jani.nikula@linux.intel.com>,
"Vivi, Rodrigo" <rodrigo.vivi@intel.com>,
Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>,
"intel-gfx@lists.freedesktop.org"
<intel-gfx@lists.freedesktop.org>,
"intel-gvt-dev@lists.freedesktop.org"
<intel-gvt-dev@lists.freedesktop.org>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Zhenyu Wang <zhenyuw@linux.intel.com>
Subject: Re: [PULL v2] gvt-next
Date: Thu, 21 Apr 2022 10:14:03 -0300 [thread overview]
Message-ID: <20220421131403.GF2120790@nvidia.com> (raw)
In-Reply-To: <165052329083.6597.933445971686511585@jlahtine-mobl.ger.corp.intel.com>
On Thu, Apr 21, 2022 at 09:41:30AM +0300, Joonas Lahtinen wrote:
> + Tvrtko
>
> Quoting Christoph Hellwig (2022-04-21 08:47:38)
> > On Thu, Apr 21, 2022 at 04:57:34AM +0000, Wang, Zhi A wrote:
> > > Is it possible that I can send two different pull based on the same branch?
> > > I was thinking I can remove this line in the original patch and then add a
> > > small patch to add this line back on the top. Then make two different tags
> > > before and after that small patch, send one pull with tag that includes that
> > > small patch to i915 and the other pull with tag that doesn't includes it to
> > > VFIO?
> >
> > Yes, you can do that as long as the small fixup commit is the very last
> > one.
Keep in mind when doing this that best practice is for every commit to
compile.
So if you add a commit with a new #include to this topic branch that
commit will not compile.
Best practice is to fix the compilation breakage in a merge commit,
either created by you or created by your upstream.
Jason
next prev parent reply other threads:[~2022-04-21 13:14 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-20 16:34 [Intel-gfx] [PULL v2] gvt-next Wang, Zhi A
2022-04-20 16:34 ` Wang, Zhi A
2022-04-20 16:34 ` Wang, Zhi A
2022-04-20 16:43 ` [Intel-gfx] " Jason Gunthorpe
2022-04-20 16:43 ` Jason Gunthorpe
2022-04-20 16:43 ` Jason Gunthorpe
2022-04-20 17:40 ` [Intel-gfx] " Alex Williamson
2022-04-20 17:40 ` Alex Williamson
2022-04-20 17:40 ` Alex Williamson
2022-04-20 17:46 ` [Intel-gfx] " Jason Gunthorpe
2022-04-20 17:46 ` Jason Gunthorpe
2022-04-20 17:46 ` Jason Gunthorpe
2022-04-20 20:00 ` [Intel-gfx] " Jason Gunthorpe
2022-04-20 20:00 ` Jason Gunthorpe
2022-04-20 20:00 ` Jason Gunthorpe
2022-04-21 4:57 ` [Intel-gfx] " Wang, Zhi A
2022-04-21 4:57 ` Wang, Zhi A
2022-04-21 4:57 ` Wang, Zhi A
2022-04-21 5:47 ` [Intel-gfx] " Christoph Hellwig
2022-04-21 5:47 ` Christoph Hellwig
2022-04-21 6:41 ` [Intel-gfx] " Joonas Lahtinen
2022-04-21 6:41 ` Joonas Lahtinen
2022-04-21 6:41 ` Joonas Lahtinen
2022-04-21 13:14 ` Jason Gunthorpe [this message]
2022-04-21 13:14 ` Jason Gunthorpe
2022-04-21 13:14 ` Jason Gunthorpe
2022-04-21 14:13 ` [Intel-gfx] " Wang, Zhi A
2022-04-21 14:13 ` Wang, Zhi A
2022-04-21 14:13 ` Wang, Zhi A
-- strict thread matches above, loose matches on Subject: below --
2022-04-26 8:37 [Intel-gfx] " Wang, Zhi A
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220421131403.GF2120790@nvidia.com \
--to=jgg@nvidia.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=hch@lst.de \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-gvt-dev@lists.freedesktop.org \
--cc=joonas.lahtinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rodrigo.vivi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.