Re: [PATCH v3 4/4] mtd: phram: Allow cached mappings

From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Vincent Whitchurch <vincent.whitchurch@axis.com>
Cc: kernel test robot <lkp@intel.com>,
	"vigneshr@ti.com" <vigneshr@ti.com>,
	"richard@nod.at" <richard@nod.at>,
	"joern@lazybastard.org" <joern@lazybastard.org>,
	"kbuild-all@lists.01.org" <kbuild-all@lists.01.org>,
	kernel <kernel@axis.com>,
	"linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"robh+dt@kernel.org" <robh+dt@kernel.org>,
	"krzk+dt@kernel.org" <krzk+dt@kernel.org>,
	"frowand.list@gmail.com" <frowand.list@gmail.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 4/4] mtd: phram: Allow cached mappings
Date: Mon, 25 Apr 2022 10:30:15 +0200	[thread overview]
Message-ID: <20220425103015.1cc05f77@xps13> (raw)
In-Reply-To: <20220425102816.54619c66@xps13>

miquel.raynal@bootlin.com wrote on Mon, 25 Apr 2022 10:28:16 +0200:

> Hi Vincent,
> 
> vincent.whitchurch@axis.com wrote on Thu, 14 Apr 2022 11:04:02 +0200:
> 
> > On Wed, Apr 13, 2022 at 08:45:59AM +0200, kernel test robot wrote:  
> > > All errors (new ones prefixed by >>):
> > > 
> > >    In file included from include/linux/io.h:13,
> > >                     from drivers/mtd/devices/phram.c:21:
> > >    drivers/mtd/devices/phram.c: In function 'register_device':    
> > > >> arch/sh/include/asm/io.h:274:33: error: expected expression before 'do'    
> > >      274 | #define iounmap(addr)           do { } while (0)
> > >          |                                 ^~
> > >    drivers/mtd/devices/phram.c:150:44: note: in expansion of macro 'iounmap'
> > >      150 |         cached ? memunmap(new->mtd.priv) : iounmap(new->mtd.priv);
> > >          |                                            ^~~~~~~
> > >    drivers/mtd/devices/phram.c: In function 'phram_remove':    
> > > >> arch/sh/include/asm/io.h:274:33: error: expected expression before 'do'    
> > >      274 | #define iounmap(addr)           do { } while (0)
> > >          |                                 ^~
> > >    drivers/mtd/devices/phram.c:372:53: note: in expansion of macro 'iounmap'
> > >      372 |         phram->cached ? memunmap(phram->mtd.priv) : iounmap(phram->mtd.priv);
> > >          |                                                     ^~~~~~~
> > > 
> > > 
> > > vim +/do +274 arch/sh/include/asm/io.h
> > > 
> > > d57d64080ddc0f Paul Mundt        2010-01-19  272  
> > > 13f1fc870dd747 Christoph Hellwig 2020-07-14  273  #else /* CONFIG_MMU */
> > > 13f1fc870dd747 Christoph Hellwig 2020-07-14 @274  #define iounmap(addr)		do { } while (0)
> > > 13f1fc870dd747 Christoph Hellwig 2020-07-14  275  #define ioremap(offset, size)	((void __iomem *)(unsigned long)(offset))
> > > 13f1fc870dd747 Christoph Hellwig 2020-07-14  276  #endif /* CONFIG_MMU */
> > > d627a2ebd1a303 Paul Mundt        2010-01-28  277      
> > 
> > Thank you for the report.  This patch could certainly be changed to work
> > around this, but ISTM that the right fix is in the SH header file, since
> > the problem could hit in other cases too.  I've posted a fix here now:
> > 
> >  https://lore.kernel.org/lkml/20220414081257.1487499-1-vincent.whitchurch@axis.com/  
> 
> Looks good to me but I don't want to be the one "carrying" new compile
> errors so I'll drop the series for now, until you get this patch
> applied. Please then just resend the series with this thread mentioned
> and I'll take it back.

BTW, I'm only talking about this improvement, patches 1-3 will remain.

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/