All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Yongji Xie <xieyongji@bytedance.com>
Cc: Greg KH <gregkh@linuxfoundation.org>,
	stable@vger.kernel.org,
	virtualization <virtualization@lists.linux-foundation.org>,
	Luis Chamberlain <mcgrof@kernel.org>,
	kernel test robot <oliver.sang@intel.com>,
	Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH v2] vduse: Fix NULL pointer dereference on sysfs access
Date: Tue, 26 Apr 2022 10:38:31 -0400	[thread overview]
Message-ID: <20220426103742-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <CACycT3vLdjH820EBzz+4u5+6JH+hjnFTK1mtSJje9Uq1j_KTdQ@mail.gmail.com>

On Tue, Apr 26, 2022 at 10:37:17PM +0800, Yongji Xie wrote:
> On Tue, Apr 26, 2022 at 10:18 PM Michael S. Tsirkin <mst@redhat.com> wrote:
> >
> > On Tue, Apr 26, 2022 at 10:02:02PM +0800, Yongji Xie wrote:
> > > > This should not be needed, when your module is unloaded, all devices it
> > > > handled should be properly removed by it.
> > > >
> > >
> > > I see. But it's not easy to achieve that currently. Maybe we need
> > > something like DEVICE_NEEDS_RESET support in virtio core.
> >
> > Not sure what the connection is.
> >
> 
> If we want to force remove all working vduse devices during module
> unload, we might need to send a DEVICE_NEEDS_RESET notification to
> device driver to do some cleanup before, e.g., return error for all
> inflight I/Os.
> 
> Thanks,
> Yongji

IMHO DEVICE_NEEDS_RESET won't help much with that, it's more in
case device is still there but needs a reset to start working.

-- 
MST

_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization

WARNING: multiple messages have this Message-ID (diff)
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Yongji Xie <xieyongji@bytedance.com>
Cc: Greg KH <gregkh@linuxfoundation.org>,
	Jason Wang <jasowang@redhat.com>,
	Luis Chamberlain <mcgrof@kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	kernel test robot <oliver.sang@intel.com>,
	virtualization <virtualization@lists.linux-foundation.org>,
	stable@vger.kernel.org
Subject: Re: [PATCH v2] vduse: Fix NULL pointer dereference on sysfs access
Date: Tue, 26 Apr 2022 10:38:31 -0400	[thread overview]
Message-ID: <20220426103742-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <CACycT3vLdjH820EBzz+4u5+6JH+hjnFTK1mtSJje9Uq1j_KTdQ@mail.gmail.com>

On Tue, Apr 26, 2022 at 10:37:17PM +0800, Yongji Xie wrote:
> On Tue, Apr 26, 2022 at 10:18 PM Michael S. Tsirkin <mst@redhat.com> wrote:
> >
> > On Tue, Apr 26, 2022 at 10:02:02PM +0800, Yongji Xie wrote:
> > > > This should not be needed, when your module is unloaded, all devices it
> > > > handled should be properly removed by it.
> > > >
> > >
> > > I see. But it's not easy to achieve that currently. Maybe we need
> > > something like DEVICE_NEEDS_RESET support in virtio core.
> >
> > Not sure what the connection is.
> >
> 
> If we want to force remove all working vduse devices during module
> unload, we might need to send a DEVICE_NEEDS_RESET notification to
> device driver to do some cleanup before, e.g., return error for all
> inflight I/Os.
> 
> Thanks,
> Yongji

IMHO DEVICE_NEEDS_RESET won't help much with that, it's more in
case device is still there but needs a reset to start working.

-- 
MST


  reply	other threads:[~2022-04-26 14:38 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-26  7:36 [PATCH v2] vduse: Fix NULL pointer dereference on sysfs access Xie Yongji
2022-04-26  8:07 ` Greg KH
2022-04-26  8:07   ` Greg KH
2022-04-26  9:41   ` Yongji Xie
2022-04-26 10:26     ` Greg KH
2022-04-26 10:26       ` Greg KH
2022-04-26 12:30       ` Yongji Xie
2022-04-26 12:44         ` Greg KH
2022-04-26 12:44           ` Greg KH
2022-04-26 13:17           ` Yongji Xie
2022-04-26 13:34             ` Greg KH
2022-04-26 13:34               ` Greg KH
2022-04-26 14:02               ` Yongji Xie
2022-04-26 14:09                 ` Greg KH
2022-04-26 14:09                   ` Greg KH
2022-04-26 14:15                   ` Yongji Xie
2022-04-26 14:17                 ` Michael S. Tsirkin
2022-04-26 14:17                   ` Michael S. Tsirkin
2022-04-26 14:37                   ` Yongji Xie
2022-04-26 14:38                     ` Michael S. Tsirkin [this message]
2022-04-26 14:38                       ` Michael S. Tsirkin
2022-04-26 14:50                       ` Yongji Xie
2022-06-08 12:51   ` Michael S. Tsirkin
2022-06-08 12:51     ` Michael S. Tsirkin
2022-06-08 13:25     ` Yongji Xie
2022-06-08 13:26       ` Parav Pandit
2022-06-08 13:26         ` Parav Pandit via Virtualization
2022-06-02  4:55 ` Yongji Xie
2022-06-02  9:51   ` Michael S. Tsirkin
2022-06-02  9:51     ` Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220426103742-mutt-send-email-mst@kernel.org \
    --to=mst@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=mcgrof@kernel.org \
    --cc=oliver.sang@intel.com \
    --cc=stable@vger.kernel.org \
    --cc=virtualization@lists.linux-foundation.org \
    --cc=xieyongji@bytedance.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.