From: Guenter Roeck <linux@roeck-us.net>
To: Brian Norris <briannorris@chromium.org>
Cc: Heiko Stuebner <heiko@sntech.de>, Arnd Bergmann <arnd@arndb.de>,
Robin Murphy <robin.murphy@arm.com>,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 3/3] soc: rockchip: Fix compile-testing SoC drivers
Date: Tue, 26 Apr 2022 13:14:41 -0700 [thread overview]
Message-ID: <20220426201441.GJ4093517@roeck-us.net> (raw)
In-Reply-To: <20220425184503.v3.3.Id5f16dec920f620120c0a143a97a12e16d401760@changeid>
On Mon, Apr 25, 2022 at 06:45:44PM -0700, Brian Norris wrote:
> Similar to commit 7f94b69ece51 ("ARM: ixp4xx: fix compile-testing soc
> drivers").
>
> drivers/soc/rockchip/Kconfig makes plenty of provision for configuring
> drivers either for ARCH_ROCKCHIP or for COMPILE_TEST. But
> drivers/soc/Makefile pulls the rug out from under us, by refusing to
> build anything if we specified COMPILE_TEST but not ARCH_ROCKCHIP.
>
> Currently, I'm not aware of anything that breaks without this patch, but
> it certainly makes for confusing builds (CONFIG_ROCKCHIP_PM_DOMAINS=y,
> but we didn't actually compile the driver?) and leaves room for future
> error (I have pending patches that break confusingly with COMPILE_TEST=y
> even though their Kconfig dependencies seem correct [1]).
>
> Defer to drivers/soc/rockchip/{Makefile,Kconfig} to do the right thing.
>
> [1] e.g.,
> https://lore.kernel.org/linux-rockchip/20220405184816.RFC.2.I2d73b403944f0b8b5871a77585b73f31ccc62999@changeid/
> [RFC PATCH 2/2] PM / devfreq: rk3399_dmc: Block PMU during transitions
>
> Signed-off-by: Brian Norris <briannorris@chromium.org>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> ---
>
> Changes in v3:
> * Drop ARM||ARM64 dependency, now that bare dsb()s have been removed
>
> Changes in v2:
> * Depend on ARM||ARM64
>
> drivers/soc/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/soc/Makefile b/drivers/soc/Makefile
> index fd7717d597fc..4c91705a8bb3 100644
> --- a/drivers/soc/Makefile
> +++ b/drivers/soc/Makefile
> @@ -23,7 +23,7 @@ obj-y += pxa/
> obj-y += amlogic/
> obj-y += qcom/
> obj-y += renesas/
> -obj-$(CONFIG_ARCH_ROCKCHIP) += rockchip/
> +obj-y += rockchip/
> obj-$(CONFIG_SOC_SAMSUNG) += samsung/
> obj-$(CONFIG_SOC_SIFIVE) += sifive/
> obj-y += sunxi/
> --
> 2.36.0.rc2.479.g8af0fa9b8e-goog
>
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
WARNING: multiple messages have this Message-ID (diff)
From: Guenter Roeck <linux@roeck-us.net>
To: Brian Norris <briannorris@chromium.org>
Cc: Heiko Stuebner <heiko@sntech.de>, Arnd Bergmann <arnd@arndb.de>,
Robin Murphy <robin.murphy@arm.com>,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 3/3] soc: rockchip: Fix compile-testing SoC drivers
Date: Tue, 26 Apr 2022 13:14:41 -0700 [thread overview]
Message-ID: <20220426201441.GJ4093517@roeck-us.net> (raw)
In-Reply-To: <20220425184503.v3.3.Id5f16dec920f620120c0a143a97a12e16d401760@changeid>
On Mon, Apr 25, 2022 at 06:45:44PM -0700, Brian Norris wrote:
> Similar to commit 7f94b69ece51 ("ARM: ixp4xx: fix compile-testing soc
> drivers").
>
> drivers/soc/rockchip/Kconfig makes plenty of provision for configuring
> drivers either for ARCH_ROCKCHIP or for COMPILE_TEST. But
> drivers/soc/Makefile pulls the rug out from under us, by refusing to
> build anything if we specified COMPILE_TEST but not ARCH_ROCKCHIP.
>
> Currently, I'm not aware of anything that breaks without this patch, but
> it certainly makes for confusing builds (CONFIG_ROCKCHIP_PM_DOMAINS=y,
> but we didn't actually compile the driver?) and leaves room for future
> error (I have pending patches that break confusingly with COMPILE_TEST=y
> even though their Kconfig dependencies seem correct [1]).
>
> Defer to drivers/soc/rockchip/{Makefile,Kconfig} to do the right thing.
>
> [1] e.g.,
> https://lore.kernel.org/linux-rockchip/20220405184816.RFC.2.I2d73b403944f0b8b5871a77585b73f31ccc62999@changeid/
> [RFC PATCH 2/2] PM / devfreq: rk3399_dmc: Block PMU during transitions
>
> Signed-off-by: Brian Norris <briannorris@chromium.org>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> ---
>
> Changes in v3:
> * Drop ARM||ARM64 dependency, now that bare dsb()s have been removed
>
> Changes in v2:
> * Depend on ARM||ARM64
>
> drivers/soc/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/soc/Makefile b/drivers/soc/Makefile
> index fd7717d597fc..4c91705a8bb3 100644
> --- a/drivers/soc/Makefile
> +++ b/drivers/soc/Makefile
> @@ -23,7 +23,7 @@ obj-y += pxa/
> obj-y += amlogic/
> obj-y += qcom/
> obj-y += renesas/
> -obj-$(CONFIG_ARCH_ROCKCHIP) += rockchip/
> +obj-y += rockchip/
> obj-$(CONFIG_SOC_SAMSUNG) += samsung/
> obj-$(CONFIG_SOC_SIFIVE) += sifive/
> obj-y += sunxi/
> --
> 2.36.0.rc2.479.g8af0fa9b8e-goog
>
next prev parent reply other threads:[~2022-04-26 20:14 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-26 1:45 [PATCH v3 1/3] soc: rockchip: Clean up Kconfig whitespace Brian Norris
2022-04-26 1:45 ` Brian Norris
2022-04-26 1:45 ` [PATCH v3 2/3] soc: rockchip: power-domain: Replace dsb() with smb() Brian Norris
2022-04-26 1:45 ` Brian Norris
2022-04-26 20:14 ` Guenter Roeck
2022-04-26 20:14 ` Guenter Roeck
2022-04-26 23:55 ` Peter Geis
2022-04-26 23:55 ` Peter Geis
2022-04-27 0:25 ` Robin Murphy
2022-04-27 0:25 ` Robin Murphy
2022-04-27 21:47 ` Brian Norris
2022-04-27 21:47 ` Brian Norris
2022-04-26 1:45 ` [PATCH v3 3/3] soc: rockchip: Fix compile-testing SoC drivers Brian Norris
2022-04-26 1:45 ` Brian Norris
2022-04-26 20:14 ` Guenter Roeck [this message]
2022-04-26 20:14 ` Guenter Roeck
2022-04-26 20:13 ` [PATCH v3 1/3] soc: rockchip: Clean up Kconfig whitespace Guenter Roeck
2022-04-26 20:13 ` Guenter Roeck
2022-04-30 14:05 ` Heiko Stuebner
2022-04-30 14:05 ` Heiko Stuebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220426201441.GJ4093517@roeck-us.net \
--to=linux@roeck-us.net \
--cc=arnd@arndb.de \
--cc=briannorris@chromium.org \
--cc=heiko@sntech.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=robin.murphy@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.