All of lore.kernel.org
 help / color / mirror / Atom feed
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Chuanhong Guo <gch981213@gmail.com>
Cc: linux-spi@vger.kernel.org, Mark Brown <broonie@kernel.org>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	Richard Weinberger <richard@nod.at>,
	Vignesh Raghavendra <vigneshr@ti.com>,
	Roger Quadros <rogerq@kernel.org>,
	Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
	Cai Huoqing <cai.huoqing@linux.dev>,
	Florian Fainelli <f.fainelli@gmail.com>,
	Colin Ian King <colin.king@intel.com>,
	Wolfram Sang <wsa+renesas@sang-engineering.com>,
	Paul Cercueil <paul@crapouillou.net>,
	Pratyush Yadav <p.yadav@ti.com>, Yu Kuai <yukuai3@huawei.com>,
	devicetree@vger.kernel.org (open list:OPEN FIRMWARE AND
	FLATTENED DEVICE TREE BINDINGS),
	linux-arm-kernel@lists.infradead.org (moderated
	list:ARM/Mediatek SoC support),
	linux-mediatek@lists.infradead.org (moderated list:ARM/Mediatek
	SoC support), linux-kernel@vger.kernel.org (open list),
	linux-mtd@lists.infradead.org (open list:NAND FLASH SUBSYSTEM)
Subject: Re: [PATCH v6 0/5] spi: add support for Mediatek SPI-NAND controller
Date: Wed, 27 Apr 2022 11:28:57 +0200	[thread overview]
Message-ID: <20220427112857.7ddd7fc8@xps13> (raw)
In-Reply-To: <20220424032527.673605-1-gch981213@gmail.com>

Hi Mark,

gch981213@gmail.com wrote on Sun, 24 Apr 2022 11:25:22 +0800:

> Mediatek has an extended version of their NAND Flash Interface which
> has a SPI-NAND mode. In this mode, the controller can perform 1-bit
> spi-mem ops for up-to 0xa0 bytes and typical SPI-NAND single, dual
> and quad IO page cache ops with 2-byte address. Additionally, the
> page cache ops can be performed with ECC and auto data formatting
> using the ECC engine of the controller.
> 
> This patchset implements support of this mode as a separated SPI-MEM
> driver with pipelined ECC engine.


[...]

The patch actually look independent, so if it's fine for you I can take
the two mtd patches and let you merge the spi/binding changes.

Would this work for you?

> Chuanhong Guo (5):
>   mtd: nand: make mtk_ecc.c a separated module
>   spi: add driver for MTK SPI NAND Flash Interface
>   mtd: nand: mtk-ecc: also parse nand-ecc-engine if available
>   spi: dt-bindings: add binding doc for spi-mtk-snfi
>   arm64: dts: mediatek: add mtk-snfi for mt7622
> 
>  .../bindings/spi/mediatek,spi-mtk-snfi.yaml   |   88 +
>  arch/arm64/boot/dts/mediatek/mt7622.dtsi      |   12 +
>  drivers/mtd/nand/Kconfig                      |    7 +
>  drivers/mtd/nand/Makefile                     |    1 +
>  drivers/mtd/nand/{raw/mtk_ecc.c => ecc-mtk.c} |    8 +-
>  drivers/mtd/nand/raw/Kconfig                  |    1 +
>  drivers/mtd/nand/raw/Makefile                 |    2 +-
>  drivers/mtd/nand/raw/mtk_nand.c               |    2 +-
>  drivers/spi/Kconfig                           |   10 +
>  drivers/spi/Makefile                          |    1 +
>  drivers/spi/spi-mtk-snfi.c                    | 1470 +++++++++++++++++
>  .../linux/mtd/nand-ecc-mtk.h                  |    0
>  12 files changed, 1597 insertions(+), 5 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/spi/mediatek,spi-mtk-snfi.yaml
>  rename drivers/mtd/nand/{raw/mtk_ecc.c => ecc-mtk.c} (98%)
>  create mode 100644 drivers/spi/spi-mtk-snfi.c
>  rename drivers/mtd/nand/raw/mtk_ecc.h => include/linux/mtd/nand-ecc-mtk.h (100%)
> 


Thanks,
Miquèl

_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek

WARNING: multiple messages have this Message-ID (diff)
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Chuanhong Guo <gch981213@gmail.com>
Cc: linux-spi@vger.kernel.org, Mark Brown <broonie@kernel.org>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	Richard Weinberger <richard@nod.at>,
	Vignesh Raghavendra <vigneshr@ti.com>,
	Roger Quadros <rogerq@kernel.org>,
	Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
	Cai Huoqing <cai.huoqing@linux.dev>,
	Florian Fainelli <f.fainelli@gmail.com>,
	Colin Ian King <colin.king@intel.com>,
	Wolfram Sang <wsa+renesas@sang-engineering.com>,
	Paul Cercueil <paul@crapouillou.net>,
	Pratyush Yadav <p.yadav@ti.com>, Yu Kuai <yukuai3@huawei.com>,
	devicetree@vger.kernel.org (open list:OPEN FIRMWARE AND
	FLATTENED DEVICE TREE BINDINGS),
	linux-arm-kernel@lists.infradead.org (moderated
	list:ARM/Mediatek SoC support),
	linux-mediatek@lists.infradead.org (moderated list:ARM/Mediatek
	SoC support), linux-kernel@vger.kernel.org (open list),
	linux-mtd@lists.infradead.org (open list:NAND FLASH SUBSYSTEM)
Subject: Re: [PATCH v6 0/5] spi: add support for Mediatek SPI-NAND controller
Date: Wed, 27 Apr 2022 11:28:57 +0200	[thread overview]
Message-ID: <20220427112857.7ddd7fc8@xps13> (raw)
In-Reply-To: <20220424032527.673605-1-gch981213@gmail.com>

Hi Mark,

gch981213@gmail.com wrote on Sun, 24 Apr 2022 11:25:22 +0800:

> Mediatek has an extended version of their NAND Flash Interface which
> has a SPI-NAND mode. In this mode, the controller can perform 1-bit
> spi-mem ops for up-to 0xa0 bytes and typical SPI-NAND single, dual
> and quad IO page cache ops with 2-byte address. Additionally, the
> page cache ops can be performed with ECC and auto data formatting
> using the ECC engine of the controller.
> 
> This patchset implements support of this mode as a separated SPI-MEM
> driver with pipelined ECC engine.


[...]

The patch actually look independent, so if it's fine for you I can take
the two mtd patches and let you merge the spi/binding changes.

Would this work for you?

> Chuanhong Guo (5):
>   mtd: nand: make mtk_ecc.c a separated module
>   spi: add driver for MTK SPI NAND Flash Interface
>   mtd: nand: mtk-ecc: also parse nand-ecc-engine if available
>   spi: dt-bindings: add binding doc for spi-mtk-snfi
>   arm64: dts: mediatek: add mtk-snfi for mt7622
> 
>  .../bindings/spi/mediatek,spi-mtk-snfi.yaml   |   88 +
>  arch/arm64/boot/dts/mediatek/mt7622.dtsi      |   12 +
>  drivers/mtd/nand/Kconfig                      |    7 +
>  drivers/mtd/nand/Makefile                     |    1 +
>  drivers/mtd/nand/{raw/mtk_ecc.c => ecc-mtk.c} |    8 +-
>  drivers/mtd/nand/raw/Kconfig                  |    1 +
>  drivers/mtd/nand/raw/Makefile                 |    2 +-
>  drivers/mtd/nand/raw/mtk_nand.c               |    2 +-
>  drivers/spi/Kconfig                           |   10 +
>  drivers/spi/Makefile                          |    1 +
>  drivers/spi/spi-mtk-snfi.c                    | 1470 +++++++++++++++++
>  .../linux/mtd/nand-ecc-mtk.h                  |    0
>  12 files changed, 1597 insertions(+), 5 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/spi/mediatek,spi-mtk-snfi.yaml
>  rename drivers/mtd/nand/{raw/mtk_ecc.c => ecc-mtk.c} (98%)
>  create mode 100644 drivers/spi/spi-mtk-snfi.c
>  rename drivers/mtd/nand/raw/mtk_ecc.h => include/linux/mtd/nand-ecc-mtk.h (100%)
> 


Thanks,
Miquèl

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

WARNING: multiple messages have this Message-ID (diff)
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Chuanhong Guo <gch981213@gmail.com>
Cc: linux-spi@vger.kernel.org, Mark Brown <broonie@kernel.org>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	Richard Weinberger <richard@nod.at>,
	Vignesh Raghavendra <vigneshr@ti.com>,
	Roger Quadros <rogerq@kernel.org>,
	Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
	Cai Huoqing <cai.huoqing@linux.dev>,
	Florian Fainelli <f.fainelli@gmail.com>,
	Colin Ian King <colin.king@intel.com>,
	Wolfram Sang <wsa+renesas@sang-engineering.com>,
	Paul Cercueil <paul@crapouillou.net>,
	Pratyush Yadav <p.yadav@ti.com>, Yu Kuai <yukuai3@huawei.com>,
	devicetree@vger.kernel.org (open list:OPEN FIRMWARE AND
	FLATTENED DEVICE TREE BINDINGS),
	linux-arm-kernel@lists.infradead.org (moderated
	list:ARM/Mediatek SoC support),
	linux-mediatek@lists.infradead.org (moderated list:ARM/Mediatek
	SoC support), linux-kernel@vger.kernel.org (open list),
	linux-mtd@lists.infradead.org (open list:NAND FLASH SUBSYSTEM)
Subject: Re: [PATCH v6 0/5] spi: add support for Mediatek SPI-NAND controller
Date: Wed, 27 Apr 2022 11:28:57 +0200	[thread overview]
Message-ID: <20220427112857.7ddd7fc8@xps13> (raw)
In-Reply-To: <20220424032527.673605-1-gch981213@gmail.com>

Hi Mark,

gch981213@gmail.com wrote on Sun, 24 Apr 2022 11:25:22 +0800:

> Mediatek has an extended version of their NAND Flash Interface which
> has a SPI-NAND mode. In this mode, the controller can perform 1-bit
> spi-mem ops for up-to 0xa0 bytes and typical SPI-NAND single, dual
> and quad IO page cache ops with 2-byte address. Additionally, the
> page cache ops can be performed with ECC and auto data formatting
> using the ECC engine of the controller.
> 
> This patchset implements support of this mode as a separated SPI-MEM
> driver with pipelined ECC engine.


[...]

The patch actually look independent, so if it's fine for you I can take
the two mtd patches and let you merge the spi/binding changes.

Would this work for you?

> Chuanhong Guo (5):
>   mtd: nand: make mtk_ecc.c a separated module
>   spi: add driver for MTK SPI NAND Flash Interface
>   mtd: nand: mtk-ecc: also parse nand-ecc-engine if available
>   spi: dt-bindings: add binding doc for spi-mtk-snfi
>   arm64: dts: mediatek: add mtk-snfi for mt7622
> 
>  .../bindings/spi/mediatek,spi-mtk-snfi.yaml   |   88 +
>  arch/arm64/boot/dts/mediatek/mt7622.dtsi      |   12 +
>  drivers/mtd/nand/Kconfig                      |    7 +
>  drivers/mtd/nand/Makefile                     |    1 +
>  drivers/mtd/nand/{raw/mtk_ecc.c => ecc-mtk.c} |    8 +-
>  drivers/mtd/nand/raw/Kconfig                  |    1 +
>  drivers/mtd/nand/raw/Makefile                 |    2 +-
>  drivers/mtd/nand/raw/mtk_nand.c               |    2 +-
>  drivers/spi/Kconfig                           |   10 +
>  drivers/spi/Makefile                          |    1 +
>  drivers/spi/spi-mtk-snfi.c                    | 1470 +++++++++++++++++
>  .../linux/mtd/nand-ecc-mtk.h                  |    0
>  12 files changed, 1597 insertions(+), 5 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/spi/mediatek,spi-mtk-snfi.yaml
>  rename drivers/mtd/nand/{raw/mtk_ecc.c => ecc-mtk.c} (98%)
>  create mode 100644 drivers/spi/spi-mtk-snfi.c
>  rename drivers/mtd/nand/raw/mtk_ecc.h => include/linux/mtd/nand-ecc-mtk.h (100%)
> 


Thanks,
Miquèl

WARNING: multiple messages have this Message-ID (diff)
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Chuanhong Guo <gch981213@gmail.com>
Cc: linux-spi@vger.kernel.org, Mark Brown <broonie@kernel.org>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	Richard Weinberger <richard@nod.at>,
	Vignesh Raghavendra <vigneshr@ti.com>,
	Roger Quadros <rogerq@kernel.org>,
	Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
	Cai Huoqing <cai.huoqing@linux.dev>,
	Florian Fainelli <f.fainelli@gmail.com>,
	Colin Ian King <colin.king@intel.com>,
	Wolfram Sang <wsa+renesas@sang-engineering.com>,
	Paul Cercueil <paul@crapouillou.net>,
	Pratyush Yadav <p.yadav@ti.com>, Yu Kuai <yukuai3@huawei.com>,
	devicetree@vger.kernel.org (open list:OPEN FIRMWARE AND
	FLATTENED DEVICE TREE BINDINGS),
	linux-arm-kernel@lists.infradead.org (moderated
	list:ARM/Mediatek SoC support),
	linux-mediatek@lists.infradead.org (moderated list:ARM/Mediatek
	SoC support), linux-kernel@vger.kernel.org (open list),
	linux-mtd@lists.infradead.org (open list:NAND FLASH SUBSYSTEM)
Subject: Re: [PATCH v6 0/5] spi: add support for Mediatek SPI-NAND controller
Date: Wed, 27 Apr 2022 11:28:57 +0200	[thread overview]
Message-ID: <20220427112857.7ddd7fc8@xps13> (raw)
In-Reply-To: <20220424032527.673605-1-gch981213@gmail.com>

Hi Mark,

gch981213@gmail.com wrote on Sun, 24 Apr 2022 11:25:22 +0800:

> Mediatek has an extended version of their NAND Flash Interface which
> has a SPI-NAND mode. In this mode, the controller can perform 1-bit
> spi-mem ops for up-to 0xa0 bytes and typical SPI-NAND single, dual
> and quad IO page cache ops with 2-byte address. Additionally, the
> page cache ops can be performed with ECC and auto data formatting
> using the ECC engine of the controller.
> 
> This patchset implements support of this mode as a separated SPI-MEM
> driver with pipelined ECC engine.


[...]

The patch actually look independent, so if it's fine for you I can take
the two mtd patches and let you merge the spi/binding changes.

Would this work for you?

> Chuanhong Guo (5):
>   mtd: nand: make mtk_ecc.c a separated module
>   spi: add driver for MTK SPI NAND Flash Interface
>   mtd: nand: mtk-ecc: also parse nand-ecc-engine if available
>   spi: dt-bindings: add binding doc for spi-mtk-snfi
>   arm64: dts: mediatek: add mtk-snfi for mt7622
> 
>  .../bindings/spi/mediatek,spi-mtk-snfi.yaml   |   88 +
>  arch/arm64/boot/dts/mediatek/mt7622.dtsi      |   12 +
>  drivers/mtd/nand/Kconfig                      |    7 +
>  drivers/mtd/nand/Makefile                     |    1 +
>  drivers/mtd/nand/{raw/mtk_ecc.c => ecc-mtk.c} |    8 +-
>  drivers/mtd/nand/raw/Kconfig                  |    1 +
>  drivers/mtd/nand/raw/Makefile                 |    2 +-
>  drivers/mtd/nand/raw/mtk_nand.c               |    2 +-
>  drivers/spi/Kconfig                           |   10 +
>  drivers/spi/Makefile                          |    1 +
>  drivers/spi/spi-mtk-snfi.c                    | 1470 +++++++++++++++++
>  .../linux/mtd/nand-ecc-mtk.h                  |    0
>  12 files changed, 1597 insertions(+), 5 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/spi/mediatek,spi-mtk-snfi.yaml
>  rename drivers/mtd/nand/{raw/mtk_ecc.c => ecc-mtk.c} (98%)
>  create mode 100644 drivers/spi/spi-mtk-snfi.c
>  rename drivers/mtd/nand/raw/mtk_ecc.h => include/linux/mtd/nand-ecc-mtk.h (100%)
> 


Thanks,
Miquèl

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2022-04-27  9:29 UTC|newest]

Thread overview: 56+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-24  3:25 [PATCH v6 0/5] spi: add support for Mediatek SPI-NAND controller Chuanhong Guo
2022-04-24  3:25 ` Chuanhong Guo
2022-04-24  3:25 ` Chuanhong Guo
2022-04-24  3:25 ` Chuanhong Guo
2022-04-24  3:25 ` [PATCH v6 1/5] mtd: nand: make mtk_ecc.c a separated module Chuanhong Guo
2022-04-24  3:25   ` Chuanhong Guo
2022-04-24  3:25   ` Chuanhong Guo
2022-04-24  3:25   ` Chuanhong Guo
2022-04-24  3:25 ` [PATCH v6 2/5] spi: add driver for MTK SPI NAND Flash Interface Chuanhong Guo
2022-04-24  3:25   ` Chuanhong Guo
2022-04-24  3:25   ` Chuanhong Guo
2022-04-24  3:25   ` Chuanhong Guo
2022-04-24  3:25 ` [PATCH v6 3/5] mtd: nand: mtk-ecc: also parse nand-ecc-engine if available Chuanhong Guo
2022-04-24  3:25   ` Chuanhong Guo
2022-04-24  3:25   ` Chuanhong Guo
2022-04-24  3:25   ` Chuanhong Guo
2022-04-24  3:25 ` [PATCH v6 4/5] spi: dt-bindings: add binding doc for spi-mtk-snfi Chuanhong Guo
2022-04-24  3:25   ` Chuanhong Guo
2022-04-24  3:25   ` Chuanhong Guo
2022-04-24  3:25   ` Chuanhong Guo
2022-04-24  3:25 ` [PATCH v6 5/5] arm64: dts: mediatek: add mtk-snfi for mt7622 Chuanhong Guo
2022-04-24  3:25   ` Chuanhong Guo
2022-04-24  3:25   ` Chuanhong Guo
2022-04-24  3:25   ` Chuanhong Guo
2022-04-29 14:07   ` Matthias Brugger
2022-04-29 14:07     ` Matthias Brugger
2022-04-29 14:07     ` Matthias Brugger
2022-04-29 14:07     ` Matthias Brugger
2022-04-27  9:28 ` Miquel Raynal [this message]
2022-04-27  9:28   ` [PATCH v6 0/5] spi: add support for Mediatek SPI-NAND controller Miquel Raynal
2022-04-27  9:28   ` Miquel Raynal
2022-04-27  9:28   ` Miquel Raynal
2022-04-27 13:11   ` Mark Brown
2022-04-27 13:11     ` Mark Brown
2022-04-27 13:11     ` Mark Brown
2022-04-27 13:11     ` Mark Brown
2022-04-27 14:04   ` Chuanhong Guo
2022-04-27 14:04     ` Chuanhong Guo
2022-04-27 14:04     ` Chuanhong Guo
2022-04-27 14:04     ` Chuanhong Guo
2022-04-27 14:13     ` Mark Brown
2022-04-27 14:13       ` Mark Brown
2022-04-27 14:13       ` Mark Brown
2022-04-27 14:13       ` Mark Brown
2022-04-27 15:13       ` Miquel Raynal
2022-04-27 15:13         ` Miquel Raynal
2022-04-27 15:13         ` Miquel Raynal
2022-04-27 15:13         ` Miquel Raynal
2022-04-27 16:17       ` Miquel Raynal
2022-04-27 16:17         ` Miquel Raynal
2022-04-27 16:17         ` Miquel Raynal
2022-04-27 16:17         ` Miquel Raynal
2022-04-27 22:06 ` (subset) " Mark Brown
2022-04-27 22:06   ` Mark Brown
2022-04-27 22:06   ` Mark Brown
2022-04-27 22:06   ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220427112857.7ddd7fc8@xps13 \
    --to=miquel.raynal@bootlin.com \
    --cc=broonie@kernel.org \
    --cc=cai.huoqing@linux.dev \
    --cc=colin.king@intel.com \
    --cc=devicetree@vger.kernel.org \
    --cc=f.fainelli@gmail.com \
    --cc=gch981213@gmail.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=matthias.bgg@gmail.com \
    --cc=p.yadav@ti.com \
    --cc=paul@crapouillou.net \
    --cc=richard@nod.at \
    --cc=robh+dt@kernel.org \
    --cc=rogerq@kernel.org \
    --cc=tsbogend@alpha.franken.de \
    --cc=vigneshr@ti.com \
    --cc=wsa+renesas@sang-engineering.com \
    --cc=yukuai3@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.