All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nitesh Shetty <nj.shetty@samsung.com>
To: Damien Le Moal <damien.lemoal@opensource.wdc.com>
Cc: linux-scsi@vger.kernel.org, nitheshshetty@gmail.com,
	linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org,
	linux-block@vger.kernel.org, dm-devel@redhat.com,
	linux-fsdevel@vger.kernel.org
Subject: Re: [dm-devel] [PATCH v4 03/10] block: Introduce a new ioctl for copy
Date: Wed, 27 Apr 2022 18:33:15 +0530	[thread overview]
Message-ID: <20220427130315.GB9558@test-zns> (raw)
In-Reply-To: <513edc25-1c73-6c85-9a50-0e267a106ec0@opensource.wdc.com>

[-- Attachment #1: Type: text/plain, Size: 1908 bytes --]

O Wed, Apr 27, 2022 at 11:48:57AM +0900, Damien Le Moal wrote:
> On 4/26/22 19:12, Nitesh Shetty wrote:
> > Add new BLKCOPY ioctl that offloads copying of one or more sources ranges
> > to one or more destination in a device. COPY ioctl accepts a 'copy_range'
> > structure that contains no of range, a reserved field , followed by an
> > array of ranges. Each source range is represented by 'range_entry' that
> > contains source start offset, destination start offset and length of
> > source ranges (in bytes)
> > 
> > MAX_COPY_NR_RANGE, limits the number of entries for the IOCTL and
> > MAX_COPY_TOTAL_LENGTH limits the total copy length, IOCTL can handle.
> > 
> > Example code, to issue BLKCOPY:
> > /* Sample example to copy three entries with [dest,src,len],
> > * [32768, 0, 4096] [36864, 4096, 4096] [40960,8192,4096] on same device */
> > 
> > int main(void)
> > {
> > 	int i, ret, fd;
> > 	unsigned long src = 0, dst = 32768, len = 4096;
> > 	struct copy_range *cr;
> > 	cr = (struct copy_range *)malloc(sizeof(*cr)+
> > 					(sizeof(struct range_entry)*3));
> > 	cr->nr_range = 3;
> > 	cr->reserved = 0;
> > 	for (i = 0; i< cr->nr_range; i++, src += len, dst += len) {
> > 		cr->range_list[i].dst = dst;
> > 		cr->range_list[i].src = src;
> > 		cr->range_list[i].len = len;
> > 		cr->range_list[i].comp_len = 0;
> > 	}
> > 	fd = open("/dev/nvme0n1", O_RDWR);
> > 	if (fd < 0) return 1;
> > 	ret = ioctl(fd, BLKCOPY, cr);
> > 	if (ret != 0)
> > 	       printf("copy failed, ret= %d\n", ret);
> > 	for (i=0; i< cr->nr_range; i++)
> > 		if (cr->range_list[i].len != cr->range_list[i].comp_len)
> > 			printf("Partial copy for entry %d: requested %llu, completed %llu\n",
> > 								i, cr->range_list[i].len,
> > 								cr->range_list[i].comp_len);
> > 	close(fd);
> > 	free(cr);
> > 	return ret;
> > }
> 
> Nice to have a code example. But please format it correctly.
>

acked

--
Nitesh Shetty

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]



[-- Attachment #3: Type: text/plain, Size: 98 bytes --]

--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel

WARNING: multiple messages have this Message-ID (diff)
From: Nitesh Shetty <nj.shetty@samsung.com>
To: Damien Le Moal <damien.lemoal@opensource.wdc.com>
Cc: linux-block@vger.kernel.org, linux-scsi@vger.kernel.org,
	dm-devel@redhat.com, linux-nvme@lists.infradead.org,
	linux-fsdevel@vger.kernel.org, nitheshshetty@gmail.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 03/10] block: Introduce a new ioctl for copy
Date: Wed, 27 Apr 2022 18:33:15 +0530	[thread overview]
Message-ID: <20220427130315.GB9558@test-zns> (raw)
In-Reply-To: <513edc25-1c73-6c85-9a50-0e267a106ec0@opensource.wdc.com>

[-- Attachment #1: Type: text/plain, Size: 1908 bytes --]

O Wed, Apr 27, 2022 at 11:48:57AM +0900, Damien Le Moal wrote:
> On 4/26/22 19:12, Nitesh Shetty wrote:
> > Add new BLKCOPY ioctl that offloads copying of one or more sources ranges
> > to one or more destination in a device. COPY ioctl accepts a 'copy_range'
> > structure that contains no of range, a reserved field , followed by an
> > array of ranges. Each source range is represented by 'range_entry' that
> > contains source start offset, destination start offset and length of
> > source ranges (in bytes)
> > 
> > MAX_COPY_NR_RANGE, limits the number of entries for the IOCTL and
> > MAX_COPY_TOTAL_LENGTH limits the total copy length, IOCTL can handle.
> > 
> > Example code, to issue BLKCOPY:
> > /* Sample example to copy three entries with [dest,src,len],
> > * [32768, 0, 4096] [36864, 4096, 4096] [40960,8192,4096] on same device */
> > 
> > int main(void)
> > {
> > 	int i, ret, fd;
> > 	unsigned long src = 0, dst = 32768, len = 4096;
> > 	struct copy_range *cr;
> > 	cr = (struct copy_range *)malloc(sizeof(*cr)+
> > 					(sizeof(struct range_entry)*3));
> > 	cr->nr_range = 3;
> > 	cr->reserved = 0;
> > 	for (i = 0; i< cr->nr_range; i++, src += len, dst += len) {
> > 		cr->range_list[i].dst = dst;
> > 		cr->range_list[i].src = src;
> > 		cr->range_list[i].len = len;
> > 		cr->range_list[i].comp_len = 0;
> > 	}
> > 	fd = open("/dev/nvme0n1", O_RDWR);
> > 	if (fd < 0) return 1;
> > 	ret = ioctl(fd, BLKCOPY, cr);
> > 	if (ret != 0)
> > 	       printf("copy failed, ret= %d\n", ret);
> > 	for (i=0; i< cr->nr_range; i++)
> > 		if (cr->range_list[i].len != cr->range_list[i].comp_len)
> > 			printf("Partial copy for entry %d: requested %llu, completed %llu\n",
> > 								i, cr->range_list[i].len,
> > 								cr->range_list[i].comp_len);
> > 	close(fd);
> > 	free(cr);
> > 	return ret;
> > }
> 
> Nice to have a code example. But please format it correctly.
>

acked

--
Nitesh Shetty

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]



  reply	other threads:[~2022-04-29  8:24 UTC|newest]

Thread overview: 101+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20220426101804epcas5p4a0a325d3ce89e868e4924bbdeeba6d15@epcas5p4.samsung.com>
2022-04-26 10:12 ` [dm-devel] [PATCH v4 00/10] Add Copy offload support Nitesh Shetty
2022-04-26 10:12   ` Nitesh Shetty
2022-04-26 10:12   ` Nitesh Shetty
2022-04-26 10:12   ` [dm-devel] [PATCH v4 01/10] block: Introduce queue limits for copy-offload support Nitesh Shetty
2022-04-26 10:12     ` Nitesh Shetty
2022-04-26 10:12     ` Nitesh Shetty
2022-04-27  1:59     ` [dm-devel] " Damien Le Moal
2022-04-27  1:59       ` Damien Le Moal
2022-04-27 15:30       ` [dm-devel] " Nitesh Shetty
2022-04-27 15:30         ` Nitesh Shetty
2022-04-27 21:57         ` [dm-devel] " Damien Le Moal
2022-04-27 21:57           ` Damien Le Moal
2022-04-27 10:30     ` [dm-devel] " Hannes Reinecke
2022-04-27 10:30       ` Hannes Reinecke
2022-04-26 10:12   ` [dm-devel] [PATCH v4 02/10] block: Add copy offload support infrastructure Nitesh Shetty
2022-04-26 10:12     ` Nitesh Shetty
2022-04-26 10:12     ` Nitesh Shetty
2022-04-27  0:11     ` [dm-devel] " kernel test robot
2022-04-27  0:11       ` kernel test robot
2022-04-27  2:45     ` [dm-devel] " Damien Le Moal
2022-04-27  2:45       ` Damien Le Moal
2022-04-27 15:15       ` [dm-devel] " Nitesh Shetty
2022-04-27 15:15         ` Nitesh Shetty
2022-04-27 22:04         ` [dm-devel] " Damien Le Moal
2022-04-27 22:04           ` Damien Le Moal
2022-04-28  8:01           ` [dm-devel] " Nitesh Shetty
2022-04-28  8:01             ` Nitesh Shetty
2022-04-27 10:29     ` [dm-devel] " Hannes Reinecke
2022-04-27 10:29       ` Hannes Reinecke
2022-04-27 15:48       ` [dm-devel] " Nitesh Shetty
2022-04-27 15:48         ` Nitesh Shetty
2022-04-26 10:12   ` [dm-devel] [PATCH v4 03/10] block: Introduce a new ioctl for copy Nitesh Shetty
2022-04-26 10:12     ` Nitesh Shetty
2022-04-26 10:12     ` Nitesh Shetty
2022-04-27  2:48     ` [dm-devel] " Damien Le Moal
2022-04-27  2:48       ` Damien Le Moal
2022-04-27 13:03       ` Nitesh Shetty [this message]
2022-04-27 13:03         ` Nitesh Shetty
2022-04-27 10:37     ` [dm-devel] " Hannes Reinecke
2022-04-27 10:37       ` Hannes Reinecke
2022-04-26 10:12   ` [dm-devel] [PATCH v4 04/10] block: add emulation " Nitesh Shetty
2022-04-26 10:12     ` Nitesh Shetty
2022-04-26 10:12     ` Nitesh Shetty
2022-04-27  1:33     ` [dm-devel] " kernel test robot
2022-04-27  1:33       ` kernel test robot
2022-04-26 10:12   ` [dm-devel] [PATCH v4 05/10] nvme: add copy offload support Nitesh Shetty
2022-04-26 10:12     ` Nitesh Shetty
2022-04-26 10:12     ` Nitesh Shetty
2022-04-28 14:02     ` [dm-devel] " kernel test robot
2022-04-28 14:02       ` kernel test robot
2022-04-26 10:12   ` [dm-devel] [PATCH v4 06/10] nvmet: add copy command support for bdev and file ns Nitesh Shetty
2022-04-26 10:12     ` Nitesh Shetty
2022-04-26 10:12     ` Nitesh Shetty
2022-04-28 14:53     ` [dm-devel] " kernel test robot
2022-04-28 14:53       ` kernel test robot
2022-04-26 10:12   ` [dm-devel] [PATCH v4 07/10] dm: Add support for copy offload Nitesh Shetty
2022-04-26 10:12     ` Nitesh Shetty
2022-04-26 10:12     ` Nitesh Shetty
2022-04-28 15:54     ` [dm-devel] " kernel test robot
2022-04-28 15:54       ` kernel test robot
2022-04-26 10:12   ` [dm-devel] [PATCH v4 08/10] dm: Enable copy offload for dm-linear target Nitesh Shetty
2022-04-26 10:12     ` Nitesh Shetty
2022-04-26 10:12     ` Nitesh Shetty
2022-04-26 10:12   ` [dm-devel] [PATCH v4 09/10] dm kcopyd: use copy offload support Nitesh Shetty
2022-04-26 10:12     ` Nitesh Shetty
2022-04-26 10:12     ` Nitesh Shetty
2022-04-26 10:12   ` [dm-devel] [PATCH v4 10/10] fs: add support for copy file range in zonefs Nitesh Shetty
2022-04-26 10:12     ` Nitesh Shetty
2022-04-26 10:12     ` Nitesh Shetty
2022-04-27  1:42     ` [dm-devel] " Damien Le Moal
2022-04-27  1:42       ` Damien Le Moal
2022-04-27  1:46   ` [dm-devel] [PATCH v4 00/10] Add Copy offload support Damien Le Moal
2022-04-27  1:46     ` Damien Le Moal
2022-04-27 15:38     ` [dm-devel] " Nitesh Shetty
2022-04-27 15:38       ` Nitesh Shetty
2022-04-27 21:56       ` [dm-devel] " Damien Le Moal
2022-04-27 21:56         ` Damien Le Moal
2022-04-27  2:00   ` [dm-devel] " Damien Le Moal
2022-04-27  2:00     ` Damien Le Moal
2022-04-27  2:19   ` [dm-devel] " Damien Le Moal
2022-04-27  2:19     ` Damien Le Moal
2022-04-27 12:49     ` [dm-devel] " Nitesh Shetty
2022-04-27 12:49       ` Nitesh Shetty
2022-04-27 22:05       ` [dm-devel] " Damien Le Moal
2022-04-27 22:05         ` Damien Le Moal
2022-04-28  7:49         ` [dm-devel] " Nitesh Shetty
2022-04-28  7:49           ` Nitesh Shetty
2022-04-28 21:37           ` [dm-devel] " Damien Le Moal
2022-04-28 21:37             ` Damien Le Moal
2022-04-29  3:39             ` [dm-devel] " Bart Van Assche
2022-04-29  3:39               ` Bart Van Assche
2022-05-02  4:09       ` Dave Chinner
2022-05-02  4:09         ` Dave Chinner
2022-05-02 12:54         ` [dm-devel] " Damien Le Moal
2022-05-02 12:54           ` Damien Le Moal
2022-05-02 23:20           ` [dm-devel] " Dave Chinner
2022-05-02 23:20             ` Dave Chinner
2022-05-02 12:14       ` [dm-devel] " Damien Le Moal
2022-05-02 12:14         ` Damien Le Moal
2022-05-02 12:16         ` Damien Le Moal
2022-05-02 12:16           ` Damien Le Moal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220427130315.GB9558@test-zns \
    --to=nj.shetty@samsung.com \
    --cc=damien.lemoal@opensource.wdc.com \
    --cc=dm-devel@redhat.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=nitheshshetty@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.